Adding new permission type and UI display

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Adding new permission type and UI display

Jason Dillon
When adding a new permission type, will the existing UI for matrix configuration pick up the new permission and display it?  Or does that new permission type also need additional UI configuration to allow configuration of which users have the permission?

--jason
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Adding new permission type and UI display

Alan Harder-2
It should be auto-added.. I've seen the m2-release permission in there..
Also consider whether your new permission should be settable at the
project level.. I don't recall you do or don't show it there, but
there's some way..



Jason Dillon wrote:
> When adding a new permission type, will the existing UI for matrix configuration pick up the new permission and display it?  Or does that new permission type also need additional UI configuration to allow configuration of which users have the permission?
>
>
>  

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Adding new permission type and UI display

Kohsuke Kawaguchi-3

This is actually a bit of a problem. You actually need to make sure by
yourself that the Permission instantiation happens early on the Hudson
boot. This normally means forcing a class loading from your Plugin class.

We should make Permissions discoverable via annotations so that Hudson
can auto-search them.

On 07/22/2010 02:06 PM, Alan Harder wrote:

> It should be auto-added.. I've seen the m2-release permission in there..
> Also consider whether your new permission should be settable at the
> project level.. I don't recall you do or don't show it there, but
> there's some way..
>
>
>
> Jason Dillon wrote:
>>  When adding a new permission type, will the existing UI for matrix configuration pick up the new permission and display it?  Or does that new permission type also need additional UI configuration to allow configuration of which users have the permission?
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
Kohsuke Kawaguchi | InfraDNA, Inc. | http://infradna.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Adding new permission type and UI display

Jason Dillon
Can the Plugin impl not install a permission into a permission manager?

Annotations are nice, but they tend to just make things more magical when used for bits like this.  It would be better IMO if there was a plugin <-> core contract for how to install new permissions programatically.

--jason


On Jul 22, 2010, at 4:01 PM, Kohsuke Kawaguchi wrote:

>
> This is actually a bit of a problem. You actually need to make sure by yourself that the Permission instantiation happens early on the Hudson boot. This normally means forcing a class loading from your Plugin class.
>
> We should make Permissions discoverable via annotations so that Hudson can auto-search them.
>
> On 07/22/2010 02:06 PM, Alan Harder wrote:
>> It should be auto-added.. I've seen the m2-release permission in there..
>> Also consider whether your new permission should be settable at the
>> project level.. I don't recall you do or don't show it there, but
>> there's some way..
>>
>>
>>
>> Jason Dillon wrote:
>>> When adding a new permission type, will the existing UI for matrix configuration pick up the new permission and display it?  Or does that new permission type also need additional UI configuration to allow configuration of which users have the permission?
>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
>
> --
> Kohsuke Kawaguchi | InfraDNA, Inc. | http://infradna.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]