Adopting changes from issue 26100

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Adopting changes from issue 26100

Lakshmi Narasimhan Vaikuntam
I am trying to adopt the changes required in RTCScm due to changes in Jenkins core API.  Links to the Jira issue (https://issues.jenkins-ci.org/browse/JENKINS-26100) and Team Concert Plugin
There is a new method buildEnvironment(Run<?,?.. that needs  to be overriden in RTCScm. and this is available in Jenkins Core API 2.60.
Currently Team Concert Plugin is at 1.580.1. I want to keep the Jenkins version the same and just implement the buildEnvironment method in RTCScm. The expectation is that in Jenkins 2.60  and above, the checkout step  would find the new method in RTCScm and get the map with the required data.  Would this work?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/38b2db5e-62af-4370-bc13-aff9f72640c4%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Adopting changes from issue 26100

Lakshmi Narasimhan Vaikuntam
I am able to get this working without moving the Jenkins version. Since the method didn't have new types in it's signature, the plugin compiled fine . When deployed in Jenkins 2.6,  checkout step returned a map with the required environment variables.

On Wednesday, December 6, 2017 at 12:45:36 PM UTC+5:30, Lakshmi Narasimhan wrote:
I am trying to adopt the changes required in RTCScm due to changes in Jenkins core API.  Links to the Jira issue (<a href="https://issues.jenkins-ci.org/browse/JENKINS-26100" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fissues.jenkins-ci.org%2Fbrowse%2FJENKINS-26100\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFgQlX4Mgyj6mN1q3XWZFCe9kjP5Q&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fissues.jenkins-ci.org%2Fbrowse%2FJENKINS-26100\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFgQlX4Mgyj6mN1q3XWZFCe9kjP5Q&#39;;return true;">https://issues.jenkins-ci.org/browse/JENKINS-26100) and <a href="https://github.com/jenkinsci/teamconcert-plugin" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fteamconcert-plugin\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFdSP4xbKCVBKt12b-jhCccmVM5ww&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fteamconcert-plugin\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFdSP4xbKCVBKt12b-jhCccmVM5ww&#39;;return true;">Team Concert Plugin
There is a new method buildEnvironment(Run<?,?.. that needs  to be overriden in RTCScm. and this is available in Jenkins Core API 2.60.
Currently Team Concert Plugin is at 1.580.1. I want to keep the Jenkins version the same and just implement the buildEnvironment method in RTCScm. The expectation is that in Jenkins 2.60  and above, the checkout step  would find the new method in RTCScm and get the map with the required data.  Would this work?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/5d150934-1249-422b-a28d-aeddf34462f7%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Adopting changes from issue 26100

Jesse Glick-4
Right, Java recognizes overloads by signature, not by any bytecode marker, so your trick can work here.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3xFmiVR%3DggDdQkmfzvNe%3DOm6KnivCyV9jw7gWcAxAZpw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.