Blame-Upstream-Commiters plugin send email to wrong commiter

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Blame-Upstream-Commiters plugin send email to wrong commiter

cathy
I have installed 1.0 of "Blame-Upstream-Commiters" plugin and configured a set of project (Up and down).  It is working most of the time.  However, some blame email was sent to the committer of an earlier version instead of the actual commiter who cause the build failed.  If you trace the "fingerprint", it is using the correct or the latest version of code.  Only the email notification is wrong.

Does anyone has any suggestion?
Reply | Threaded
Open this post in threaded view
|

Re: Blame-Upstream-Commiters plugin send email to wrong commiter

Michael Donohue
That appears to be as-designed.   The 'blame-upstream-committers' plugin uses the control dependency to establish blame, rather than the data dependency that is available from the fingerprinting mechanism.

-Michael
(646) 833-8884


On Wed, Jan 13, 2010 at 8:34 AM, cathy <[hidden email]> wrote:

I have installed 1.0 of "Blame-Upstream-Commiters" plugin and configured a
set of project (Up and down).  It is working most of the time.  However,
some blame email was sent to the committer of an earlier version instead of
the actual commiter who cause the build failed.  If you trace the
"fingerprint", it is using the correct or the latest version of code.  Only
the email notification is wrong.

Does anyone has any suggestion?
--
View this message in context: http://n4.nabble.com/Blame-Upstream-Commiters-plugin-send-email-to-wrong-commiter-tp1013003p1013003.html
Sent from the Hudson users mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]


Reply | Threaded
Open this post in threaded view
|

Re: Blame-Upstream-Commiters plugin send email to wrong commiter

Christoph Kutzinski
Can you expand on this from a plugin developer's perspective?

I've used the 'blame-upstream-committers' plugin as a guide when implementing the analogue feature in the jabber plugin and I thought that this would be what you called the 'data dependency'. When it is not, how can I get the 'data dependency' to upstream jobs?

Thanks,
Christoph

-------- Original-Nachricht --------
> Datum: Wed, 13 Jan 2010 09:29:42 -0500
> Von: Michael Donohue <[hidden email]>
> An: [hidden email]
> Betreff: Re: Blame-Upstream-Commiters plugin send email to wrong commiter

> That appears to be as-designed.   The 'blame-upstream-committers' plugin
> uses the control dependency to establish blame, rather than the data
> dependency that is available from the fingerprinting mechanism.
>
> -Michael
> (646) 833-8884
>
>
> On Wed, Jan 13, 2010 at 8:34 AM, cathy <[hidden email]> wrote:
>
> >
> > I have installed 1.0 of "Blame-Upstream-Commiters" plugin and configured
> a
> > set of project (Up and down).  It is working most of the time.  However,
> > some blame email was sent to the committer of an earlier version instead
> of
> > the actual commiter who cause the build failed.  If you trace the
> > "fingerprint", it is using the correct or the latest version of code.
> Only
> > the email notification is wrong.
> >
> > Does anyone has any suggestion?
> > --
> > View this message in context:
> >
> http://n4.nabble.com/Blame-Upstream-Commiters-plugin-send-email-to-wrong-commiter-tp1013003p1013003.html
> > Sent from the Hudson users mailing list archive at Nabble.com.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Blame-Upstream-Commiters plugin send email to wrong commiter

Michael Donohue
I made a mistake - I thought it was calculating the upstream builds on its own, but it is using AbstractBuild.getUpstreamBuilds() which does use fingerprint information.   I was totally wrong there. 

-Michael
(646) 833-8884


On Wed, Jan 13, 2010 at 12:06 PM, Christoph Kutzinski <[hidden email]> wrote:
Can you expand on this from a plugin developer's perspective?

I've used the 'blame-upstream-committers' plugin as a guide when implementing the analogue feature in the jabber plugin and I thought that this would be what you called the 'data dependency'. When it is not, how can I get the 'data dependency' to upstream jobs?

Thanks,
Christoph

-------- Original-Nachricht --------
> Datum: Wed, 13 Jan 2010 09:29:42 -0500
> Von: Michael Donohue <[hidden email]>
> An: [hidden email]
> Betreff: Re: Blame-Upstream-Commiters plugin send email to wrong commiter

> That appears to be as-designed.   The 'blame-upstream-committers' plugin
> uses the control dependency to establish blame, rather than the data
> dependency that is available from the fingerprinting mechanism.
>
> -Michael
> (646) 833-8884
>
>
> On Wed, Jan 13, 2010 at 8:34 AM, cathy <[hidden email]> wrote:
>
> >
> > I have installed 1.0 of "Blame-Upstream-Commiters" plugin and configured
> a
> > set of project (Up and down).  It is working most of the time.  However,
> > some blame email was sent to the committer of an earlier version instead
> of
> > the actual commiter who cause the build failed.  If you trace the
> > "fingerprint", it is using the correct or the latest version of code.
> Only
> > the email notification is wrong.
> >
> > Does anyone has any suggestion?
> > --
> > View this message in context:
> >
> http://n4.nabble.com/Blame-Upstream-Commiters-plugin-send-email-to-wrong-commiter-tp1013003p1013003.html
> > Sent from the Hudson users mailing list archive at Nabble.com.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]