Since we have successfully integrated the GitHub checks in buildPlugin for quite a while: would it make sense to disable the old build status results on https://ci.jenkins.io?
Currently I get two different results from Jenkins (and the old one is wrong since it assumes that status UNSTABLE means that there are test failures): 1) Jenkins 2) continuous-integration/jenkins/pr-merge — This commit has test failures You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1112CAB0-15E1-4110-8CBF-FCFB8B91A29C%40gmail.com. |
I'm not sure if this is a situation we need to take care of:
The branch source plugin may publish two builds including the merge build and branch build (if a pr is opened long after the branch is pushed?) to the PR, but the github-checks will publish only one since we used the build listener (the one for the branch will be replaced later if you file a PR based on that branch). 在2020年11月23日星期一 UTC+8 下午4:56:04<[hidden email]> 写道:
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/f1550f97-1916-425c-b679-31aba59f229dn%40googlegroups.com. |
In reply to this post by Ulli Hafner
On Mon, Nov 23, 2020 at 3:56 AM Ullrich Hafner <[hidden email]> wrote:
> Since we have successfully integrated the GitHub checks in buildPlugin for quite a while: would it make sense to disable the old build status results on https://ci.jenkins.io? I think it would make sense. If this happens, please post an announcement. At least JEP-229 would need a minor change: https://github.com/jglick/verify-ci-status-action/issues/1 -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3_S9iu2-BSq6YvwKjWM_xegTJazVJC%3D9w_UagP68U21w%40mail.gmail.com. |
I filed INFRA-2866 to track.
-- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr116xYT3OB%2B2Bx0Ah%2Bn1K9SCqkZ4SaZhOYs-QJ_meT%3DRQ%40mail.gmail.com. |
Done
On Wednesday, 6 January 2021 at 21:55:26 UTC Jesse Glick wrote:
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/84a0504d-74ce-43e0-b650-70d2a49e2aefn%40googlegroups.com. |
In reply to this post by Jesse Glick-4
Currently a successful incremental deployment is shown with a separate GitHub checks output, this is very handy to directly jump to the new release. Would it make sense to add a negative (or neutral) check in case something went wrong? E.g., if the PR is not in sync with the base branch then the check result is completely missing. In such a case one needs to dig into the console log just to see that the branch is not in sync.
> Am 23.11.2020 um 15:59 schrieb Jesse Glick <[hidden email]>: > > On Mon, Nov 23, 2020 at 3:56 AM Ullrich Hafner <[hidden email]> wrote: >> Since we have successfully integrated the GitHub checks in buildPlugin for quite a while: would it make sense to disable the old build status results on https://ci.jenkins.io? > > I think it would make sense. > > If this happens, please post an announcement. At least JEP-229 would > need a minor change: > https://github.com/jglick/verify-ci-status-action/issues/1 > > -- > You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. > To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3_S9iu2-BSq6YvwKjWM_xegTJazVJC%3D9w_UagP68U21w%40mail.gmail.com. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/B45C82E8-B963-4696-B822-19B36606B64C%40gmail.com. |
On Mon, Feb 22, 2021 at 4:23 PM Ullrich Hafner <[hidden email]> wrote: Would it make sense to add a negative (or neutral) check in case something [with Incrementals] went wrong? You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3p%3DKUOqLDUQZhxgiH7axjxE0%3Dm6KAGSBnh%3Dmx%3DHmGGHA%40mail.gmail.com. |
Free forum by Nabble | Edit this page |