CIFS Publisher Plugin

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

CIFS Publisher Plugin

Muis, Jeroen
Hi,
 
It seems most publisher plugins are able to support both flatten and subdir publishing by setting a 'flatten' flag.
This seems to make sense, as in many occasions you would like to preserve subdir structures.
The CIFS plugin currently does not support this and flattens by default.
 
Attached you will find a patch adding support for this option with backwards-compatibility behavior.
I'm not quite sure who the current maintainer is for this plugin as the WIKI says maintainer: N/A (id: acearl ) and there is also no JIRA component available for this plugin.
 
Can the maintainer (or someone with commit access) apply / review?
 
Thanks,
Jeroen Muis
 
 

cifs.patch (10K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: CIFS Publisher Plugin

slide
On Mon, Dec 6, 2010 at 6:15 AM, Muis, Jeroen <[hidden email]> wrote:

> Hi,
>
> It seems most publisher plugins are able to support both flatten and subdir
> publishing by setting a 'flatten' flag.
> This seems to make sense, as in many occasions you would like to preserve
> subdir structures.
> The CIFS plugin currently does not support this and flattens by default.
>
> Attached you will find a patch adding support for this option with
> backwards-compatibility behavior.
> I'm not quite sure who the current maintainer is for this plugin as the WIKI
> says maintainer: N/A (id: acearl ) and there is also no JIRA component
> available for this plugin.
>
> Can the maintainer (or someone with commit access) apply / review?
>
> Thanks,
> Jeroen Muis
>
>

I am the maintainer of the plugin, I'll review the patch.

Thanks!

slide

--
slide-o-blog
http://slide-o-blog.blogspot.com/
Reply | Threaded
Open this post in threaded view
|

Re: CIFS Publisher Plugin

slide
I took a look at this patch and with the latest code it does not work.
The entries do not get saved if the flatten checkbox is not saved. I
will continue debugging the issue.

On Mon, Dec 6, 2010 at 6:59 AM, Slide <[hidden email]> wrote:

> On Mon, Dec 6, 2010 at 6:15 AM, Muis, Jeroen <[hidden email]> wrote:
>> Hi,
>>
>> It seems most publisher plugins are able to support both flatten and subdir
>> publishing by setting a 'flatten' flag.
>> This seems to make sense, as in many occasions you would like to preserve
>> subdir structures.
>> The CIFS plugin currently does not support this and flattens by default.
>>
>> Attached you will find a patch adding support for this option with
>> backwards-compatibility behavior.
>> I'm not quite sure who the current maintainer is for this plugin as the WIKI
>> says maintainer: N/A (id: acearl ) and there is also no JIRA component
>> available for this plugin.
>>
>> Can the maintainer (or someone with commit access) apply / review?
>>
>> Thanks,
>> Jeroen Muis
>>
>>
>
> I am the maintainer of the plugin, I'll review the patch.
>
> Thanks!
>
> slide
>
> --
> slide-o-blog
> http://slide-o-blog.blogspot.com/
>



--
slide-o-blog
http://slide-o-blog.blogspot.com/
Reply | Threaded
Open this post in threaded view
|

RE: Re: CIFS Publisher Plugin

martin.loiselle@medrium.com
This post has NOT been accepted by the mailing list yet.
On vacation:
I will be out of the office starting the Dec. 23rd and
will return on January 10.

for any problem related to your email or computer, please send an email to [hidden email].

For any emergency, call at 1-418-264-6911
Reply | Threaded
Open this post in threaded view
|

Re: CIFS Publisher Plugin

Muis, Jeroen
In reply to this post by slide
Hi,

I remember some issues when writing the patch as I was quite unfamiliar with Hudson plugins & data binding.
If I remember correct at one point I noticed the correct JSON object coming in, but the list binding features did not function properly, incorrectly setting flatten flags.
Again, it was something in my early attempts to create it, and I did not pay attention to it at a later stage as after introducing the databound constructor it seemed to work as expected.

If you need any help from me, or need me to test / validate something please let me know and I'll see what I can do.

-- Jeroen

On Mon, 2011-01-03 at 13:15 -0700, Slide wrote:
I took a look at this patch and with the latest code it does not work.
The entries do not get saved if the flatten checkbox is not saved. I
will continue debugging the issue.

On Mon, Dec 6, 2010 at 6:59 AM, Slide <[hidden email]> wrote:
> On Mon, Dec 6, 2010 at 6:15 AM, Muis, Jeroen <[hidden email]> wrote:
>> Hi,
>>
>> It seems most publisher plugins are able to support both flatten and subdir
>> publishing by setting a 'flatten' flag.
>> This seems to make sense, as in many occasions you would like to preserve
>> subdir structures.
>> The CIFS plugin currently does not support this and flattens by default.
>>
>> Attached you will find a patch adding support for this option with
>> backwards-compatibility behavior.
>> I'm not quite sure who the current maintainer is for this plugin as the WIKI
>> says maintainer: N/A (id: acearl ) and there is also no JIRA component
>> available for this plugin.
>>
>> Can the maintainer (or someone with commit access) apply / review?
>>
>> Thanks,
>> Jeroen Muis
>>
>>
>
> I am the maintainer of the plugin, I'll review the patch.
>
> Thanks!
>
> slide
>
> --
> slide-o-blog
> http://slide-o-blog.blogspot.com/
>




Reply | Threaded
Open this post in threaded view
|

RE: Re: CIFS Publisher Plugin

martin.loiselle@medrium.com
This post has NOT been accepted by the mailing list yet.
On vacation:
I will be out of the office starting the Dec. 23rd and
will return on January 10.

for any problem related to your email or computer, please send an email to [hidden email].

For any emergency, call at 1-418-264-6911
Reply | Threaded
Open this post in threaded view
|

Re: CIFS Publisher Plugin

slide
In reply to this post by Muis, Jeroen
I applied the patch (with some minor modifications). The patch had flattening as the default, but to maintain backwards compatibility, the patch was modified so that flattening is false by default. These modifications should be in 1.1.10 which was released the other day.

On Mon, Dec 6, 2010 at 6:15 AM, Muis, Jeroen <[hidden email]> wrote:
Hi,
 
It seems most publisher plugins are able to support both flatten and subdir publishing by setting a 'flatten' flag.
This seems to make sense, as in many occasions you would like to preserve subdir structures.
The CIFS plugin currently does not support this and flattens by default.
 
Attached you will find a patch adding support for this option with backwards-compatibility behavior.
I'm not quite sure who the current maintainer is for this plugin as the WIKI says maintainer: N/A (id: acearl ) and there is also no JIRA component available for this plugin.
 
Can the maintainer (or someone with commit access) apply / review?
 
Thanks,
Jeroen Muis
 
 



--
slide-o-blog
http://slide-o-blog.blogspot.com/
Reply | Threaded
Open this post in threaded view
|

RE: Re: CIFS Publisher Plugin

martin.loiselle@medrium.com
This post has NOT been accepted by the mailing list yet.
On vacation:
I will be out of the office starting the Dec. 23rd and
will return on January 10.

for any problem related to your email or computer, please send an email to [hidden email].

For any emergency, call at 1-418-264-6911
Reply | Threaded
Open this post in threaded view
|

Re: CIFS Publisher Plugin

Muis, Jeroen
In reply to this post by slide
I do believe the old behavior was actually flattening... (subdirs not being created)
Can you please verify as you now might break backwards compatibility by not setting flattening mode. (creating subdirs)

If the old behavior was creating subdirs I would not have started a patch at all....

Thanks,
Jeroen



On Fri, 2011-01-07 at 12:11 -0700, Slide wrote:
I applied the patch (with some minor modifications). The patch had flattening as the default, but to maintain backwards compatibility, the patch was modified so that flattening is false by default. These modifications should be in 1.1.10 which was released the other day.

On Mon, Dec 6, 2010 at 6:15 AM, Muis, Jeroen <[hidden email]> wrote:
Hi,
 
It seems most publisher plugins are able to support both flatten and subdir publishing by setting a 'flatten' flag.
This seems to make sense, as in many occasions you would like to preserve subdir structures.
The CIFS plugin currently does not support this and flattens by default.
 
Attached you will find a patch adding support for this option with backwards-compatibility behavior.
I'm not quite sure who the current maintainer is for this plugin as the WIKI says maintainer: N/A (id: acearl ) and there is also no JIRA component available for this plugin.
 
Can the maintainer (or someone with commit access) apply / review?
 
Thanks,
Jeroen Muis
 
 



--
slide-o-blog
http://slide-o-blog.blogspot.com/

Reply | Threaded
Open this post in threaded view
|

Re: CIFS Publisher Plugin

slide
The old behavior for me was it creating sub-directories. It was working just fine.

On Mon, Jan 17, 2011 at 2:07 AM, Jeroen Muis <[hidden email]> wrote:
I do believe the old behavior was actually flattening... (subdirs not being created)
Can you please verify as you now might break backwards compatibility by not setting flattening mode. (creating subdirs)

If the old behavior was creating subdirs I would not have started a patch at all....

Thanks,
Jeroen




On Fri, 2011-01-07 at 12:11 -0700, Slide wrote:
I applied the patch (with some minor modifications). The patch had flattening as the default, but to maintain backwards compatibility, the patch was modified so that flattening is false by default. These modifications should be in 1.1.10 which was released the other day.

On Mon, Dec 6, 2010 at 6:15 AM, Muis, Jeroen <[hidden email]> wrote:
Hi,
 
It seems most publisher plugins are able to support both flatten and subdir publishing by setting a 'flatten' flag.
This seems to make sense, as in many occasions you would like to preserve subdir structures.
The CIFS plugin currently does not support this and flattens by default.
 
Attached you will find a patch adding support for this option with backwards-compatibility behavior.
I'm not quite sure who the current maintainer is for this plugin as the WIKI says maintainer: N/A (id: acearl ) and there is also no JIRA component available for this plugin.
 
Can the maintainer (or someone with commit access) apply / review?
 
Thanks,
Jeroen Muis
 
 



--
slide-o-blog
http://slide-o-blog.blogspot.com/




--
slide-o-blog
http://slide-o-blog.blogspot.com/