Changes to Ivy Plugin

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Changes to Ivy Plugin

Martin Ficker
Hello,

I've made two small changes to the ivy plugin:

1. Ivy expects an  Implementation of a Message Interface for logging. If this is not provided it will write everything to
  err. I added a implementation that redirects the messages to java.util.logging. (I'm not sure about the correct translation of the
  different loglevels, but the current implementation seems reasonable for me).

2. The Plugin performed bad when having many projects under ivys control. Commitng changes in a projects configuration sometimes took  severall minutes. (I've got around 120 Projects under ivy controll). I simplified the calculation of dependencys and now  avoid configuring Ivy each time.

I'd be happy if this changes could make it into the svn.

Best regards,

Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Ivy_Patch.patch (8K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Changes to Ivy Plugin

David Seymore
On Wed, Jun 4, 2008 at 9:54 AM, Martin Ficker <[hidden email]> wrote:
Hello,

I've made two small changes to the ivy plugin:

1. Ivy expects an  Implementation of a Message Interface for logging. If this is not provided it will write everything to
  err. I added a implementation that redirects the messages to java.util.logging. (I'm not sure about the correct translation of the
  different loglevels, but the current implementation seems reasonable for me).

2. The Plugin performed bad when having many projects under ivys control. Commitng changes in a projects configuration sometimes took  severall minutes. (I've got around 120 Projects under ivy controll). I simplified the calculation of dependencys and now  avoid configuring Ivy each time.

I'd be happy if this changes could make it into the svn.

Best regards,

Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]


Hi Martin,
   I've got about 15 projects managed with Ivy in hudson. I haven't experienced any problems, though.. but, I should be able to spend some time today testing your patch.

Thanks!
--
David Seymore
[hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: Changes to Ivy Plugin

Kohsuke Kawaguchi
Administrator
In reply to this post by Martin Ficker

Hi, Martin,

I see that you've been hacking Hudson for some time now. Would you be
interested in becoming a committer?

We'd still like changes to be discussed upfront, just like you've been
doing, but I think it'll help us all avoid the extra steps of sending
and applying patches.

It also makes it easier when you come up with a new plugin idea ;-)

If you are interested, let me know your java.net ID.

Martin Ficker wrote:

> Hello,
>
> I've made two small changes to the ivy plugin:
>
> 1. Ivy expects an  Implementation of a Message Interface for logging. If
> this is not provided it will write everything to
>   err. I added a implementation that redirects the messages to
> java.util.logging. (I'm not sure about the correct translation of the
>   different loglevels, but the current implementation seems reasonable for
> me).
>
> 2. The Plugin performed bad when having many projects under ivys control.
> Commitng changes in a projects configuration sometimes took  severall
> minutes. (I've got around 120 Projects under ivy controll). I simplified the
> calculation of dependencys and now  avoid configuring Ivy each time.
>
> I'd be happy if this changes could make it into the svn.
>
> Best regards,
>
> Martin
>
>
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

hello world, plugin tutorial

mauk
In reply to this post by David Seymore
hello world,

i've tried out the plugin tutorial and wonder why i get an old version
of the hello-world-plugin. some little bugs i found are already fixed in
the subversion.

little change request for config.jelly: remove ${rootURL}.
if you run hudson at something like localhost:8080/ the current version
works fine but it doesn't work for something like localhost:8080/hudson/.
it works by removing ${rootURL}.
these little bug are also in other plugins.

regards
mauk

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: hello world, plugin tutorial

Kohsuke Kawaguchi
Administrator
mauk wrote:

> hello world,
>
> i've tried out the plugin tutorial and wonder why i get an old version
> of the hello-world-plugin. some little bugs i found are already fixed in
> the subversion.
>
> little change request for config.jelly: remove ${rootURL}.
> if you run hudson at something like localhost:8080/ the current version
> works fine but it doesn't work for something like localhost:8080/hudson/.
> it works by removing ${rootURL}.
> these little bug are also in other plugins.
I don't think removing ${rootURL} is the right thing, although it's
possible that we are messing up some separator handling.


--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Changes to Ivy Plugin

Martin Ficker
In reply to this post by Kohsuke Kawaguchi
Hello,

having svn write acces would be fine.
My Id is: martinficker

Best regards

Martin
**Kohsuke Kawaguchi schrieb:

>
> Hi, Martin,
>
> I see that you've been hacking Hudson for some time now. Would you be
> interested in becoming a committer?
>
> We'd still like changes to be discussed upfront, just like you've been
> doing, but I think it'll help us all avoid the extra steps of sending
> and applying patches.
>
> It also makes it easier when you come up with a new plugin idea ;-)
>
> If you are interested, let me know your java.net ID.
>
> Martin Ficker wrote:
>> Hello,
>>
>> I've made two small changes to the ivy plugin:
>>
>> 1. Ivy expects an  Implementation of a Message Interface for logging. If
>> this is not provided it will write everything to
>>   err. I added a implementation that redirects the messages to
>> java.util.logging. (I'm not sure about the correct translation of the
>>   different loglevels, but the current implementation seems
>> reasonable for
>> me).
>>
>> 2. The Plugin performed bad when having many projects under ivys
>> control.
>> Commitng changes in a projects configuration sometimes took  severall
>> minutes. (I've got around 120 Projects under ivy controll). I
>> simplified the
>> calculation of dependencys and now  avoid configuring Ivy each time.
>>
>> I'd be happy if this changes could make it into the svn.
>>
>> Best regards,
>>
>> Martin
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Changes to Ivy Plugin

Kohsuke Kawaguchi
Administrator

Added. Welcome on board.

M. Ficker wrote:

> Hello,
>
> having svn write acces would be fine.
> My Id is: martinficker
>
> Best regards
>
> Martin
> **Kohsuke Kawaguchi schrieb:
>>
>> Hi, Martin,
>>
>> I see that you've been hacking Hudson for some time now. Would you be
>> interested in becoming a committer?
>>
>> We'd still like changes to be discussed upfront, just like you've been
>> doing, but I think it'll help us all avoid the extra steps of sending
>> and applying patches.
>>
>> It also makes it easier when you come up with a new plugin idea ;-)
>>
>> If you are interested, let me know your java.net ID.
>>
>> Martin Ficker wrote:
>>> Hello,
>>>
>>> I've made two small changes to the ivy plugin:
>>>
>>> 1. Ivy expects an  Implementation of a Message Interface for logging. If
>>> this is not provided it will write everything to
>>>   err. I added a implementation that redirects the messages to
>>> java.util.logging. (I'm not sure about the correct translation of the
>>>   different loglevels, but the current implementation seems
>>> reasonable for
>>> me).
>>>
>>> 2. The Plugin performed bad when having many projects under ivys
>>> control.
>>> Commitng changes in a projects configuration sometimes took  severall
>>> minutes. (I've got around 120 Projects under ivy controll). I
>>> simplified the
>>> calculation of dependencys and now  avoid configuring Ivy each time.
>>>
>>> I'd be happy if this changes could make it into the svn.
>>>
>>> Best regards,
>>>
>>> Martin
>>>
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>
>>
>
>

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: hello world, plugin tutorial

mauk
In reply to this post by Kohsuke Kawaguchi
>> i've tried out the plugin tutorial and wonder why i get an old version
>> of the hello-world-plugin. some little bugs i found are already fixed
>> in the subversion.
>>
>> little change request for config.jelly: remove ${rootURL}.
>> if you run hudson at something like localhost:8080/ the current
>> version works fine but it doesn't work for something like
>> localhost:8080/hudson/.
>> it works by removing ${rootURL}.
>> these little bug are also in other plugins.
>
> I don't think removing ${rootURL} is the right thing, although it's
> possible that we are messing up some separator handling.

okay. but some plugins already don't use ${rootURL}.
because it's definitely not the same the plugins should all use the same
method.

@plugin tutorial:
how can the plugin tutorial fixed so that you get a newer version of the
hello-world-plugin?

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: hello world, plugin tutorial

Kohsuke Kawaguchi
Administrator
mauk wrote:

>>> i've tried out the plugin tutorial and wonder why i get an old version
>>> of the hello-world-plugin. some little bugs i found are already fixed
>>> in the subversion.
>>>
>>> little change request for config.jelly: remove ${rootURL}.
>>> if you run hudson at something like localhost:8080/ the current
>>> version works fine but it doesn't work for something like
>>> localhost:8080/hudson/.
>>> it works by removing ${rootURL}.
>>> these little bug are also in other plugins.
>>
>> I don't think removing ${rootURL} is the right thing, although it's
>> possible that we are messing up some separator handling.
>
> okay. but some plugins already don't use ${rootURL}.
> because it's definitely not the same the plugins should all use the same
> method.
>
> @plugin tutorial:
> how can the plugin tutorial fixed so that you get a newer version of the
> hello-world-plugin?
I need to refresh my memory on where the skeleton comes from. I should
probably follow the tutorial again and see it for myself.

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Changes to Ivy Plugin

Martin Ficker
In reply to this post by Martin Ficker

Since nobody objected and I now have svn access I'll apply the patch
tomorrow.

Best regards,
Martin

Martin Ficker schrieb:

> Hello,
>
> I've made two small changes to the ivy plugin:
>
> 1. Ivy expects an  Implementation of a Message Interface for logging.
> If this is not provided it will write everything to
>   err. I added a implementation that redirects the messages to
> java.util.logging. (I'm not sure about the correct translation of the
>   different loglevels, but the current implementation seems reasonable
> for me).
>
> 2. The Plugin performed bad when having many projects under ivys
> control. Commitng changes in a projects configuration sometimes took  
> severall minutes. (I've got around 120 Projects under ivy controll). I
> simplified the calculation of dependencys and now  avoid configuring
> Ivy each time.
>
> I'd be happy if this changes could make it into the svn.
>
> Best regards,
>
> Martin


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Changes to Ivy Plugin

Kohsuke Kawaguchi
Administrator
M. Ficker wrote:
> Since nobody objected and I now have svn access I'll apply the patch
> tomorrow.

Thanks!


> Best regards,
> Martin
>
> Martin Ficker schrieb:
>> Hello,
>>
>> I've made two small changes to the ivy plugin:
>>
>> 1. Ivy expects an  Implementation of a Message Interface for logging.
>> If this is not provided it will write everything to
>>   err. I added a implementation that redirects the messages to
>> java.util.logging. (I'm not sure about the correct translation of the
>>   different loglevels, but the current implementation seems reasonable
>> for me).
>>
>> 2. The Plugin performed bad when having many projects under ivys
>> control. Commitng changes in a projects configuration sometimes took  
>> severall minutes. (I've got around 120 Projects under ivy controll). I
>> simplified the calculation of dependencys and now  avoid configuring
>> Ivy each time.
>>
>> I'd be happy if this changes could make it into the svn.
>>
>> Best regards,
>>
>> Martin
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment