Contributing to Jenkins docker plugin

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Contributing to Jenkins docker plugin

romje
Hi all,
I worked for a french large customer on a patched version of this plugin using HttpClient 5 as the main rather than default Netty client. It seems to work well (large tests are done on customer site and I don't have many visibility). The code produced is not clean (I took the quick & dirty way).
I would like to setup a discussion if possible with PJ Darton 7 other current maintainers.

Thanks for your help
Kind regards

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/f8246a39-70db-4f40-8bb6-10800e3a4774n%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Contributing to Jenkins docker plugin

Oleg Nenashev
Hi Jerome, 

Thanks for you work! Indeed it might be a good addition to the plugin. My recommendation would be to start the discussion by submitting a pull request or an issue in https://github.com/jenkinsci/docker-plugin. It would be the best way to get in contact with the plugin maintainer(s) and interested contributors/users. It is not a problem if the code is not clean, you can start discussion with what you have and then agree on the next steps with the maintainers.

I will CC Peter Darton in this thread.

Best regards,
Oleg Nenashev




On Wednesday, April 7, 2021 at 8:55:20 PM UTC+2 [hidden email] wrote:
Hi all,
I worked for a french large customer on a patched version of this plugin using HttpClient 5 as the main rather than default Netty client. It seems to work well (large tests are done on customer site and I don't have many visibility). The code produced is not clean (I took the quick & dirty way).
I would like to setup a discussion if possible with PJ Darton 7 other current maintainers.

Thanks for your help
Kind regards

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/42e6f5f8-daaf-408a-b564-50ff5a92a8a4n%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Contributing to Jenkins docker plugin

Oleg Nenashev
// CC Peter Darton

On Wed, Apr 7, 2021 at 11:34 PM Oleg Nenashev <[hidden email]> wrote:
Hi Jerome, 

Thanks for you work! Indeed it might be a good addition to the plugin. My recommendation would be to start the discussion by submitting a pull request or an issue in https://github.com/jenkinsci/docker-plugin. It would be the best way to get in contact with the plugin maintainer(s) and interested contributors/users. It is not a problem if the code is not clean, you can start discussion with what you have and then agree on the next steps with the maintainers.

I will CC Peter Darton in this thread.

Best regards,
Oleg Nenashev




On Wednesday, April 7, 2021 at 8:55:20 PM UTC+2 [hidden email] wrote:
Hi all,
I worked for a french large customer on a patched version of this plugin using HttpClient 5 as the main rather than default Netty client. It seems to work well (large tests are done on customer site and I don't have many visibility). The code produced is not clean (I took the quick & dirty way).
I would like to setup a discussion if possible with PJ Darton 7 other current maintainers.

Thanks for your help
Kind regards

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/G-hS9emqG6w/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/42e6f5f8-daaf-408a-b564-50ff5a92a8a4n%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDeP89g_8rYJpbTaGh9v6Y37LacE0VOW0iRWaG7wUa_Qw%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Contributing to Jenkins docker plugin

romje
Hi,
thanks Oleg for your quick answer ...
Sounds perfect even if I am not very proud from my current source code but it was done  with  a POC idea but as usual  the scope may change..
Thanks again
regards

Le mer. 7 avr. 2021 à 23:34, Oleg Nenashev <[hidden email]> a écrit :
// CC Peter Darton

On Wed, Apr 7, 2021 at 11:34 PM Oleg Nenashev <[hidden email]> wrote:
Hi Jerome, 

Thanks for you work! Indeed it might be a good addition to the plugin. My recommendation would be to start the discussion by submitting a pull request or an issue in https://github.com/jenkinsci/docker-plugin. It would be the best way to get in contact with the plugin maintainer(s) and interested contributors/users. It is not a problem if the code is not clean, you can start discussion with what you have and then agree on the next steps with the maintainers.

I will CC Peter Darton in this thread.

Best regards,
Oleg Nenashev




On Wednesday, April 7, 2021 at 8:55:20 PM UTC+2 [hidden email] wrote:
Hi all,
I worked for a french large customer on a patched version of this plugin using HttpClient 5 as the main rather than default Netty client. It seems to work well (large tests are done on customer site and I don't have many visibility). The code produced is not clean (I took the quick & dirty way).
I would like to setup a discussion if possible with PJ Darton 7 other current maintainers.

Thanks for your help
Kind regards

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/G-hS9emqG6w/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/42e6f5f8-daaf-408a-b564-50ff5a92a8a4n%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDeP89g_8rYJpbTaGh9v6Y37LacE0VOW0iRWaG7wUa_Qw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEGYFEKhcKx6YSa%3D-1hvPWrPB7Lq2Qi3K3cHxhqw7Jp9RZiAUQ%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Contributing to Jenkins docker plugin

Oleg Nenashev
Hi,

You are welcome. And no worries about the code, you can check out some of my prototype PRs in Jenkins :)

Best regards,
Oleg


On Thu, Apr 8, 2021 at 9:31 AM jerome moliere <[hidden email]> wrote:
Hi,
thanks Oleg for your quick answer ...
Sounds perfect even if I am not very proud from my current source code but it was done  with  a POC idea but as usual  the scope may change..
Thanks again
regards

Le mer. 7 avr. 2021 à 23:34, Oleg Nenashev <[hidden email]> a écrit :
// CC Peter Darton

On Wed, Apr 7, 2021 at 11:34 PM Oleg Nenashev <[hidden email]> wrote:
Hi Jerome, 

Thanks for you work! Indeed it might be a good addition to the plugin. My recommendation would be to start the discussion by submitting a pull request or an issue in https://github.com/jenkinsci/docker-plugin. It would be the best way to get in contact with the plugin maintainer(s) and interested contributors/users. It is not a problem if the code is not clean, you can start discussion with what you have and then agree on the next steps with the maintainers.

I will CC Peter Darton in this thread.

Best regards,
Oleg Nenashev




On Wednesday, April 7, 2021 at 8:55:20 PM UTC+2 [hidden email] wrote:
Hi all,
I worked for a french large customer on a patched version of this plugin using HttpClient 5 as the main rather than default Netty client. It seems to work well (large tests are done on customer site and I don't have many visibility). The code produced is not clean (I took the quick & dirty way).
I would like to setup a discussion if possible with PJ Darton 7 other current maintainers.

Thanks for your help
Kind regards

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/G-hS9emqG6w/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/42e6f5f8-daaf-408a-b564-50ff5a92a8a4n%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDeP89g_8rYJpbTaGh9v6Y37LacE0VOW0iRWaG7wUa_Qw%40mail.gmail.com.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/G-hS9emqG6w/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEGYFEKhcKx6YSa%3D-1hvPWrPB7Lq2Qi3K3cHxhqw7Jp9RZiAUQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLB9NOrVPOQm1jfVEOEtrj1%2But-PJK5ZbQhL%3DUs6gQoj3Q%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Contributing to Jenkins docker plugin

Peter Darton
Hi folks,
So, as you might've guessed, I don't normally monitor these conversations here and would've been oblivious to this one if Oleg hadn't CC:ed me.

Re: " PJ Darton 7 other current maintainers"
Right now, it's just me; some years ago I contributed some stuff to the plugin, I was added as a co-maintainer by the previous maintainer, and then they left leaving me all alone.

I am (painfully!) aware of gaps in my understanding of how this code works, and how the dependencies on other code is managed is one of those gaps.  e.g. its dependency on the docker-java library, done via the docker-java-api-plugin, is a painful bit of tech-debt, as demonstrated by https://github.com/jenkinsci/docker-plugin/pull/829 and I don't know how to resolve that (although I think https://github.com/jenkinsci/docker-java-api-plugin/pull/9 would help).

I don't know enough about Netty vs HttpClient to pass judgement on the pros & cons of either; I have no idea why one was selected over the other back in the past, or the risks inherent in changing this now ... but this also means that I have no strong feelings for/against either as long as it all works and I don't receive a deluge of "everything broke when I upgraded to the latest version" bug reports.

Overall, I'm happy to accept PRs as long as:
 - the changes seem to "fit" well with the plugin's objectivs,
 - the code is good before its merged (feel free to create a work-in-progress PR that isn't ready for merging),
 - it's clear (to users, to me & any future maintainers) what it does, and
 - (most importantly) the changes don't break anything.

What I can't do is dedicate much time to developing this sort of thing myself; it's not a core part of "my day job" and I've got a gazillion things I should be working on instead of this
... but if you want changes made and are prepared to make it easy for me then I'm happy to cooperate.

I guess the first thing I'd need to understand is "why?" - it works "as-is" so why change it now?  What are you really trying to achieve ... and how can this be (unit) tested?

Regards,
  Peter


On Thursday, 8 April 2021 at 08:35:11 UTC+1 Oleg Nenashev wrote:
Hi,

You are welcome. And no worries about the code, you can check out some of my prototype PRs in Jenkins :)

Best regards,
Oleg


On Thu, Apr 8, 2021 at 9:31 AM jerome moliere <[hidden email]> wrote:
Hi,
thanks Oleg for your quick answer ...
Sounds perfect even if I am not very proud from my current source code but it was done  with  a POC idea but as usual  the scope may change..
Thanks again
regards

Le mer. 7 avr. 2021 à 23:34, Oleg Nenashev <[hidden email]> a écrit :
// CC Peter Darton

On Wed, Apr 7, 2021 at 11:34 PM Oleg Nenashev <[hidden email]> wrote:
Hi Jerome, 

Thanks for you work! Indeed it might be a good addition to the plugin. My recommendation would be to start the discussion by submitting a pull request or an issue in https://github.com/jenkinsci/docker-plugin. It would be the best way to get in contact with the plugin maintainer(s) and interested contributors/users. It is not a problem if the code is not clean, you can start discussion with what you have and then agree on the next steps with the maintainers.

I will CC Peter Darton in this thread.

Best regards,
Oleg Nenashev




On Wednesday, April 7, 2021 at 8:55:20 PM UTC+2 [hidden email] wrote:
Hi all,
I worked for a french large customer on a patched version of this plugin using HttpClient 5 as the main rather than default Netty client. It seems to work well (large tests are done on customer site and I don't have many visibility). The code produced is not clean (I took the quick & dirty way).
I would like to setup a discussion if possible with PJ Darton 7 other current maintainers.

Thanks for your help
Kind regards

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/G-hS9emqG6w/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/42e6f5f8-daaf-408a-b564-50ff5a92a8a4n%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDeP89g_8rYJpbTaGh9v6Y37LacE0VOW0iRWaG7wUa_Qw%40mail.gmail.com.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/G-hS9emqG6w/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/a9efcce2-56e1-4a1a-8544-c04cd2732a68n%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Contributing to Jenkins docker plugin

nicolas de loof-2


Le jeu. 8 avr. 2021 à 14:25, [hidden email] <[hidden email]> a écrit :
Hi folks,
So, as you might've guessed, I don't normally monitor these conversations here and would've been oblivious to this one if Oleg hadn't CC:ed me.

Re: " PJ Darton 7 other current maintainers"
Right now, it's just me; some years ago I contributed some stuff to the plugin, I was added as a co-maintainer by the previous maintainer, and then they left leaving me all alone.

My apologies for this, after I left CloudBees it was clear I didn't had spare time to contribute jenkins anymore :'(
 

I am (painfully!) aware of gaps in my understanding of how this code works, and how the dependencies on other code is managed is one of those gaps.  e.g. its dependency on the docker-java library, done via the docker-java-api-plugin, is a painful bit of tech-debt, as demonstrated by https://github.com/jenkinsci/docker-plugin/pull/829 and I don't know how to resolve that (although I think https://github.com/jenkinsci/docker-java-api-plugin/pull/9 would help).

I don't know enough about Netty vs HttpClient to pass judgement on the pros & cons of either; I have no idea why one was selected over the other back in the past, or the risks inherent in changing this now ... but this also means that I have no strong feelings for/against either as long as it all works and I don't receive a deluge of "everything broke when I upgraded to the latest version" bug reports.

Overall, I'm happy to accept PRs as long as:
 - the changes seem to "fit" well with the plugin's objectivs,
 - the code is good before its merged (feel free to create a work-in-progress PR that isn't ready for merging),
 - it's clear (to users, to me & any future maintainers) what it does, and
 - (most importantly) the changes don't break anything.

What I can't do is dedicate much time to developing this sort of thing myself; it's not a core part of "my day job" and I've got a gazillion things I should be working on instead of this
... but if you want changes made and are prepared to make it easy for me then I'm happy to cooperate.

I guess the first thing I'd need to understand is "why?" - it works "as-is" so why change it now?  What are you really trying to achieve ... and how can this be (unit) tested?

Regards,
  Peter


On Thursday, 8 April 2021 at 08:35:11 UTC+1 Oleg Nenashev wrote:
Hi,

You are welcome. And no worries about the code, you can check out some of my prototype PRs in Jenkins :)

Best regards,
Oleg


On Thu, Apr 8, 2021 at 9:31 AM jerome moliere <[hidden email]> wrote:
Hi,
thanks Oleg for your quick answer ...
Sounds perfect even if I am not very proud from my current source code but it was done  with  a POC idea but as usual  the scope may change..
Thanks again
regards

Le mer. 7 avr. 2021 à 23:34, Oleg Nenashev <[hidden email]> a écrit :
// CC Peter Darton

On Wed, Apr 7, 2021 at 11:34 PM Oleg Nenashev <[hidden email]> wrote:
Hi Jerome, 

Thanks for you work! Indeed it might be a good addition to the plugin. My recommendation would be to start the discussion by submitting a pull request or an issue in https://github.com/jenkinsci/docker-plugin. It would be the best way to get in contact with the plugin maintainer(s) and interested contributors/users. It is not a problem if the code is not clean, you can start discussion with what you have and then agree on the next steps with the maintainers.

I will CC Peter Darton in this thread.

Best regards,
Oleg Nenashev




On Wednesday, April 7, 2021 at 8:55:20 PM UTC+2 [hidden email] wrote:
Hi all,
I worked for a french large customer on a patched version of this plugin using HttpClient 5 as the main rather than default Netty client. It seems to work well (large tests are done on customer site and I don't have many visibility). The code produced is not clean (I took the quick & dirty way).
I would like to setup a discussion if possible with PJ Darton 7 other current maintainers.

Thanks for your help
Kind regards

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/G-hS9emqG6w/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/42e6f5f8-daaf-408a-b564-50ff5a92a8a4n%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDeP89g_8rYJpbTaGh9v6Y37LacE0VOW0iRWaG7wUa_Qw%40mail.gmail.com.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/G-hS9emqG6w/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/a9efcce2-56e1-4a1a-8544-c04cd2732a68n%40googlegroups.com.


--
Nicolas De Loof

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANMVJzna%2BSw6H5L9zK5ARDJsRoK2XrDRk2w1YmcjD0iebsh%2BkA%40mail.gmail.com.