Crawler: Reporting failures & merging PRs

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Crawler: Reporting failures & merging PRs

Tim Van Holder
Hi,

two weeks ago I noticed that my global tool configuration wasn't listing the most recent SDK.
Looking on the update center, I found that the files were indeed out of date.

Investigating further showed there was indeed a failure in my crawler script, so I fixed it and submitted a PR.
This got approved not too long after.

However, it still hasn't been merged, and there's now 2 SDKs that have been released but are not listed.

Can something be done to:
a) detect crawler failures more easily, and
b) make it easier to have these PRs reviewed and merged?

For a), given the scripts are run in locked down configurations, there's no way (that I know of) to see the actual failures. Perhaps a list of failing scripts could be mailed to this list every time the crawler runs (or only after 3 consecutive failures or something, to make it less spammy when there are transient failures)?

For b), I'm not sure if there's a role that could be pinged in a comment. Or some other mechanism to get this looked at. It's frustrating to see a problem (potentially long after it started, due to a)), fix it quickly, and then wait weeks to have that fix applied.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAKMi--C8ANT40Sj0_sBZNigO3%3DoQ8CiP_MzepOo0pL87UrbU6Q%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Crawler: Reporting failures & merging PRs

timja...@gmail.com
Code owners could be added to automatically request review

jenkins-infra/core and tools have access to merge there, you won’t be able to tag them though unless you’re a member of the org

You can always ping in #jenkins-infra on freenode IRC 

I’ve merged the PR that you were referring to

On Fri, 12 Feb 2021 at 20:09, Tim Van Holder <[hidden email]> wrote:
Hi,

two weeks ago I noticed that my global tool configuration wasn't listing the most recent SDK.
Looking on the update center, I found that the files were indeed out of date.

Investigating further showed there was indeed a failure in my crawler script, so I fixed it and submitted a PR.
This got approved not too long after.

However, it still hasn't been merged, and there's now 2 SDKs that have been released but are not listed.

Can something be done to:
a) detect crawler failures more easily, and
b) make it easier to have these PRs reviewed and merged?

For a), given the scripts are run in locked down configurations, there's no way (that I know of) to see the actual failures. Perhaps a list of failing scripts could be mailed to this list every time the crawler runs (or only after 3 consecutive failures or something, to make it less spammy when there are transient failures)?

For b), I'm not sure if there's a role that could be pinged in a comment. Or some other mechanism to get this looked at. It's frustrating to see a problem (potentially long after it started, due to a)), fix it quickly, and then wait weeks to have that fix applied.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAKMi--C8ANT40Sj0_sBZNigO3%3DoQ8CiP_MzepOo0pL87UrbU6Q%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BieuaYvTRiZ2Yw8cFMbTOboi8dUXPG842prcysaoQLbOCg%40mail.gmail.com.