Dependabot option: Treat PR approval as a request to merge

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Dependabot option: Treat PR approval as a request to merge

Jesse Glick-4
Assuming I am actually permitted to do so, should I try to check the option

> Treat PR approval as a request to merge

in https://app.dependabot.com/accounts/jenkinsci/settings ? This would
make it easier to merge routine dependency updates, by just approving
without having to also type

@dependabot merge

(Unfortunately this is not yet available as a per-repo config option.)

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3QmkB1TwcYOZKfMD3qNKFBB3VQd7%3DiAXxRyEKVhGi1kA%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Dependabot option: Treat PR approval as a request to merge

Gavin Mogan
+1 from me.

On Tue, May 19, 2020 at 2:57 PM Jesse Glick <[hidden email]> wrote:
Assuming I am actually permitted to do so, should I try to check the option

> Treat PR approval as a request to merge

in https://app.dependabot.com/accounts/jenkinsci/settings ? This would
make it easier to merge routine dependency updates, by just approving
without having to also type

@dependabot merge

(Unfortunately this is not yet available as a per-repo config option.)

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3QmkB1TwcYOZKfMD3qNKFBB3VQd7%3DiAXxRyEKVhGi1kA%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusRreNdNCUcxTZsRhq2ry89kU6NTxO6dx5Fxfe%2BmNh%2Bkw%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Dependabot option: Treat PR approval as a request to merge

Mark Waite-2
In reply to this post by Jesse Glick-4
+1 from me.

On Tue, May 19, 2020 at 3:57 PM Jesse Glick <[hidden email]> wrote:
Assuming I am actually permitted to do so, should I try to check the option

> Treat PR approval as a request to merge

in https://app.dependabot.com/accounts/jenkinsci/settings ? This would
make it easier to merge routine dependency updates, by just approving
without having to also type

@dependabot merge

(Unfortunately this is not yet available as a per-repo config option.)

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3QmkB1TwcYOZKfMD3qNKFBB3VQd7%3DiAXxRyEKVhGi1kA%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtHMiCWr8E%2BC_KWd3dUAMo9_mrEFF7aPLiyDCpotR_KaSQ%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Dependabot option: Treat PR approval as a request to merge

Oleg Nenashev
If I understand correctly it will lead to a merge on the first approval, without waiting for reviews. It is fine for some repositories, but may be a problem for others. E.g. I would not like to see such automatic behavior in JCasC, Jenkinsfile Runner or in the Jenkins core once there is a Dependabot there. For the Jenkins core it would violate our current merge policy.

I am -1 for having it enabled globally.

BR, Oleg

On Wednesday, May 20, 2020 at 12:35:06 AM UTC+2, Mark Waite wrote:
+1 from me.

On Tue, May 19, 2020 at 3:57 PM Jesse Glick <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="4tskyUuMAAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jgl...@...> wrote:
Assuming I am actually permitted to do so, should I try to check the option

> Treat PR approval as a request to merge

in <a href="https://app.dependabot.com/accounts/jenkinsci/settings" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fapp.dependabot.com%2Faccounts%2Fjenkinsci%2Fsettings\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFWKjV6DPIMYjODLmXwTwz1_z6BJQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fapp.dependabot.com%2Faccounts%2Fjenkinsci%2Fsettings\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFWKjV6DPIMYjODLmXwTwz1_z6BJQ&#39;;return true;">https://app.dependabot.com/accounts/jenkinsci/settings ? This would
make it easier to merge routine dependency updates, by just approving
without having to also type

@dependabot merge

(Unfortunately this is not yet available as a per-repo config option.)

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="4tskyUuMAAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jenkin...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3QmkB1TwcYOZKfMD3qNKFBB3VQd7%3DiAXxRyEKVhGi1kA%40mail.gmail.com" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3QmkB1TwcYOZKfMD3qNKFBB3VQd7%3DiAXxRyEKVhGi1kA%40mail.gmail.com&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3QmkB1TwcYOZKfMD3qNKFBB3VQd7%3DiAXxRyEKVhGi1kA%40mail.gmail.com&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3QmkB1TwcYOZKfMD3qNKFBB3VQd7%3DiAXxRyEKVhGi1kA%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/d21c9370-219a-4a20-9b23-9e025e4bec9e%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Dependabot option: Treat PR approval as a request to merge

Gavin Mogan
I'm pretty sure you can configure automerge in the config file, but you can't enable it till its enabled org wise. Auto merge (not sure about approval merge) will be removed from non beta version of dependabot.

You can configure merging rules for protected branches. It won't bypass that. So needs 2 reviewers, CI passing, etc. Then admins can override that.

On Tue, May 19, 2020 at 9:59 PM Oleg Nenashev <[hidden email]> wrote:
If I understand correctly it will lead to a merge on the first approval, without waiting for reviews. It is fine for some repositories, but may be a problem for others. E.g. I would not like to see such automatic behavior in JCasC, Jenkinsfile Runner or in the Jenkins core once there is a Dependabot there. For the Jenkins core it would violate our current merge policy.

I am -1 for having it enabled globally.

BR, Oleg

On Wednesday, May 20, 2020 at 12:35:06 AM UTC+2, Mark Waite wrote:
+1 from me.

On Tue, May 19, 2020 at 3:57 PM Jesse Glick <[hidden email]> wrote:
Assuming I am actually permitted to do so, should I try to check the option

> Treat PR approval as a request to merge

in https://app.dependabot.com/accounts/jenkinsci/settings ? This would
make it easier to merge routine dependency updates, by just approving
without having to also type

@dependabot merge

(Unfortunately this is not yet available as a per-repo config option.)

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3QmkB1TwcYOZKfMD3qNKFBB3VQd7%3DiAXxRyEKVhGi1kA%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/d21c9370-219a-4a20-9b23-9e025e4bec9e%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DutnS%3DnA2g02fHaFePF-J4LPBsRx_pGHykqJc_Zy7GTjvQ%40mail.gmail.com.