DependecyDeclarer and Buildtrigger

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

DependecyDeclarer and Buildtrigger

Martin Ficker
Hello

Dependencies declared by any DependecyDeclarer will currently show up
int the BuildTriggers Configuration Boxes. This
means if a DependecyDeclarer does no longer declare a specific
Dependency, this will no be removed since BuildTrigger does
remember  it.
I would like to apply the following changes, if nobody objects:
- Add Class ManualDependencies extending jobProperty. This would display
the Upstream and Downstream Projects on the configuration
  Page and to the "magic" to convert between each other (If B is  a
downstream Project of A, A is and uptream Project of B). This would not
  read from DependencyGraph, but only write.
- Change Buildtrigger to be only a trigger based on the DependencyGraph.
Add Compatibility Constructors to BuildTrigger that add
  ManualDependencies. So loading "old" Hudson Data would lead to  a
correct setup.

This will lead to changes in the users view. One has to declare
Dependencies and to check the "Build other Projects After" checkbox.
Any comments?

Best regards,

Martin Ficker

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: DependecyDeclarer and Buildtrigger

Nicolas Lalevée-2

Le 7 déc. 07 à 10:19, M. Ficker a écrit :

> Hello
>
> Dependencies declared by any DependecyDeclarer will currently show up
> int the BuildTriggers Configuration Boxes.

Hum, I have tested, effectively, the build trigger configuration box  
is populated.
I think this is a bug. And the code needed to be fixed is in :
AbstractProject#doConfigSubmit()

I didn't looked closely to the code, maybe the entire loop for should  
be removed ?

Nicolas

> This
> means if a DependecyDeclarer does no longer declare a specific
> Dependency, this will no be removed since BuildTrigger does
> remember  it.
> I would like to apply the following changes, if nobody objects:
> - Add Class ManualDependencies extending jobProperty. This would  
> display
> the Upstream and Downstream Projects on the configuration
> Page and to the "magic" to convert between each other (If B is  a
> downstream Project of A, A is and uptream Project of B). This would  
> not
> read from DependencyGraph, but only write.
> - Change Buildtrigger to be only a trigger based on the  
> DependencyGraph.
> Add Compatibility Constructors to BuildTrigger that add
> ManualDependencies. So loading "old" Hudson Data would lead to  a
> correct setup.
>
> This will lead to changes in the users view. One has to declare
> Dependencies and to check the "Build other Projects After" checkbox.
> Any comments?
>
> Best regards,
>
> Martin Ficker
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: DependecyDeclarer and Buildtrigger

Martin Ficker
Hi,

just removing the Code in doConfigSubmit would breake current
Buildtrigger implementation.
I'm stil working at a patch for this, but very few time at the moment.

Best regards,
Martin
Nicolas Lalevée schrieb:

>
> Le 7 déc. 07 à 10:19, M. Ficker a écrit :
>
>> Hello
>>
>> Dependencies declared by any DependecyDeclarer will currently show up
>> int the BuildTriggers Configuration Boxes.
>
> Hum, I have tested, effectively, the build trigger configuration box
> is populated.
> I think this is a bug. And the code needed to be fixed is in :
> AbstractProject#doConfigSubmit()
>
> I didn't looked closely to the code, maybe the entire loop for should
> be removed ?
>
> Nicolas
>
>> This
>> means if a DependecyDeclarer does no longer declare a specific
>> Dependency, this will no be removed since BuildTrigger does
>> remember  it.
>> I would like to apply the following changes, if nobody objects:
>> - Add Class ManualDependencies extending jobProperty. This would display
>> the Upstream and Downstream Projects on the configuration
>> Page and to the "magic" to convert between each other (If B is  a
>> downstream Project of A, A is and uptream Project of B). This would not
>> read from DependencyGraph, but only write.
>> - Change Buildtrigger to be only a trigger based on the DependencyGraph.
>> Add Compatibility Constructors to BuildTrigger that add
>> ManualDependencies. So loading "old" Hudson Data would lead to  a
>> correct setup.
>>
>> This will lead to changes in the users view. One has to declare
>> Dependencies and to check the "Build other Projects After" checkbox.
>> Any comments?
>>
>> Best regards,
>>
>> Martin Ficker
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: DependecyDeclarer and Buildtrigger

Kohsuke Kawaguchi
Administrator
Thank you for working on a patch.

If I understand your proposal correctly, it sounds like BuildTrigger
will no longer remember what dependencies the user declared but it'd
rather just schedule builds that are declared by any
DependencyDeclarer?

Isn't it easier to fix this by only listing those projects that are
explicitly configured in the configuration to avoid this problem?

2007/12/12, M. Ficker <[hidden email]>:

> Hi,
>
> just removing the Code in doConfigSubmit would breake current
> Buildtrigger implementation.
> I'm stil working at a patch for this, but very few time at the moment.
>
> Best regards,
> Martin
> Nicolas Lalevée schrieb:
> >
> > Le 7 déc. 07 à 10:19, M. Ficker a écrit :
> >
> >> Hello
> >>
> >> Dependencies declared by any DependecyDeclarer will currently show up
> >> int the BuildTriggers Configuration Boxes.
> >
> > Hum, I have tested, effectively, the build trigger configuration box
> > is populated.
> > I think this is a bug. And the code needed to be fixed is in :
> > AbstractProject#doConfigSubmit()
> >
> > I didn't looked closely to the code, maybe the entire loop for should
> > be removed ?
> >
> > Nicolas
> >
> >> This
> >> means if a DependecyDeclarer does no longer declare a specific
> >> Dependency, this will no be removed since BuildTrigger does
> >> remember  it.
> >> I would like to apply the following changes, if nobody objects:
> >> - Add Class ManualDependencies extending jobProperty. This would display
> >> the Upstream and Downstream Projects on the configuration
> >> Page and to the "magic" to convert between each other (If B is  a
> >> downstream Project of A, A is and uptream Project of B). This would not
> >> read from DependencyGraph, but only write.
> >> - Change Buildtrigger to be only a trigger based on the DependencyGraph.
> >> Add Compatibility Constructors to BuildTrigger that add
> >> ManualDependencies. So loading "old" Hudson Data would lead to  a
> >> correct setup.
> >>
> >> This will lead to changes in the users view. One has to declare
> >> Dependencies and to check the "Build other Projects After" checkbox.
> >> Any comments?
> >>
> >> Best regards,
> >>
> >> Martin Ficker
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
Kohsuke Kawaguchi

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]