Duplicate mail recipients

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Duplicate mail recipients

Valeri Felberg
I noticed that if a person is on the list of mail recipients and at the same time an "individual who broke the build" her email address shows up twice in the "to" email header. I haven't checked yet but I suppose she would then receive the email twice. If so, I think it should be prevented. After a quick code review I think a simple solution would be to replace the recipient List in hudson.tasks.MailSender line 241 with a Set or SortedSet. WDYT?
Reply | Threaded
Open this post in threaded view
|

Re: Duplicate mail recipients

Kohsuke Kawaguchi
Administrator
Valeri Felberg wrote:
> I noticed that if a person is on the list of mail recipients and at the same
> time an "individual who broke the build" her email address shows up twice in
> the "to" email header. I haven't checked yet but I suppose she would then
> receive the email twice.

Yes.

 > If so, I think it should be prevented.

Yes.

> After a
> quick code review I think a simple solution would be to replace the
> recipient List in hudson.tasks.MailSender line 241 with a Set or SortedSet.
> WDYT?

Yes. I went ahead and committed a change, although I now realized that I
should probably have asked you to do so. My apologies.

This change will be in 1.129.

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment