Fwd: Changes not in summary

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Fwd: Changes not in summary

daniel.galan
Fwd: Changes not in summary

Hi Kohsuke,

have you some ideas to the following Post I send a while ago?

==============================8<==========================


> The output should have gone to the console of the build, not to the
> system log screen. Sorry for confusing property name.
No problem, I filtered the log and found following parts useful (I cloaked some parts (like path and package infos)):

<start>

[workspace] $ cvs -q -z9 update -PdC
P project/src/de/packages/MyClass.java
$ computing changelog
Running log at /userhome/.hudson/jobs/project/workspace
Using cvs passfile: /userhome/.cvspass
Executing 'cvs' with arguments: '-d:pserver:user@host:/path/to/cvs/repository'
'log'
'-d'
'>=2006-11-21'
'project/src/de/packages/MyClass.java'

[..snip..]

keyword substitution: kv
total revisions: 13;    selected revisions: 2
description:
----------------------------
revision 1.11
Recorded a change: 2006-11-22 17:31:29,dgalan,1.11(branch=null),CVS Message goes here
date: 2006-11-22 17:31:29 +0100;  author: dgalan;  state: Exp;  lines: +3 -4;  commitid: 3bb945647b614567; CVS Message goes here

----------------------------
revision 1.9.4.2
date: 2006-11-22 17:32:33 +0100;  author: dgalan;  state: Exp;  lines: +3 -4;  commitid: 3eb345647ba14567; CVS Message goes here Recorded a change: 2006-11-22 17:32:33,dgalan,1.9.4.2(branch=mybranch),CVS Message goes here =============================================================================

retCode=0
Filtering entries
Filtering out [dgalan,Wed Nov 22 18:31:29 CET 2006,[hudson.org.apache.tools.ant.taskdefs.cvslib.RCSFile@4065c4],CVS Message goes here] because it's too late compare to Wed Nov 22 17:31:27 CET 2006 Filtering out [dgalan,Wed Nov 22 18:32:33 CET 2006,[hudson.org.apache.tools.ant.taskdefs.cvslib.RCSFile@1d92803],CVS Message goes here] because it's too late compare to Wed Nov 22 17:31:27 CET 2006

<end>

As we can see, hudson is filtering the changes, because the time is somehow not in sync. A date on the server gives me "Wed Nov 22 17:58:21 CET 2006" So the problems come from "18:31:29" and "18:32:33". Where does they come from?

Is it possible, that the CVS works internally only in GMT?

Greetings
Daniel

(ps.: And happy Vacation to you Kohsuke :)

==============================>8==========================


Reply | Threaded
Open this post in threaded view
|

Re: Fwd: Changes not in summary

Jesse Glick
[hidden email] wrote:
> As we can see, hudson is filtering the changes

Changelog creation for CVS is known to be buggy. I am internally testing
a patch which I think will help, but more widespread testing is desired.

https://hudson.dev.java.net/issues/show_bug.cgi?id=192

-J.

--
[hidden email]  x22801  netbeans.org  ant.apache.org
       http://google.com/search?q=e%5E%28pi*i%29%2B1

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Fwd: Changes not in summary

Kohsuke Kawaguchi-2
Jesse Glick wrote:
> [hidden email] wrote:
>> As we can see, hudson is filtering the changes
>
> Changelog creation for CVS is known to be buggy. I am internally testing
> a patch which I think will help, but more widespread testing is desired.
>
> https://hudson.dev.java.net/issues/show_bug.cgi?id=192

I just deployed this on my production system. The nature of the problem
makes it difficult to confirm improvements, but so far I don't see any
regressions either, which I think is a good sign.

I'm thinking about posting 1.67 tomorrow evening, if that sounds OK with
you.

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

AW: Re: Fwd: Changes not in summary

daniel.galan
Hi,

> >> As we can see, hudson is filtering the changes
> > https://hudson.dev.java.net/issues/show_bug.cgi?id=192
> I just deployed this on my production system. The nature of
> the problem makes it difficult to confirm improvements, but
> so far I don't see any regressions either, which I think is
> a good sign.

> I'm thinking about posting 1.67 tomorrow evening, if that
> sounds OK with you.

Thanks for posting a new version. I deployed it to my tomcat and have made some test:

Build from 19.12.2006 14:01:17:


revision 1.2
Recorded a change: 2006-12-19 13:55:56,dgalan,1.2(branch=null),test + cvs test
date: 2006-12-19 13:55:56 +0100;  author: dgalan;  state: Exp;  lines: +1 -1;  commitid: 179d4587e15c4567;
test + cvs test
----------------------------
revision 1.1
date: 2006-12-18 18:13:34 +0100;  author: dgalan;  state: Exp;  commitid: 7ca04586cc3e4567;
branches:  1.1.2;
My CVS Comment
Recorded a change: 2006-12-18 18:13:34,dgalan,1.1(branch=null),branches:  1.1.2;
My CVS Comment

[..]

Filtering out [dgalan,Tue Dec 19 14:55:56 CET 2006,[hudson.org.apache.tools.ant.taskdefs.cvslib.RCSFile@161b52],test + cvs test] because it's too late compare to Tue Dec 19 14:01:17 CET 2006

Filtering out [dgalan,Mon Dec 18 19:13:34 CET 2006,[hudson.org.apache.tools.ant.taskdefs.cvslib.RCSFile@d22707],branches:  1.1.2;
My CVS Comment] because it's too early compare to Tue Dec 19 13:31:17 CET 2006

......................

The filtering doesn't work yet. :( And I'm totaly confused about the filtering logs.


Best regards
Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: AW: Re: Fwd: Changes not in summary

Kohsuke Kawaguchi-2

Thanks. This is very useful information.

[hidden email] wrote:

> Hi,
>
>> >> As we can see, hudson is filtering the changes
>> > https://hudson.dev.java.net/issues/show_bug.cgi?id=192
>> I just deployed this on my production system. The nature of
>> the problem makes it difficult to confirm improvements, but
>> so far I don't see any regressions either, which I think is
>> a good sign.
>
>> I'm thinking about posting 1.67 tomorrow evening, if that
>> sounds OK with you.
>
> Thanks for posting a new version. I deployed it to my tomcat and have made some test:
>
> Build from 19.12.2006 14:01:17:
>
>
> revision 1.2
> Recorded a change: 2006-12-19 13:55:56,dgalan,1.2(branch=null),test + cvs test
> date: 2006-12-19 13:55:56 +0100;  author: dgalan;  state: Exp;  lines: +1 -1;  commitid: 179d4587e15c4567;
> test + cvs test
> ----------------------------
> revision 1.1
> date: 2006-12-18 18:13:34 +0100;  author: dgalan;  state: Exp;  commitid: 7ca04586cc3e4567;
> branches:  1.1.2;
> My CVS Comment
> Recorded a change: 2006-12-18 18:13:34,dgalan,1.1(branch=null),branches:  1.1.2;
> My CVS Comment
>
> [..]
>
> Filtering out [dgalan,Tue Dec 19 14:55:56 CET 2006,[hudson.org.apache.tools.ant.taskdefs.cvslib.RCSFile@161b52],test + cvs test] because it's too late compare to Tue Dec 19 14:01:17 CET 2006
>
> Filtering out [dgalan,Mon Dec 18 19:13:34 CET 2006,[hudson.org.apache.tools.ant.taskdefs.cvslib.RCSFile@d22707],branches:  1.1.2;
> My CVS Comment] because it's too early compare to Tue Dec 19 13:31:17 CET 2006
>
> .....................
>
> The filtering doesn't work yet. :( And I'm totaly confused about the filtering logs.
I'm guessing that you committed rev. 1.2 of this file, then have Hudson
build it. Is that right?

CVS says your commit happened 13:55:56 +0100 on 12/19, then Hudson (?)
says your build started on 14:01:17 on 12/19 (is this CET?).

Hudson apparently filtered this entry out because it thinks that the
commit happened in "14:55:56 CET" --- so it appears that it's
double-counting the timezone by adding extra +1 hr.

I also noticed that your "cvs log" output is bit different from mine,
which produce something like:

> date: 2006/11/06 16:42:24;  author: kohsuke;  state: Exp;  lines: +1 -1

Notice that there's no commitid, and there's no time zone specifier. Can
you run "cvs --version" and send us the output?

Also are both your CVS server and your Hudson run in CET?


--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Changes not in summary

daniel.galan
Hi,

> Thanks. This is very useful information.
> >> > https://hudson.dev.java.net/issues/show_bug.cgi?id=192
> > Thanks for posting a new version. I deployed it to my
> > tomcat and have made some test:

> > revision 1.2
> > Recorded a change: 2006-12-19
> 13:55:56,dgalan,1.2(branch=null),test +
> > cvs test
> > date: 2006-12-19 13:55:56 +0100;  author: dgalan;  state:
> Exp;  lines: +1 -1;  commitid: 179d4587e15c4567;
> > test + cvs test
> > ----------------------------
> > revision 1.1
> > date: 2006-12-18 18:13:34 +0100;  author: dgalan;  state:
> Exp;  commitid: 7ca04586cc3e4567;
> > branches:  1.1.2;
> > My CVS Comment
> > Recorded a change: 2006-12-18
> 18:13:34,dgalan,1.1(branch=null),branches:  1.1.2;
> > My CVS Comment
> >
> > [..]
> >
> > Filtering out [dgalan,Tue Dec 19 14:55:56 CET
> >
> 2006,[hudson.org.apache.tools.ant.taskdefs.cvslib.RCSFile@161b
> 52],test
> > + cvs test] because it's too late compare to Tue Dec 19
> 14:01:17 CET
> > 2006
> >
> > Filtering out [dgalan,Mon Dec 18 19:13:34 CET
> >
> 2006,[hudson.org.apache.tools.ant.taskdefs.cvslib.RCSFile@d22707],bran
> > ches:  1.1.2; My CVS Comment] because it's too early compare to Tue
> > Dec 19 13:31:17 CET 2006
> >
> > .....................
> >

> I'm guessing that you committed rev. 1.2 of this file, then
> have Hudson build it. Is that right?
I think that's right;

> CVS says your commit happened 13:55:56 +0100 on 12/19, then
> Hudson (?)
> says your build started on 14:01:17 on 12/19 (is this CET?).
>
> Hudson apparently filtered this entry out because it thinks that the
> commit happened in "14:55:56 CET" --- so it appears that it's
> double-counting the timezone by adding extra +1 hr.
Is this a hudson problem, or is the CVS simply only thinking in GMT?

> I also noticed that your "cvs log" output is bit different from mine,
> which produce something like:
>
> > date: 2006/11/06 16:42:24;  author: kohsuke;  state: Exp;  
> lines: +1
> > -1
>
> Notice that there's no commitid, and there's no time zone
> specifier. Can
> you run "cvs --version" and send us the output?
buildmachine:~ # cvs --version

Concurrent Versions System (CVS) 1.12.12 (client/server)

Copyright (C) 2005 Free Software Foundation, Inc.

[.. an so on (Copyrightnotice) ..]


> Also are both your CVS server and your Hudson run in CET?
Both run on the same machine, so I think both run in CET.

A date command says the following:
buildmachine:~ # date
Wed Dec 20 09:10:20 CET 2006

In  the System properties (in hudson), we see the java timezone:
user.timezone -> Europe/Berlin

Maybe the configuration is broken somewhere, but I don't know where.

Thanks for your efforts, greetings
Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Changes not in summary

Kohsuke Kawaguchi-2

I put a fix to this in the upcoming 1.68. Hopefully that fixes this problem.

[hidden email] wrote:

> Hi,
>
>> Thanks. This is very useful information.
>> >> > https://hudson.dev.java.net/issues/show_bug.cgi?id=192
>> > Thanks for posting a new version. I deployed it to my
>> > tomcat and have made some test:
>
>> > revision 1.2
>> > Recorded a change: 2006-12-19
>> 13:55:56,dgalan,1.2(branch=null),test +
>> > cvs test
>> > date: 2006-12-19 13:55:56 +0100;  author: dgalan;  state:
>> Exp;  lines: +1 -1;  commitid: 179d4587e15c4567;
>> > test + cvs test
>> > ----------------------------
>> > revision 1.1
>> > date: 2006-12-18 18:13:34 +0100;  author: dgalan;  state:
>> Exp;  commitid: 7ca04586cc3e4567;
>> > branches:  1.1.2;
>> > My CVS Comment
>> > Recorded a change: 2006-12-18
>> 18:13:34,dgalan,1.1(branch=null),branches:  1.1.2;
>> > My CVS Comment
>> >
>> > [..]
>> >
>> > Filtering out [dgalan,Tue Dec 19 14:55:56 CET
>> >
>> 2006,[hudson.org.apache.tools.ant.taskdefs.cvslib.RCSFile@161b
>> 52],test
>> > + cvs test] because it's too late compare to Tue Dec 19
>> 14:01:17 CET
>> > 2006
>> >
>> > Filtering out [dgalan,Mon Dec 18 19:13:34 CET
>> >
>> 2006,[hudson.org.apache.tools.ant.taskdefs.cvslib.RCSFile@d22707],bran
>> > ches:  1.1.2; My CVS Comment] because it's too early compare to Tue
>> > Dec 19 13:31:17 CET 2006
>> >
>> > .....................
>> >
>
>> I'm guessing that you committed rev. 1.2 of this file, then
>> have Hudson build it. Is that right?
> I think that's right;
>
>> CVS says your commit happened 13:55:56 +0100 on 12/19, then
>> Hudson (?)
>> says your build started on 14:01:17 on 12/19 (is this CET?).
>>
>> Hudson apparently filtered this entry out because it thinks that the
>> commit happened in "14:55:56 CET" --- so it appears that it's
>> double-counting the timezone by adding extra +1 hr.
> Is this a hudson problem, or is the CVS simply only thinking in GMT?
>
>> I also noticed that your "cvs log" output is bit different from mine,
>> which produce something like:
>>
>> > date: 2006/11/06 16:42:24;  author: kohsuke;  state: Exp;  
>> lines: +1
>> > -1
>>
>> Notice that there's no commitid, and there's no time zone
>> specifier. Can
>> you run "cvs --version" and send us the output?
> buildmachine:~ # cvs --version
>
> Concurrent Versions System (CVS) 1.12.12 (client/server)
>
> Copyright (C) 2005 Free Software Foundation, Inc.
>
> [.. an so on (Copyrightnotice) ..]
>
>
>> Also are both your CVS server and your Hudson run in CET?
> Both run on the same machine, so I think both run in CET.
>
> A date command says the following:
> buildmachine:~ # date
> Wed Dec 20 09:10:20 CET 2006
>
> In  the System properties (in hudson), we see the java timezone:
> user.timezone -> Europe/Berlin
>
> Maybe the configuration is broken somewhere, but I don't know where.
>
> Thanks for your efforts, greetings
> Daniel
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

AW: Re: Changes not in summary

daniel.galan
Hi,

> I put a fix to this in the upcoming 1.68. Hopefully that
> fixes this problem.

It seems to work .. great work! :)
The changes appear related to the correct build. I observed it for a day and everything seems to work ok. But I will keep an eye on it :)

Just to have mentioned, should the changes of all Jobs be in the People-View on the Dashboard? Currently it's empty, even if there are changes in the Jobs by different people. Maybe I dond't understand what the People should be for.

Greetings
Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: AW: Re: Changes not in summary

Kohsuke Kawaguchi-2
[hidden email] wrote:
> Hi,
>
>> I put a fix to this in the upcoming 1.68. Hopefully that
>> fixes this problem.
>
> It seems to work .. great work! :)
> The changes appear related to the correct build. I observed it for a day and everything seems to work ok. But I will keep an eye on it :)

Cool.

> Just to have mentioned, should the changes of all Jobs be in the
> People-View on the Dashboard? Currently it's empty, even if there are
> changes in the Jobs by different people. Maybe I dond't understand what
> the People should be for.

Yes. As soon as jobs start recording changes, you should see the people
page populated. From what I hear from people, it sounds like there's
some bug that prevents it from displaying anything in some environments,
but I just have no idea why.

>
> Greetings
> Daniel
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment