Fwd: [GitHub] Ant Path matching fails on Windows [hudson/gerrit-trigger-plugin GH-1]

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Fwd: [GitHub] Ant Path matching fails on Windows [hudson/gerrit-trigger-plugin GH-1]

Erik Ramfelt
Should the GIT tracker be disabled so we dont have several issue
trackers for Hudson core and plugins?


//Erik

---------- Forwarded message ----------
From: GitHub <[hidden email]>
Date: Thu, Dec 23, 2010 at 01:27
Subject: [GitHub] Ant Path matching fails on Windows
[hudson/gerrit-trigger-plugin GH-1]
To: [hidden email]


joshbeitelspacher reported an issue:

On Windows I get the following test failures:

<pre>
-------------------------------------------------------------------------------
Test set: com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProjectInterestingTest
-------------------------------------------------------------------------------
Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.031
sec <<< FAILURE!
testInteresting[2](com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProjectInterestingTest)
 Time elapsed: 0 sec  <<< FAILURE!
java.lang.AssertionError: expected:<true> but was:<false>
       at org.junit.Assert.fail(Assert.java:91)
       at org.junit.Assert.failNotEquals(Assert.java:645)
       at org.junit.Assert.assertEquals(Assert.java:126)
       at org.junit.Assert.assertEquals(Assert.java:145)
       at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProjectInterestingTest.testInteresting(GerritProjectInterestingTest.java:57)
       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
       at java.lang.reflect.Method.invoke(Method.java:597)
       at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
       at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
       at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
       at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
       at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
       at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
       at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
       at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
       at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
       at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
       at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
       at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
       at org.junit.runners.Suite.runChild(Suite.java:128)
       at org.junit.runners.Suite.runChild(Suite.java:24)
       at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
       at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
       at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
       at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
       at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
       at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
       at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
       at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
       at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
       at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
       at java.lang.reflect.Method.invoke(Method.java:597)
       at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
       at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)

testInteresting[3](com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProjectInterestingTest)
 Time elapsed: 0 sec  <<< FAILURE!
java.lang.AssertionError: expected:<true> but was:<false>
       at org.junit.Assert.fail(Assert.java:91)
       at org.junit.Assert.failNotEquals(Assert.java:645)
       at org.junit.Assert.assertEquals(Assert.java:126)
       at org.junit.Assert.assertEquals(Assert.java:145)
       at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProjectInterestingTest.testInteresting(GerritProjectInterestingTest.java:57)
       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
       at java.lang.reflect.Method.invoke(Method.java:597)
       at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
       at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
       at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
       at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
       at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
       at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
       at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
       at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
       at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
       at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
       at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
       at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
       at org.junit.runners.Suite.runChild(Suite.java:128)
       at org.junit.runners.Suite.runChild(Suite.java:24)
       at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
       at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
       at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
       at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
       at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
       at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
       at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
       at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
       at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
       at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
       at java.lang.reflect.Method.invoke(Method.java:597)
       at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
       at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
</pre>

When Ant pattern matching is used the Ant SelectorUtil class is used
to determine if there is a match, and the behavior of SelectorUtil
depends on the value of java.io.File.separator.

Replacing '/' with java.io.File.separatorChar before calling
SelectorUtil fixes the issue, but I'm not sure its the best solution.

View Issue: https://github.com/hudson/gerrit-trigger-plugin/issues#issue/1
Reply | Threaded
Open this post in threaded view
|

RE: Fwd: [GitHub] Ant Path matching fails on Windows

martin.loiselle@medrium.com
This post has NOT been accepted by the mailing list yet.
On vacation:
I will be out of the office starting the Dec. 23rd and
will return on January 10.

for any problem related to your email or computer, please send an email to [hidden email].

For any emergency, call at 1-418-264-6911
Reply | Threaded
Open this post in threaded view
|

Re: Fwd: [GitHub] Ant Path matching fails on Windows [hudson/gerrit-trigger-plugin GH-1]

Josh Beitelspacher
In reply to this post by Erik Ramfelt
I'm happy to migrate the issue to JIRA if desired, but I'll wait until
there is a resolution on this thread.

I probably should have written the issue in JIRA in the first place.
The plugin maintainer is doing a good job keeping up with JIRA issues,
and I don't want to make him change his workflow.

Thanks,
Josh

On Dec 23, 3:37 am, Erik Ramfelt <[hidden email]> wrote:

> Should the GIT tracker be disabled so we dont have several issue
> trackers for Hudson core and plugins?
>
> //Erik
>
> ---------- Forwarded message ----------
> From: GitHub <[hidden email]>
> Date: Thu, Dec 23, 2010 at 01:27
> Subject: [GitHub] Ant Path matching fails on Windows
>
> [hudson/gerrit-trigger-plugin GH-1]
> To: [hidden email]
>
> joshbeitelspacher reported an issue:
>
> On Windows I get the following test failures:
>
> <pre>
> -------------------------------------------------------------------------------
> Test set: com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProjectInterestingTest
> -------------------------------------------------------------------------------
> Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.031
> sec <<< FAILURE!
> testInteresting[2](com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProjectInterestingTest)
>  Time elapsed: 0 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<true> but was:<false>
>        at org.junit.Assert.fail(Assert.java:91)
>        at org.junit.Assert.failNotEquals(Assert.java:645)
>        at org.junit.Assert.assertEquals(Assert.java:126)
>        at org.junit.Assert.assertEquals(Assert.java:145)
>        at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProjectInterestingTest.testInteresting(GerritProjectInterestingTest.java:57)
>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>        at java.lang.reflect.Method.invoke(Method.java:597)
>        at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
>        at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
>        at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
>        at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
>        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
>        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
>        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
>        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
>        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
>        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
>        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
>        at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
>        at org.junit.runners.Suite.runChild(Suite.java:128)
>        at org.junit.runners.Suite.runChild(Suite.java:24)
>        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
>        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
>        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
>        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
>        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
>        at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
>        at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
>        at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
>        at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
>        at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>        at java.lang.reflect.Method.invoke(Method.java:597)
>        at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
>        at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
>
> testInteresting[3](com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProjectInterestingTest)
>  Time elapsed: 0 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<true> but was:<false>
>        at org.junit.Assert.fail(Assert.java:91)
>        at org.junit.Assert.failNotEquals(Assert.java:645)
>        at org.junit.Assert.assertEquals(Assert.java:126)
>        at org.junit.Assert.assertEquals(Assert.java:145)
>        at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProjectInterestingTest.testInteresting(GerritProjectInterestingTest.java:57)
>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>        at java.lang.reflect.Method.invoke(Method.java:597)
>        at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
>        at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
>        at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
>        at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
>        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
>        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
>        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
>        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
>        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
>        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
>        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
>        at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
>        at org.junit.runners.Suite.runChild(Suite.java:128)
>        at org.junit.runners.Suite.runChild(Suite.java:24)
>        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
>        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
>        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
>        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
>        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
>        at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
>        at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
>        at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
>        at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
>        at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>        at java.lang.reflect.Method.invoke(Method.java:597)
>        at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
>        at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
> </pre>
>
> When Ant pattern matching is used the Ant SelectorUtil class is used
> to determine if there is a match, and the behavior of SelectorUtil
> depends on the value of java.io.File.separator.
>
> Replacing '/' with java.io.File.separatorChar before calling
> SelectorUtil fixes the issue, but I'm not sure its the best solution.
>
> View Issue:https://github.com/hudson/gerrit-trigger-plugin/issues#issue/1
Reply | Threaded
Open this post in threaded view
|

RE: Re: Fwd: [GitHub] Ant Path matching fails on Windows

martin.loiselle@medrium.com
This post has NOT been accepted by the mailing list yet.
On vacation:
I will be out of the office starting the Dec. 23rd and
will return on January 10.

for any problem related to your email or computer, please send an email to [hidden email].

For any emergency, call at 1-418-264-6911
Reply | Threaded
Open this post in threaded view
|

RE: Fwd: [GitHub] Ant Path matching fails on Windows [hudson/gerrit-trigger-plugin GH-1]

Sandell, Robert
In reply to this post by Josh Beitelspacher
How nice of you to think of me :)

I prefer if it is just in JIRA, it is very hard to track fixes if they come from multiple report-sources.
I honestly thought that I had reported this issue in JIRA already, because I found it a very long time ago, but I apparently missed to do so.

If it is possible to turn off the issue reporting in GitHub or just add some kind of note on the issue reporting page; that would be great.

BR
Robert Sandell
@Team Hudson - Sony Ericsson

> -----Original Message-----
> From: [hidden email] [mailto:[hidden email]]
> On Behalf Of Josh Beitelspacher
> Sent: den 23 december 2010 20:42
> To: Hudson Developers
> Subject: Re: Fwd: [GitHub] Ant Path matching fails on Windows
> [hudson/gerrit-trigger-plugin GH-1]
>
> I'm happy to migrate the issue to JIRA if desired, but I'll wait until
> there is a resolution on this thread.
>
> I probably should have written the issue in JIRA in the first place.
> The plugin maintainer is doing a good job keeping up with JIRA issues,
> and I don't want to make him change his workflow.
>
> Thanks,
> Josh
>
> On Dec 23, 3:37 am, Erik Ramfelt <[hidden email]> wrote:
> > Should the GIT tracker be disabled so we dont have several issue
> > trackers for Hudson core and plugins?
> >
> > //Erik
> >
> > ---------- Forwarded message ----------
> > From: GitHub <[hidden email]>
> > Date: Thu, Dec 23, 2010 at 01:27
> > Subject: [GitHub] Ant Path matching fails on Windows
> >
> > [hudson/gerrit-trigger-plugin GH-1]
> > To: [hidden email]
> >
> > joshbeitelspacher reported an issue:
> >
> > On Windows I get the following test failures:
> >
> > <pre>
> > ---------------------------------------------------------------------
> ----------
> > Test set:
> com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.Gerri
> tProjectInterestingTest
> > ---------------------------------------------------------------------
> ----------
> > Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.031
> > sec <<< FAILURE!
> >
> testInteresting[2](com.sonyericsson.hudson.plugins.gerrit.trigger.hudso
> ntrigger.data.GerritProjectInterestingTest)
> >  Time elapsed: 0 sec  <<< FAILURE!
> > java.lang.AssertionError: expected:<true> but was:<false>
> >        at org.junit.Assert.fail(Assert.java:91)
> >        at org.junit.Assert.failNotEquals(Assert.java:645)
> >        at org.junit.Assert.assertEquals(Assert.java:126)
> >        at org.junit.Assert.assertEquals(Assert.java:145)
> >        at
> com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.Gerri
> tProjectInterestingTest.testInteresting(GerritProjectInterestingTest.ja
> va:57)
> >        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> >        at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.ja
> va:39)
> >        at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso
> rImpl.java:25)
> >        at java.lang.reflect.Method.invoke(Method.java:597)
> >        at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMe
> thod.java:44)
> >        at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCalla
> ble.java:15)
> >        at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMeth
> od.java:41)
> >        at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMetho
> d.java:20)
> >        at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunne
> r.java:76)
> >        at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunne
> r.java:50)
> >        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
> >        at
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
> >        at
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
> >        at
> org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
> >        at
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
> >        at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
> >        at org.junit.runners.Suite.runChild(Suite.java:128)
> >        at org.junit.runners.Suite.runChild(Suite.java:24)
> >        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
> >        at
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
> >        at
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
> >        at
> org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
> >        at
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
> >        at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
> >        at
> org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.ja
> va:62)
> >        at
> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestS
> et(AbstractDirectoryTestSuite.java:140)
> >        at
> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(Abst
> ractDirectoryTestSuite.java:127)
> >        at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
> >        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> >        at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.ja
> va:39)
> >        at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso
> rImpl.java:25)
> >        at java.lang.reflect.Method.invoke(Method.java:597)
> >        at
> org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(Sure
> fireBooter.java:345)
> >        at
> org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.jav
> a:1009)
> >
> >
> testInteresting[3](com.sonyericsson.hudson.plugins.gerrit.trigger.hudso
> ntrigger.data.GerritProjectInterestingTest)
> >  Time elapsed: 0 sec  <<< FAILURE!
> > java.lang.AssertionError: expected:<true> but was:<false>
> >        at org.junit.Assert.fail(Assert.java:91)
> >        at org.junit.Assert.failNotEquals(Assert.java:645)
> >        at org.junit.Assert.assertEquals(Assert.java:126)
> >        at org.junit.Assert.assertEquals(Assert.java:145)
> >        at
> com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.Gerri
> tProjectInterestingTest.testInteresting(GerritProjectInterestingTest.ja
> va:57)
> >        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> >        at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.ja
> va:39)
> >        at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso
> rImpl.java:25)
> >        at java.lang.reflect.Method.invoke(Method.java:597)
> >        at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMe
> thod.java:44)
> >        at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCalla
> ble.java:15)
> >        at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMeth
> od.java:41)
> >        at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMetho
> d.java:20)
> >        at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunne
> r.java:76)
> >        at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunne
> r.java:50)
> >        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
> >        at
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
> >        at
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
> >        at
> org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
> >        at
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
> >        at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
> >        at org.junit.runners.Suite.runChild(Suite.java:128)
> >        at org.junit.runners.Suite.runChild(Suite.java:24)
> >        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
> >        at
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
> >        at
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
> >        at
> org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
> >        at
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
> >        at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
> >        at
> org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.ja
> va:62)
> >        at
> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestS
> et(AbstractDirectoryTestSuite.java:140)
> >        at
> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(Abst
> ractDirectoryTestSuite.java:127)
> >        at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
> >        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> >        at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.ja
> va:39)
> >        at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso
> rImpl.java:25)
> >        at java.lang.reflect.Method.invoke(Method.java:597)
> >        at
> org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(Sure
> fireBooter.java:345)
> >        at
> org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.jav
> a:1009)
> > </pre>
> >
> > When Ant pattern matching is used the Ant SelectorUtil class is used
> > to determine if there is a match, and the behavior of SelectorUtil
> > depends on the value of java.io.File.separator.
> >
> > Replacing '/' with java.io.File.separatorChar before calling
> > SelectorUtil fixes the issue, but I'm not sure its the best solution.
> >
> > View Issue:https://github.com/hudson/gerrit-trigger-
> plugin/issues#issue/1
Reply | Threaded
Open this post in threaded view
|

RE: RE: Fwd: [GitHub] Ant Path matching fails on Windows

martin.loiselle@medrium.com
This post has NOT been accepted by the mailing list yet.
On vacation:
I will be out of the office starting the Dec. 23rd and
will return on January 10.

for any problem related to your email or computer, please send an email to [hidden email].

For any emergency, call at 1-418-264-6911
Reply | Threaded
Open this post in threaded view
|

Re: Fwd: [GitHub] Ant Path matching fails on Windows [hudson/gerrit-trigger-plugin GH-1]

Josh Beitelspacher
In reply to this post by Sandell, Robert
Because the 'fix' here was so simple I just committed it and closed
the issue on github.

In addition to disabling the issue reporting in github it would be
beneficial to define a preferred method for submitting code changes.
Github provides a lot of options, and plugin maintainers might have
preferences:

1.) Ask for commit access and make changes directly on master.
2.) Ask for commit access and make changes on topic branches.
3.) Fork on github and submit pull requests.
4.) Attach patches to JIRA/github issues.

Gerrit would be really helpful here.

On Tue, Dec 28, 2010 at 9:36 AM, Sandell, Robert
<[hidden email]> wrote:

> How nice of you to think of me :)
>
> I prefer if it is just in JIRA, it is very hard to track fixes if they come from multiple report-sources.
> I honestly thought that I had reported this issue in JIRA already, because I found it a very long time ago, but I apparently missed to do so.
>
> If it is possible to turn off the issue reporting in GitHub or just add some kind of note on the issue reporting page; that would be great.
>
> BR
> Robert Sandell
> @Team Hudson - Sony Ericsson
Reply | Threaded
Open this post in threaded view
|

RE: Re: Fwd: [GitHub] Ant Path matching fails on Windows

martin.loiselle@medrium.com
This post has NOT been accepted by the mailing list yet.
On vacation:
I will be out of the office starting the Dec. 23rd and
will return on January 10.

for any problem related to your email or computer, please send an email to [hidden email].

For any emergency, call at 1-418-264-6911