[GSOC 2020 Custom Jenkins Build Distribution] Should the update centre download test be mocked?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GSOC 2020 Custom Jenkins Build Distribution] Should the update centre download test be mocked?

Martin d'Anjou
Hi,

Should we mock the update centre download when testing the code of the custom build distribution application? Here is the PR:

Thanks,
Martin

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1aff61ee-7d55-40b9-a288-bcdd5bd6c887n%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: [GSOC 2020 Custom Jenkins Build Distribution] Should the update centre download test be mocked?

Oleg Nenashev
Hi Martin,

Yes, it would be good to mock such tests if possible, or to at least ensure that the update center JSON is downloaded once during the build.

Best regrads,
Oleg


On Monday, August 3, 2020 at 5:05:09 PM UTC+2, martinda wrote:
Hi,

Should we mock the update centre download when testing the code of the custom build distribution application? Here is the PR:
<a href="https://github.com/jenkinsci/custom-distribution-service/pull/105/files" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fcustom-distribution-service%2Fpull%2F105%2Ffiles\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHDXT4yfxztwj5znAaAhOcKtv43ow&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fcustom-distribution-service%2Fpull%2F105%2Ffiles\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHDXT4yfxztwj5znAaAhOcKtv43ow&#39;;return true;">https://github.com/jenkinsci/custom-distribution-service/pull/105/files

Thanks,
Martin

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1d01138d-7f3e-45ab-aab0-ada3e2db5efeo%40googlegroups.com.