HUDSON-4296: First-time committer to Hudson core

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

HUDSON-4296: First-time committer to Hudson core

Steven Brown
Hello,

I would like to fix HUDSON-4296. This issue asks for the ability to upload file build parameters through the CLI. This has already been implemented (r23543), but has a bug. Here is an example of the build console output:

Started by command line
Copying file to null
FATAL: null
java.lang.NullPointerException
        at hudson.FilePath.isAbsolute(FilePath.java:221)
        at hudson.FilePath.<init>(FilePath.java:209)
        at hudson.FilePath.child(FilePath.java:891)
        at hudson.model.FileParameterValue$1.setUp(FileParameterValue.java:85)
        at hudson.model.Build$RunnerImpl.doRun(Build.java:132)
        at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:416)
        at hudson.model.Run.run(Run.java:1241)
        at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
        at hudson.model.ResourceController.execute(ResourceController.java:88)
        at hudson.model.Executor.run(Executor.java:124)

The "null" value here is the location that the file is copied to within the workspace. After applying the attached patch to FileParameterDefinition, the builds are successful and the file is copied into the workspace as expected.

Could I please have permissions to:
* Comment on this issue.
* Commit to the core (if I don't already have it as a plugin author).

Would someone mind looking over these diffs to make sure I haven't missed something?
hudson-model-FileParameterDefinition.java.diff
changelog.html.diff

Thanks,
Steven Brown
Reply | Threaded
Open this post in threaded view
|

Re: HUDSON-4296: First-time committer to Hudson core

Kohsuke Kawaguchi-3
On 05/30/2010 12:25 AM, Steven Brown wrote:

>
> Hello,
>
> I would like to fix  http://issues.hudson-ci.org/browse/HUDSON-4296
> HUDSON-4296 . This issue asks for the ability to upload file build
> parameters through the CLI. This has already been implemented (
> http://fisheye.hudson-ci.org/changelog/Hudson?cs=23543 r23543 ), but has a
> bug. Here is an example of the build console output:
>
> Started by command line
> Copying file to null
> FATAL: null
> java.lang.NullPointerException
> at hudson.FilePath.isAbsolute(FilePath.java:221)
> at hudson.FilePath.<init>(FilePath.java:209)
> at hudson.FilePath.child(FilePath.java:891)
> at hudson.model.FileParameterValue$1.setUp(FileParameterValue.java:85)
> at hudson.model.Build$RunnerImpl.doRun(Build.java:132)
> at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:416)
> at hudson.model.Run.run(Run.java:1241)
> at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
> at hudson.model.ResourceController.execute(ResourceController.java:88)
> at hudson.model.Executor.run(Executor.java:124)
>
> The "null" value here is the location that the file is copied to within the
> workspace. After applying the attached patch to FileParameterDefinition, the
> builds are successful and the file is copied into the workspace as expected.
>
> Could I please have permissions to:
> * Comment on this issue.
> * Commit to the core (if I don't already have it as a plugin author).

There's no machine-recognizable difference between a plugin committer
and a core committer, so if you already have a commit access to your
plugin, you should be able to do both of those (modulo a bit of time
delay that a relevant system has until it recognizes your commit access
--- often up to a few hours.)

> Would someone mind looking over these diffs to make sure I haven't missed
> something?
> http://hudson.361315.n4.nabble.com/file/n2236128/hudson-model-FileParameterDefinition.java.diff
> hudson-model-FileParameterDefinition.java.diff
> http://hudson.361315.n4.nabble.com/file/n2236128/changelog.html.diff
> changelog.html.diff

Looks good to me! Please go ahead and commit the change.

>
> Thanks,
> Steven Brown


--
Kohsuke Kawaguchi | InfraDNA, Inc. | http://infradna.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: HUDSON-4296: First-time committer to Hudson core

Steven Brown
Thanks Kohsuke.