HUDSON-5695 commit access

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

HUDSON-5695 commit access

sberan
I submitted a patch for HUDSON-5695 however I don't see anyone listed as the maintainer for the maven2 plugin. I would be happy to apply the patch given commit access.

My java.net username is sberan.

Thanks,
Sam
Reply | Threaded
Open this post in threaded view
|

Re: HUDSON-5695 commit access

Andrew Bayer
The Maven plugin is actually part of core, so you have to submit an SCA before making changes there: http://wiki.hudson-ci.org/display/HUDSON/Copyright+on+source+code - I'll take a look at your patch, though, and if I think it should go in, I'll apply it.

A.

On Thu, Feb 25, 2010 at 9:11 AM, sberan <[hidden email]> wrote:

I submitted a patch for  http://issues.hudson-ci.org/browse/HUDSON-5695
HUDSON-5695
 however I don't see anyone listed as the maintainer for the
maven2 plugin. I would be happy to apply the patch given commit access.

My java.net username is sberan.

Thanks,
Sam
--
View this message in context: http://n4.nabble.com/HUDSON-5695-commit-access-tp1569343p1569343.html
Sent from the Hudson dev mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]


Reply | Threaded
Open this post in threaded view
|

Re: HUDSON-5695 commit access

sberan
Thanks Andrew. After looking over the patch I realized I forgot to provide help text. I'll be updating the patch shortly.
Reply | Threaded
Open this post in threaded view
|

Re: HUDSON-5695 commit access

sberan
I updated the patch. Please let me know if it needs work or if there are issues with my approach to the problem.

Thanks again for looking at this.

Sam
Reply | Threaded
Open this post in threaded view
|

Re: HUDSON-5695 commit access

Kohsuke Kawaguchi-2
In reply to this post by Andrew Bayer
Andrew Bayer wrote:
> The Maven plugin is actually part of core, so you have to submit an SCA
> before making changes there:
> http://wiki.hudson-ci.org/display/HUDSON/Copyright+on+source+code - I'll
> take a look at your patch, though, and if I think it should go in, I'll
> apply it.

I believe we can take patches in without SCA. It's only when we hand out
the commit access for core changes that we need SCA.

Don't ask me why.

>
> A.
>
> On Thu, Feb 25, 2010 at 9:11 AM, sberan <[hidden email]> wrote:
>
>>
>> I submitted a patch for  http://issues.hudson-ci.org/browse/HUDSON-5695
>> HUDSON-5695 <http://issues.hudson-ci.org/browse/HUDSON-5695%0AHUDSON-5695> however I don't see anyone listed as the maintainer for the
>> maven2 plugin. I would be happy to apply the patch given commit access.
>>
>> My java.net username is sberan.
>>
>> Thanks,
>> Sam
>> --
>> View this message in context:
>> http://n4.nabble.com/HUDSON-5695-commit-access-tp1569343p1569343.html
>> Sent from the Hudson dev mailing list archive at Nabble.com.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>


--
Kohsuke Kawaguchi
Sun Microsystems                   http://weblogs.java.net/blog/kohsuke/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: HUDSON-5695 commit access

Andrew Bayer
Yeah, I meant that in order to commit to core, the SCA is needed - we can definitely take patches without. =)

A.

On Thu, Feb 25, 2010 at 4:49 PM, Kohsuke Kawaguchi <[hidden email]> wrote:
Andrew Bayer wrote:
> The Maven plugin is actually part of core, so you have to submit an SCA
> before making changes there:
> http://wiki.hudson-ci.org/display/HUDSON/Copyright+on+source+code - I'll
> take a look at your patch, though, and if I think it should go in, I'll
> apply it.

I believe we can take patches in without SCA. It's only when we hand out
the commit access for core changes that we need SCA.

Don't ask me why.

>
> A.
>
> On Thu, Feb 25, 2010 at 9:11 AM, sberan <[hidden email]> wrote:
>
>>
>> I submitted a patch for  http://issues.hudson-ci.org/browse/HUDSON-5695
>> HUDSON-5695 <http://issues.hudson-ci.org/browse/HUDSON-5695%0AHUDSON-5695> however I don't see anyone listed as the maintainer for the
>> maven2 plugin. I would be happy to apply the patch given commit access.
>>
>> My java.net username is sberan.
>>
>> Thanks,
>> Sam
>> --
>> View this message in context:
>> http://n4.nabble.com/HUDSON-5695-commit-access-tp1569343p1569343.html
>> Sent from the Hudson dev mailing list archive at Nabble.com.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>


--
Kohsuke Kawaguchi
Sun Microsystems                   http://weblogs.java.net/blog/kohsuke/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]