Internet explorer and configuration page/optional block

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Internet explorer and configuration page/optional block

Erik Ramfelt
Im having issues with the Hudson configuration page when using
internet explorer 7. It seems that the optional block doesnt work in
IE 7, i can see the block content even if the checkbox isnt checked.
This means that all configuration options are visible, and it makes
Hudson look more complex than it is (and much longer configpage). Has
anyone else seen this, or is it a known bug?

For a screen shot, look here http://ramfelt.se/tmp/img/hudson-ie-configure.png

//Erik

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Internet explorer and configuration page/optional block

Daniel Dyer-2
Quoting Erik Ramfelt <[hidden email]>:

> Im having issues with the Hudson configuration page when using
> internet explorer 7. It seems that the optional block doesnt work in
> IE 7, i can see the block content even if the checkbox isnt checked.
> This means that all configuration options are visible, and it makes
> Hudson look more complex than it is (and much longer configpage). Has
> anyone else seen this, or is it a known bug?
>
> For a screen shot, look here
> http://ramfelt.se/tmp/img/hudson-ie-configure.png
>
> //Erik

I see the same if I use IE7.  The status bar shows a JavaScript error, which could well be the root of the problem:

"Object doesn't support this property or method."

Dan.

--

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Internet explorer and configuration page/optional block

Daniel Dyer-2
On Tue, 27 Nov 2007 15:43:47 -0000, daniel dyer  
<[hidden email]> wrote:

> Quoting Erik Ramfelt <[hidden email]>:
>
>> Im having issues with the Hudson configuration page when using
>> internet explorer 7. It seems that the optional block doesnt work in
>> IE 7, i can see the block content even if the checkbox isnt checked.
>> This means that all configuration options are visible, and it makes
>> Hudson look more complex than it is (and much longer configpage). Has
>> anyone else seen this, or is it a known bug?
>>
>> For a screen shot, look here
>> http://ramfelt.se/tmp/img/hudson-ie-configure.png
>>
>> //Erik
>
> I see the same if I use IE7.  The status bar shows a JavaScript error,  
> which could well be the root of the problem:
>
> "Object doesn't support this property or method."
>
> Dan.

It was also broken in IE6.  I tracked it down to the hasClassName  
JavaScript function.  Apparently IE does not allow methods to be added to  
element objects using prototypes, so we have to invoke the function  
differently (which is what happens in other places that Hudson uses it).

I've just committed a fix in version 1.81 of hudson-behavior.js.

Dan.

--
Daniel Dyer
http://www.uncommons.org

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Internet explorer and configuration page/optional block

Kohsuke Kawaguchi
Administrator
Daniel Dyer wrote:

> On Tue, 27 Nov 2007 15:43:47 -0000, daniel dyer  
> <[hidden email]> wrote:
>
>> Quoting Erik Ramfelt <[hidden email]>:
>>
>>> Im having issues with the Hudson configuration page when using
>>> internet explorer 7. It seems that the optional block doesnt work in
>>> IE 7, i can see the block content even if the checkbox isnt checked.
>>> This means that all configuration options are visible, and it makes
>>> Hudson look more complex than it is (and much longer configpage). Has
>>> anyone else seen this, or is it a known bug?
>>>
>>> For a screen shot, look here
>>> http://ramfelt.se/tmp/img/hudson-ie-configure.png
>>>
>>> //Erik
>>
>> I see the same if I use IE7.  The status bar shows a JavaScript error,  
>> which could well be the root of the problem:
>>
>> "Object doesn't support this property or method."
>>
>> Dan.
>
> It was also broken in IE6.  I tracked it down to the hasClassName  
> JavaScript function.  Apparently IE does not allow methods to be added to  
> element objects using prototypes, so we have to invoke the function  
> differently (which is what happens in other places that Hudson uses it).
>
> I've just committed a fix in version 1.81 of hudson-behavior.js.
Thanks!

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Internet explorer and configuration page/optional block

Erik Ramfelt
In reply to this post by Daniel Dyer-2
On Nov 28, 2007 11:15 PM, Daniel Dyer <[hidden email]> wrote:

> On Tue, 27 Nov 2007 15:43:47 -0000, daniel dyer
> <[hidden email]> wrote:
>
> > Quoting Erik Ramfelt <[hidden email]>:
> >
> It was also broken in IE6.  I tracked it down to the hasClassName
> JavaScript function.  Apparently IE does not allow methods to be added to
> element objects using prototypes, so we have to invoke the function
> differently (which is what happens in other places that Hudson uses it).
>
> I've just committed a fix in version 1.81 of hudson-behavior.js.

I've just tried it and it works great!

Thanks for the quick solution!
//Erik

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]