[Issue 1335] New - URL from getUrlName() method of Action gets rendered with a trailing slash

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[Issue 1335] New - URL from getUrlName() method of Action gets rendered with a trailing slash

frizbog
https://hudson.dev.java.net/issues/show_bug.cgi?id=1335
                 Issue #|1335
                 Summary|URL from getUrlName() method of Action gets rendered w
                        |ith a trailing slash
               Component|hudson
                 Version|current
                Platform|All
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|plugin
             Assigned to|issues@hudson
             Reported by|frizbog






------- Additional comments from [hidden email] Tue Feb 26 03:11:33 +0000 2008 -------
When a class implementing Action returns a string from getUrlName(), the link
that is rendered in the list to the left always has a trailing slash, even
though I didn't supply one in the URL.  This causes problems when adding an
action linked to a specific file rather than a path on a site.  

For example, if MyAction.getUrlName() returns "http://foo.com/bar.html" to go to
a specific file in a site, the extra slash gets added and relative URL's in that
HTML file no longer work.  

Since URL's are allowed to include a filename, one should be able to return a
specific file from getUrlName() without it always being treated like only a path.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1335] URL from getUrlName() method of Action gets rendered with a trailing slash

Kohsuke Kawaguchi
Administrator
https://hudson.dev.java.net/issues/show_bug.cgi?id=1335



User kohsuke changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Fri Mar 21 02:01:50 +0000 2008 -------
Fixed in 1.200.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1335] URL from getUrlName() method of Action gets rendered with a trailing slash

scm_issue_link
In reply to this post by frizbog
https://hudson.dev.java.net/issues/show_bug.cgi?id=1335






------- Additional comments from [hidden email] Fri Mar 21 02:33:10 +0000 2008 -------
Code changed in hudson
User: kohsuke
Path:
 /hudson/www/changelog.html (1.1286)
 http://fisheye5.cenqua.com/changelog/hudson/?cs=kohsuke:MAIN:20080321020138

Log:
fixed issue #1335 by handling absolute URLs


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1335] URL from getUrlName() method of Action gets rendered with a trailing slash

frizbog
In reply to this post by frizbog
https://hudson.dev.java.net/issues/show_bug.cgi?id=1335



User frizbog changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|RESOLVED                  |VERIFIED
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Wed May  7 03:27:10 +0000 2008 -------
v1.205 and later (and possibly earlier) appear to have resolved this issue.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1335] URL from getUrlName() method of Action gets rendered with a trailing slash

scm_issue_link
In reply to this post by frizbog
https://hudson.dev.java.net/issues/show_bug.cgi?id=1335






------- Additional comments from [hidden email] Sun Nov  1 00:01:09 +0000 2009 -------
Code changed in hudson
User: : mindless
Path:
 trunk/hudson/main/core/src/main/java/hudson/Functions.java
http://fisheye4.cenqua.com/changelog/hudson/?cs=23393
Log:
[FIXED HUDSON-4720] Don't always append / to non-absolute action URLs,
as this may break some links (.../*.html for example).
See related HUDSON-1335, HUDSON-1679, r347 and r11319.
Updated hyperlinkMatchesCurrentPage to ignore trailing / in matching
to avoid regression in bold context links.
Also fixed tiny bug introduced in r13815 where "/" was changed to "."
in moving code from jelly to Functions, causing a couple links in
LogRecorder area (with href=".") to not show as bold.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]