[Issue 1679] New - is trailing slash in action url really fixed?

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Issue 1679] New - is trailing slash in action url really fixed?

jonathan_w_brown
https://hudson.dev.java.net/issues/show_bug.cgi?id=1679
                 Issue #|1679
                 Summary|is trailing slash in action url really fixed?
               Component|hudson
                 Version|current
                Platform|All
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|plugin
             Assigned to|issues@hudson
             Reported by|jonathan_w_brown






------- Additional comments from [hidden email] Tue May 13 15:43:40 +0000 2008 -------
This is a comment regarding issue 1335.  Apologies in advance for the
duplication but I didn't see how/where to reopen the existing issue.

I still see the/a problem as of v1.213.  I took a look at
lib/hudson/actions.jelly and a trailing slash is appended to my custom action:
<l:task icon="${h.getIconFilePath(action)}" title="${action.displayName}"
        href="${h.getActionUrl(it.url,action)}/" />

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1679] is trailing slash in action url really fixed?

frizbog
https://hudson.dev.java.net/issues/show_bug.cgi?id=1679



User frizbog changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Wed May 28 03:56:17 +0000 2008 -------
Confirmed.  Checked in correction to actions.jelly.  Related items checked in
during the original fix are fine.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1679] is trailing slash in action url really fixed?

scm_issue_link
In reply to this post by jonathan_w_brown
https://hudson.dev.java.net/issues/show_bug.cgi?id=1679






------- Additional comments from [hidden email] Wed May 28 21:45:48 +0000 2008 -------
Code changed in hudson
User: : kohsuke
Path:
 trunk/www/changelog.html
http://fisheye4.cenqua.com/changelog/hudson/?cs=9665
Log:
recording HUDSON-1679. Targeted for 1.220.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1679] is trailing slash in action url really fixed?

scm_issue_link
In reply to this post by jonathan_w_brown
https://hudson.dev.java.net/issues/show_bug.cgi?id=1679






------- Additional comments from [hidden email] Sun Nov  1 00:01:00 +0000 2009 -------
Code changed in hudson
User: : mindless
Path:
 trunk/hudson/main/core/src/main/java/hudson/Functions.java
http://fisheye4.cenqua.com/changelog/hudson/?cs=23393
Log:
[FIXED HUDSON-4720] Don't always append / to non-absolute action URLs,
as this may break some links (.../*.html for example).
See related HUDSON-1335, HUDSON-1679, r347 and r11319.
Updated hyperlinkMatchesCurrentPage to ignore trailing / in matching
to avoid regression in bold context links.
Also fixed tiny bug introduced in r13815 where "/" was changed to "."
in moving code from jelly to Functions, causing a couple links in
LogRecorder area (with href=".") to not show as bold.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]