[Issue 1816] New - Problem with "changes" report if build done based on CVS label

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[Issue 1816] New - Problem with "changes" report if build done based on CVS label

jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816
                 Issue #|1816
                 Summary|Problem with "changes" report if build done based on C
                        |VS label
               Component|hudson
                 Version|current
                Platform|All
              OS/Version|Linux
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|cvs
             Assigned to|issues@hudson
             Reported by|jferr






------- Additional comments from [hidden email] Fri Jun  6 14:15:25 +0000 2008 -------
We use CVS for version control.
"Changes" report doesn't appear to show any changes if builds were performed
from a label rather than as a "tip/HEAD/Latest" revision build.

I have a project that is set up in Maven as a CI build for the development team.
 The change report works fine here.  For the very same project, I do "official"
QA builds off a label and the changelog report doesn't show any changes.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816






------- Additional comments from [hidden email] Fri Jun  6 17:31:30 +0000 2008 -------
Just did some research (I'm sure you already know these details, but for
completeness);  It appears that the ant task "ChangeLog" won't take tags as
parameters, but the CVSTagDiff task will.  But CVSTagDiff doesn't appear to
include check-in comments in it's xml output.

So, I suppose this is an enhancement if you were to add "CVSTagDiff" for builds
that were based on tags.

Minimally (if running CVSTagDIff doesn't work for some reason), Hudson shouldn't
falsely display "no changes" if a build was based on a tag.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

jackgene
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816



User jackgene changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |STARTED
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Mon Jul 21 15:42:12 +0000 2008 -------
Hi,
This affects us too, in fact in a bigger way, since we tag everything to be
built. I was looking into this over the weekend, and I believe the problem was
due to the version of the Ant CVS ChangeLogTask being used (it may have been a
bug, or it may have been intended, but either way, it's been resolved in Ant
1.7.1).

I was able to get the 1.235 Hudson source, and update it to use the latest Ant
task, which has partially resolved this issue. Here's everything I had to do
(I'll be updating this source shortly):
1. Replace everything under hudson.org.apache.tools.ant.taskdefs (and sub-
packages) with the latest Ant source.
2. Made some changes to the Ant task (I tried to minimize this to simplify
future updates to the task):
a. Re-introduced the one change Kohsuke did related to timezone issues
(ChangeLogTask.java:235-252).
b. Re-introduced the cvsExe property to the task (AbstractCvsTask.java:151,160-
162,767) (Ant 1.7.1 no longer allows you to specify the CVS binary to use, and
instead assumes that "cvs" will be in your path, Hudson still allows you to
specify the "cvs" location, so I thought this would be a good idea to add it).
c. Added " * @version Ant 1.7.1 (Copied into Hudson)" to JavaDoc so that we can
keep track of which version of the Ant task is being used.
3. Modified hudson.scm.CVSSCM to account for changes in the Ant task:
a. Made "changeLogFile" parameter final in calcChangeLog so that it can be
accesssed from an inner class (CVSSCM:701).
b. Modified to pass the changeLogFile location to the Ant task using setDestfile
(File) instead of setDeststream(OutputStream) (CVSSCM:760, CVSSCM:796).
c. Modified to pass branch to Ant task using setTag(String) instead of setBranch
(String) (CVSSCM:761)
d. Modified the way we pass changedFiles to the Ant task (CVSSCM:773-783)
e. Modified the way modules/packages are passed to the Ant task (CVSSCM:789)
(I'll be revisiting this).

Everything up to now has simply been to get Hudson to work with the new Ant
task. This caused some information to appear in the change log, when builds are
triggered based on tags. However, because there are no historical information
associated with tags, the change log only shows the revision of the file that
was tagged (even when there may be multiple revisions to the file since the
last build). To resolve this, I've modified the "task.setTag(String)" line as
follows:

task.setTag(isTag() ? ":" + branch : branch);
(Passing ":rev" to CVS tells it to generate change log for the revision
tagged "rev" and before, on the same branch, per CVSNT's "cvs log --help").

There are still a few outstanding issues:
1. Since tags are not versioned, it is possible for a file to be *committed*
before the previous build, but tagged after the build. This will cause a new
build to be triggered. However, the change log will not include information
about this file, since as far as CVS is concerned, the change occurred before
the last build.
2. Tags can be moved backwards to an older revision, or across branches, which
will probably cause some problems.

I'll continue to work on these issues.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

jackgene
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816






------- Additional comments from [hidden email] Mon Jul 21 15:49:16 +0000 2008 -------
Created an attachment (id=329)
Files mentioned in my last comment in this issue.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

ybubnov
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816






------- Additional comments from [hidden email] Wed Aug 12 19:34:33 +0000 2009 -------
Created an attachment (id=839)
small patch to fix just the problem


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

ybubnov
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816






------- Additional comments from [hidden email] Wed Aug 12 19:36:18 +0000 2009 -------
I think jackgene's patch is somewhat overreacted for the problem in hand. We
need just to specify branch or tag during 'cvs log' command.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

scm_issue_link
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816



User scm_issue_link changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|STARTED                   |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Thu Aug 13 18:14:42 +0000 2009 -------
Code changed in hudson
User: : kohsuke
Path:
 trunk/hudson/main/core/src/main/java/hudson/scm/CVSSCM.java
 trunk/www/changelog.html
http://fisheye4.cenqua.com/changelog/hudson/?cs=20679
Log:
[FIXED HUDSON-1816] In 1.321. Applied a patch from Yury Bubnov.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

liyatikal
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816



User liyatikal changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|RESOLVED                  |REOPENED
--------------------------------------------------------------------------------
              Resolution|FIXED                     |
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Wed Sep  9 14:06:51 +0000 2009 -------
still doesn't work with the latest 1.323 for the cvs branch (not tag)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

mcgrey
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816



User mcgrey changed the following:

                What    |Old value                 |New value
================================================================================
              OS/Version|Linux                     |All
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Fri Sep 11 06:33:37 +0000 2009 -------
Applied changes http://fisheye4.cenqua.com/changelog/hudson/?cs=20679 broke
initial functionality: finding changes in CVS "branches".
Line
===
task.setBranch(branch);
===
is needed to enforce ChangeLogParser find a "branch".

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

mcgrey
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816



User mcgrey changed the following:

                What    |Old value                 |New value
================================================================================
     Attachment is patch|                          |Created an attachment (id=
                        |                          |899)
Here is the patch to
                        |                          |bring initial functionalit
                        |                          |y back. P.S. And excuse me
                        |                          | my misspelled "brock" ins
                        |                          |tead of "broke" =)

--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Fri Sep 11 06:39:35 +0000 2009 -------
Created an attachment (id=899)
Here is the patch to bring initial functionality back. P.S. And excuse me my misspelled "brock" instead of "broke" =)


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

mcgrey
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816






------- Additional comments from [hidden email] Fri Sep 11 06:42:23 +0000 2009 -------
*** Issue 2726 has been marked as a duplicate of this issue. ***

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

ybubnov
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816






------- Additional comments from [hidden email] Thu Sep 17 02:14:12 +0000 2009 -------
Created an attachment (id=914)
Proposed patch fix problem with brunches and tags in them.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

ybubnov
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816






------- Additional comments from [hidden email] Thu Sep 17 02:22:05 +0000 2009 -------
My previous patch broke change log calculation on CVS Branches. Mcgrey's patch
fixed that but doesn't work with tags on branches.
I proposed the patch that fix the problem.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

klaus__
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816






------- Additional comments from [hidden email] Fri Oct 16 19:58:19 +0000 2009 -------
When will this finally go into the official Hudson build?
I am still waiting for the resolution of #4324, which I opened. It's the same
issue if I am not mistaken. And I opened it in August.
I am surprised that not too many people seem to have issues...

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

scm_issue_link
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816



User scm_issue_link changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|REOPENED                  |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Thu Oct 22 23:05:06 +0000 2009 -------
Code changed in hudson
User: : kohsuke
Path:
 trunk/hudson/main/core/src/main/java/hudson/model/UpdateCenter.java
 trunk/hudson/main/core/src/main/java/hudson/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java
 trunk/hudson/main/core/src/main/java/hudson/scm/CVSSCM.java
 trunk/www/changelog.html
http://fisheye4.cenqua.com/changelog/hudson/?cs=23071
Log:
[FIXED HUDSON-1816] in 1.331. Applied a patch from ybubnov, and made him a committer.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

Kohsuke Kawaguchi
Administrator
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816






------- Additional comments from [hidden email] Fri Oct 23 20:34:42 +0000 2009 -------
*** Issue 4324 has been marked as a duplicate of this issue. ***

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 1816] Problem with "changes" report if build done based on CVS label

klaus__
In reply to this post by jferr
https://hudson.dev.java.net/issues/show_bug.cgi?id=1816






------- Additional comments from [hidden email] Mon Nov  2 18:47:27 +0000 2009 -------
Just upgraded to Hudson 1.331.. and it works!
Thanks

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]