[Issue 191] add more info into rss feed

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Issue 191] add more info into rss feed

vsizikov
https://hudson.dev.java.net/issues/show_bug.cgi?id=191






------- Additional comments from [hidden email] Sun Dec 10 19:41:50 +0000 2006 -------
>FeedAdapter is designed to be usable for any feed, not just
> the builds and runs,
> so having a method like "getChanges" might not be appropriate.

Right, I see you point. On the other hand, for feeds that don't use builds and
runs, an empty changeset will be returned from getChanges(). So, to me, the
proposed bugfix, while not elegant and ideal, is simple enough and works. :)

> I wonder if the proper abstraction is to define a method that renders HTML
> content for 'E'? (we could even make it a view jelly.) Then we can have a
> partial implementation of FeedAdapter for "E extends Run" and make the default
> renderer the change list.

I'm not sure I fully understand this. Ideally, the FeedAdapter should supply
different feed types with some data to include into those feeds. And not all of
them will use HTML. For example, ATOM requires proper XHTML included in div's,
while RSS 2.0 requires some weird format - text, with brackets encoded as < >.

And by providing the method that renders the HTML, aren't we mixing a model and
its view? FeedAdapter should know nothing about the format, but should only
supply data, isn't it?

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]