[Issue 3925] New - Clear workspace before build

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Issue 3925] New - Clear workspace before build

syvalta-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=3925
                 Issue #|3925
                 Summary|Clear workspace before build
               Component|hudson
                 Version|current
                Platform|All
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|ENHANCEMENT
                Priority|P3
            Subcomponent|m2release
             Assigned to|teilo
             Reported by|syvalta






------- Additional comments from [hidden email] Thu Jun 25 12:39:34 +0000 2009 -------
Release builds should be built from clear workspace.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 3925] Clear workspace before build

syvalta-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=3925






------- Additional comments from [hidden email] Thu Jun 25 12:43:48 +0000 2009 -------
Created an attachment (id=755)
Patch that adds clear workspace, fixes race a condition and decreases copy-paste code. Sorry about the white space changes.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 3925] Clear workspace before build

syvalta-2
In reply to this post by syvalta-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=3925






------- Additional comments from [hidden email] Thu Jun 25 13:44:04 +0000 2009 -------
Created an attachment (id=756)
Updated patch, the previous patch used next dev version when setting build description instead of the release version


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 3925] Clear workspace before build

teilo-2
In reply to this post by syvalta-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=3925






------- Additional comments from [hidden email] Thu Jun 25 20:25:38 +0000 2009 -------
Thanks for the patch but I want to understand this a bit more.

Currently releases are effectivly done from a clean checkout - which is
${workspace_loc}/target/checkout

if you want to make sure its clean you just need to add the clean goal before
release:prepare release:perfrom options in the release goals.

If your using a local m2 repository which is recommended I think cleaning the m2
repo should be pushed up to the maven core to clean - and the m2release plugin
just triggers that to clean itself.

If your not using a local m2 repo then you have other issues(!)

Other than that what was the race condition and under what circumstances did it
manifest itself?

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 3925] Clear workspace before build

syvalta-2
In reply to this post by syvalta-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=3925






------- Additional comments from [hidden email] Fri Jun 26 06:43:09 +0000 2009 -------
I thought it as precaution to guarantee that the release is buildable from clean
checkout. But you are right, if it isn't the build will fail at release:perform.
So the patch just makes it to fail earlier (already in release:prepare before
tagging instead only in release:perform).

About the race condition: when M2ReleaseAction schedules a build it synchronizes
on the M2ReleaseBuildWrapper instance. However, M2ReleaseBuildWrapper.setUp
doesn't synchronize on anything, so it might run before M2ReleaseAction has set
the release properties, or they might be only partially set. The patch makes the
setUp() to wait M2ReleaseAction to signal that everything is set up.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 3925] Clear workspace before build

teilo-2
In reply to this post by syvalta-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=3925






------- Additional comments from [hidden email] Mon Jul 20 10:10:29 +0000 2009 -------
Race condition is fixed in 0.3.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]