[Issue 3964] New - Regression in user name handling: "Bob <bob@x.com>" -> "Bob _bob@x.com>"

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Issue 3964] New - Regression in user name handling: "Bob <bob@x.com>" -> "Bob _bob@x.com>"

jglick-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=3964
                 Issue #|3964
                 Summary|Regression in user name handling: "Bob <[hidden email]>" ->
                        | "Bob [hidden email]>"
               Component|hudson
                 Version|current
                Platform|All
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P2
            Subcomponent|core
             Assigned to|issues@hudson
             Reported by|jglick






------- Additional comments from [hidden email] Tue Jun 30 16:04:44 +0000 2009 -------
Between 1.309 and 1.313, display of Mercurial users was broken. For example,

http://hg.netbeans.org/core-main/rev/3c5fac30b9a4

shows a user "Tomas Hurka <[hidden email]>" and changelog.xml contains this
name as well. But

http://deadlock.netbeans.org/hudson/job/NB-Core-Build/2834/changes

shows "Tomas Hurka [hidden email]>"

as does

http://deadlock.netbeans.org/hudson/job/NB-Core-Build/2834/api/xml

so this broken name appears also in the NetBeans changelog view.

The culprit seems to be 18760 in User.java:

id = id.replace('\\', '_').replace('/', '_').replace('<','_');

I am guessing that the correct fix is for the User constructor to take both id
and fullName params, with fullName being the unescaped original arg to User.get.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 3964] Regression in user name handling: "Bob <bob@x.com>" -> "Bob _bob@x.com>"

scm_issue_link
https://hudson.dev.java.net/issues/show_bug.cgi?id=3964



User scm_issue_link changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Tue Jun 30 16:33:12 +0000 2009 -------
Code changed in hudson
User: : jglick
Path:
 trunk/hudson/main/core/src/main/java/hudson/model/User.java
 trunk/hudson/main/core/src/main/java/hudson/tasks/MailAddressResolver.java
http://fisheye4.cenqua.com/changelog/hudson/?cs=19322
Log:
[FIXED HUDSON-3964] Can escape characters in username to make an ID, but retain the original form for display & email purposes.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 3964] Regression in user name handling: "Bob <bob@x.com>" -> "Bob _bob@x.com>"

scm_issue_link
In reply to this post by jglick-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=3964






------- Additional comments from [hidden email] Tue Jun 30 16:36:24 +0000 2009 -------
Code changed in hudson
User: : jglick
Path:
 trunk/www/changelog.html
http://fisheye4.cenqua.com/changelog/hudson/?cs=19323
Log:
[HUDSON-3964] Noting.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]