[Issue 4762] New - Hudson Selenium Grid may choose wrong remote control

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[Issue 4762] New - Hudson Selenium Grid may choose wrong remote control

sannies
https://hudson.dev.java.net/issues/show_bug.cgi?id=4762
                 Issue #|4762
                 Summary|Hudson Selenium Grid may choose wrong remote control
               Component|hudson
                 Version|current
                Platform|All
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|other
             Assigned to|issues@hudson
             Reported by|sannies






------- Additional comments from [hidden email] Tue Nov  3 14:13:43 +0000 2009 -------
(btw - the plugin has no component in the issue tracker)

while iterating over the remote controls:

HudsonRemoteControlPool.java

60: for (RemoteControlProxy rc : all) {
61:   if((hadMatch|=matches(rc,keys)) && rc.canHandleNewSession()) {
62:     rc.registerNewSession();
63:     return rc;
64:   }
65: }

it can happen that on the first pass a remotecontrol matches (hadMatch becomes
true) but is CANNOT handleNewSession. The next remotecontrol will now be chosen
regardless the result of the matches(rc,keys). So in many cases a wrong RC will
be chosen.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 4762] Hudson Selenium Grid may choose wrong remote control

sannies
https://hudson.dev.java.net/issues/show_bug.cgi?id=4762



User sannies changed the following:

                What    |Old value                 |New value
================================================================================
     Attachment is patch|                          |Created an attachment (id=
                        |                          |989)
patch for choosing co
                        |                          |rrect RC

--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Tue Nov  3 14:15:04 +0000 2009 -------
Created an attachment (id=989)
patch for choosing correct RC


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]