[Issue 4894] New - Hudson 1.334 crashes when using a custom workspace

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[Issue 4894] New - Hudson 1.334 crashes when using a custom workspace

mrobinet-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=4894
                 Issue #|4894
                 Summary|Hudson 1.334 crashes when using a custom workspace
               Component|hudson
                 Version|current
                Platform|All
              OS/Version|Windows XP
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P2
            Subcomponent|core
             Assigned to|issues@hudson
             Reported by|mrobinet






------- Additional comments from [hidden email] Wed Nov 18 19:36:06 +0000 2009 -------
Upgraded to 1.334 and encountered a problem with using a custom workspace:
FATAL: Failed to mkdirs: D:\devtools\Hudson\N:\
java.io.IOException: Failed to mkdirs: D:\devtools\Hudson\N:\
        at hudson.FilePath.mkdirs(FilePath.java:744)
        at hudson.model.AbstractProject.checkout(AbstractProject.java:1004)
        at
hudson.model.AbstractBuild$AbstractRunner.checkout(AbstractBuild.java:431)
        at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:378)
        at hudson.model.Run.run(Run.java:1176)
        at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
        at hudson.model.ResourceController.execute(ResourceController.java:88)
        at hudson.model.Executor.run(Executor.java:123)

I have the custom workspace set to N:\ which is a substed drive on a Windows XP
machine.  Not sure if the substing is relevant, but figured I'd mention it (I'm
guessing not).  Rolling back to 1.333 fixed the issue for me.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 4894] Hudson 1.334 build fails with custom workspace on windows drive with no subdir

Alan Harder-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=4894



User mindless changed the following:

                What    |Old value                 |New value
================================================================================
             Assigned to|issues@hudson             |mindless
--------------------------------------------------------------------------------
                Priority|P2                        |P3
--------------------------------------------------------------------------------
                 Summary|Hudson 1.334 crashes when |Hudson 1.334 build fails w
                        |using a custom workspace  |ith custom workspace on wi
                        |                          |ndows drive with no subdir
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Wed Nov 18 23:32:26 +0000 2009 -------
This is caused by:
https://hudson.dev.java.net/source/browse/hudson?view=rev&rev=23656

It _does_ check for absolute path, so it shouldn't append your N:\ onto the root
dir of the node... however, the check for absolute is "[A-Za-z]:\\.+" which
means it assumes there is at least one character after the backslash.. in your
case there is none.  I'll change it to .* so your path here will be recognized
as absolute.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 4894] Hudson 1.334 build fails with custom workspace on windows drive with no subdir

scm_issue_link
In reply to this post by mrobinet-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=4894



User scm_issue_link changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Wed Nov 18 23:38:44 +0000 2009 -------
Code changed in hudson
User: : mindless
Path:
 trunk/hudson/main/core/src/main/java/hudson/FilePath.java
 trunk/www/changelog.html
http://fisheye4.cenqua.com/changelog/hudson/?cs=23832
Log:
[FIXED HUDSON-4894] update DRIVE_PATTERN so a path like C:\ is recognized as absolute


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 4894] Hudson 1.334 build fails with custom workspace on windows drive with no subdir

torbent
In reply to this post by mrobinet-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=4894



User torbent changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|RESOLVED                  |REOPENED
--------------------------------------------------------------------------------
              Resolution|FIXED                     |
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Fri Nov 20 12:23:14 +0000 2009 -------
I just ran into the same issue when upgrading to 1.334. However, our paths are
not X:\, but more like X:/hudson/etc, with forward slashes. Yes, that works for
Windows (at least for Hudson on Windows), and I'd like to request that it keeps
working.
So "[A-Za-z]:\\.*" should maybe be "[A-Za-z]:[\\/].*"?
Another question is whether a bare "X:" would be considered an absolute dir? The
regex doesn't.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 4894] Hudson 1.334 build fails with custom workspace on windows drive with no subdir

torbent
In reply to this post by mrobinet-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=4894



User torbent changed the following:

                What    |Old value                 |New value
================================================================================
                      CC|''                        |'torbent'
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Fri Nov 20 12:24:28 +0000 2009 -------
(forgot to CC myself)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 4894] Hudson 1.334 build fails with custom workspace on windows drive with no subdir

scm_issue_link
In reply to this post by mrobinet-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=4894



User scm_issue_link changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|REOPENED                  |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Fri Nov 20 16:15:34 +0000 2009 -------
Code changed in hudson
User: : mindless
Path:
 trunk/hudson/main/core/src/main/java/hudson/FilePath.java
http://fisheye4.cenqua.com/changelog/hudson/?cs=23889
Log:
[FIXED HUDSON-4894] match windows absolute path like C:/path as requested by torbent.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 4894] Hudson 1.334 build fails with custom workspace on windows drive with no subdir

Alan Harder-2
In reply to this post by mrobinet-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=4894






------- Additional comments from [hidden email] Fri Nov 20 16:18:07 +0000 2009 -------
I added the / but did not allow no \ or /.  When I do "dir C:" it seems
relative, as it shows the cwd on C: and not the root dir of C:.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 4894] Hudson 1.334 build fails with custom workspace on windows drive with no subdir

scm_issue_link
In reply to this post by mrobinet-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=4894






------- Additional comments from [hidden email] Fri Nov 20 16:40:58 +0000 2009 -------
Code changed in hudson
User: : mindless
Path:
 branches/rc/core/src/main/java/hudson/FilePath.java
 trunk/www/changelog.html
http://fisheye4.cenqua.com/changelog/hudson/?cs=23890
Log:
[HUDSON-4894] merge r23889 to rc branch for 1.335


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Issue 4894] Hudson 1.334 build fails with custom workspace on windows drive with no subdir

torbent
In reply to this post by mrobinet-2
https://hudson.dev.java.net/issues/show_bug.cgi?id=4894



User torbent changed the following:

                What    |Old value                 |New value
================================================================================
                      CC|'torbent'                 |''
--------------------------------------------------------------------------------
                  Status|RESOLVED                  |VERIFIED
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Tue Nov 24 09:35:06 +0000 2009 -------
Verified as working in 1.335

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]