JEP proposal: Removing user-facing scripting features from core

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

JEP proposal: Removing user-facing scripting features from core

Daniel Beck
Hi everyone,

This is a pre-JEP check[1]: Would https://github.com/jenkinsci/jenkins/pull/3006 (the goal, rationale etc., not the implementation details) have a chance as a JEP, or is it a waste of time?

Thanks,
Daniel

1: https://github.com/jenkinsci/jep/tree/master/jep/1#discussion

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/13F744D4-88B0-43CE-A07E-F818625BF758%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: JEP proposal: Removing user-facing scripting features from core

R. Tyler Croy
(replies inline)

On Mon, 13 Nov 2017, Daniel Beck wrote:

> Hi everyone,
>
> This is a pre-JEP check[1]: Would https://github.com/jenkinsci/jenkins/pull/3006 (the goal, rationale etc., not the implementation details) have a chance as a JEP, or is it a waste of time?


What impact does this have on the Script Console or the CLI, both of which
expose scripting functionality?

I might not be educated enough to understand the nuance of "removing scripting"
which somehow still leaves Groovy in core, and features like init.groovy.d/.
Can you elaborate a bit more on what features/functionalities are being
proposed for extraction here?


Cheers
- R. Tyler Croy

------------------------------------------------------
     Code: <https://github.com/rtyler>
  Chatter: <https://twitter.com/agentdero>
     xmpp: [hidden email]

  % gpg --keyserver keys.gnupg.net --recv-key 1426C7DC3F51E16F
------------------------------------------------------

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/20171113164050.cbb7s6wbkqmp4ur4%40blackberry.coupleofllamas.com.
For more options, visit https://groups.google.com/d/optout.

signature.asc (201 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: JEP proposal: Removing user-facing scripting features from core

Daniel Beck

> On 13. Nov 2017, at 17:40, R. Tyler Croy <[hidden email]> wrote:
>
> What impact does this have on the Script Console or the CLI, both of which
> expose scripting functionality?

The "Script Console" and groovy/groovysh CLI commands (and more) would be moved into a plugin, so OOTB, Jenkins would have no text fields taking 'system' Groovy for management purposes.

The idea is that with that plugin, the exact same features will be available, but without it, you don't have them. Implementation TBD.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/ECBD1D88-F939-42FC-835B-324C9C1F261E%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: JEP proposal: Removing user-facing scripting features from core

Oleg Nenashev
Personally I am +1 about **considering** it. My main concern is that Groovy logic is being often [mis]used by configuration management tools, e.g. to install plugins by CLI calls. If we remove CLI handlers from the core, I would expect it to cause some collateral damage on this scenarios. IMHO it needs a wider poll via Users mailing list and blog post once CI is accepted as a draft.

Regarding keeping Groovy in the core, we need a pluggable core components story (JENKINS-41196) to be delivered for that. Groovy Init Hooks are critical to Jenkins environments, and this part should not be detached to plugins IMHO.

BR, Oleg


понедельник, 13 ноября 2017 г., 17:52:06 UTC+1 пользователь Daniel Beck написал:

> On 13. Nov 2017, at 17:40, R. Tyler Croy <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="EjLQy07wCwAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">ty...@...> wrote:
>
> What impact does this have on the Script Console or the CLI, both of which
> expose scripting functionality?

The "Script Console" and groovy/groovysh CLI commands (and more) would be moved into a plugin, so OOTB, Jenkins would have no text fields taking 'system' Groovy for management purposes.

The idea is that with that plugin, the exact same features will be available, but without it, you don't have them. Implementation TBD.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/80102361-9d82-43da-b254-e85909d7a238%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: JEP proposal: Removing user-facing scripting features from core

Jesse Glick-4
In reply to this post by Daniel Beck
On Mon, Nov 13, 2017 at 6:25 AM, Daniel Beck <[hidden email]> wrote:
> Would https://github.com/jenkinsci/jenkins/pull/3006 (the goal, rationale etc., not the implementation details) have a chance as a JEP

Yes.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0gbewh3Zs%2BMDPZ9C7KBz%3DbE%2BvP_YES51zU5siv6EMp%2Bw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: JEP proposal: Removing user-facing scripting features from core

Kohsuke Kawaguchi
Administrator
Is this any different from all the other extractions of features into plugins? I guess back then we used to bundle those extracted stuff as bundled plugins?

On Tue, Nov 14, 2017 at 4:30 AM Jesse Glick <[hidden email]> wrote:
On Mon, Nov 13, 2017 at 6:25 AM, Daniel Beck <[hidden email]> wrote:
> Would https://github.com/jenkinsci/jenkins/pull/3006 (the goal, rationale etc., not the implementation details) have a chance as a JEP

Yes.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0gbewh3Zs%2BMDPZ9C7KBz%3DbE%2BvP_YES51zU5siv6EMp%2Bw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
--
Kohsuke Kawaguchi

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAN4CQ4xcVzM-Awpn67phaDhkqwhOda58yo9KXj6OoX7nQR1ifg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: JEP proposal: Removing user-facing scripting features from core

Jesse Glick-4
On Mon, Nov 13, 2017 at 11:34 PM, Kohsuke Kawaguchi <[hidden email]> wrote:
> Is this any different from all the other extractions of features into
> plugins? I guess back then we used to bundle those extracted stuff as
> bundled plugins?

We now bundle them in `jenkins.war` as _detached_ plugins, meaning
they are not automatically installed—only if there is some implicit
dependency on them from another plugin, or (IIRC) when you are
upgrading from prior to the split point.

The JEP should clarify the status of the split plugin w.r.t. the setup
wizard for new installations: should it be “suggested” but not
“recommended”, say?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr36N5_y8eYc8egwGtK1DcJUokO%3D5LXV3hOr27sipzFW8g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.