[JIRA] Created: (HUDSON-5610) be able to do 'doCheckXXX' for forms with multiple parameters

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (HUDSON-5610) be able to do 'doCheckXXX' for forms with multiple parameters

Hudson issues mailing list
be able to do 'doCheckXXX' for forms with multiple parameters
-------------------------------------------------------------

                 Key: HUDSON-5610
                 URL: http://issues.hudson-ci.org/browse/HUDSON-5610
             Project: Hudson
          Issue Type: Improvement
            Reporter: lifeless


E.g. in the EC2 plugin the 'endpoint url' field can only be reliably validated using the accesskey and secretkey, so we would want
doCheckec2EndpointUrl(@QueryParameter String EndpointUrl, @QueryParameter String accessId, @QueryParameter String secretKey) {
...
}

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Assigned: (HUDSON-5610) be able to do 'doCheckXXX' for forms with multiple parameters

Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

kohsuke reassigned HUDSON-5610:
-------------------------------

    Assignee: kohsuke

> be able to do 'doCheckXXX' for forms with multiple parameters
> -------------------------------------------------------------
>
>                 Key: HUDSON-5610
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-5610
>             Project: Hudson
>          Issue Type: Improvement
>            Reporter: lifeless
>            Assignee: kohsuke
>
> E.g. in the EC2 plugin the 'endpoint url' field can only be reliably validated using the accesskey and secretkey, so we would want
> doCheckec2EndpointUrl(@QueryParameter String EndpointUrl, @QueryParameter String accessId, @QueryParameter String secretKey) {
> ...
> }

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-5610) be able to do 'doCheckXXX' for forms with multiple parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=135861#action_135861 ]

kohsuke commented on HUDSON-5610:
---------------------------------

Attack plan:

* Descriptor.doCheckUrl needs to look at the signature of the check method to determine what parameters need to be sent back. Need to think about how this works, given the existing behavior of passing in the current value as "value". Perhaps a new annotation is in order?
* A little bit of client-side JavaScript addition to discover nearby fields of the specified name, that properly incorporates the tree structure boundary.

> be able to do 'doCheckXXX' for forms with multiple parameters
> -------------------------------------------------------------
>
>                 Key: HUDSON-5610
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-5610
>             Project: Hudson
>          Issue Type: Improvement
>            Reporter: lifeless
>            Assignee: kohsuke
>
> E.g. in the EC2 plugin the 'endpoint url' field can only be reliably validated using the accesskey and secretkey, so we would want
> doCheckec2EndpointUrl(@QueryParameter String EndpointUrl, @QueryParameter String accessId, @QueryParameter String secretKey) {
> ...
> }

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-5610) be able to do 'doCheckXXX' for forms with multiple parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=135903#action_135903 ]

scm_issue_link commented on HUDSON-5610:
----------------------------------------

Code changed in hudson
User: : kohsuke
Path:
 trunk/hudson/main/core/pom.xml
 trunk/hudson/main/core/src/main/java/hudson/model/Descriptor.java
 trunk/hudson/main/war/resources/scripts/hudson-behavior.js
 trunk/www/changelog.html
http://hudson-ci.org/commit/27436
Log:
[FIXED HUDSON-5610] Improved the form validation mechanism to support multiple controls.


> be able to do 'doCheckXXX' for forms with multiple parameters
> -------------------------------------------------------------
>
>                 Key: HUDSON-5610
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-5610
>             Project: Hudson
>          Issue Type: Improvement
>            Reporter: lifeless
>            Assignee: kohsuke
>
> E.g. in the EC2 plugin the 'endpoint url' field can only be reliably validated using the accesskey and secretkey, so we would want
> doCheckec2EndpointUrl(@QueryParameter String EndpointUrl, @QueryParameter String accessId, @QueryParameter String secretKey) {
> ...
> }

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (HUDSON-5610) be able to do 'doCheckXXX' for forms with multiple parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

scm_issue_link resolved HUDSON-5610.
------------------------------------

    Resolution: Fixed

> be able to do 'doCheckXXX' for forms with multiple parameters
> -------------------------------------------------------------
>
>                 Key: HUDSON-5610
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-5610
>             Project: Hudson
>          Issue Type: Improvement
>            Reporter: lifeless
>            Assignee: kohsuke
>
> E.g. in the EC2 plugin the 'endpoint url' field can only be reliably validated using the accesskey and secretkey, so we would want
> doCheckec2EndpointUrl(@QueryParameter String EndpointUrl, @QueryParameter String accessId, @QueryParameter String secretKey) {
> ...
> }

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Reopened: (HUDSON-5610) be able to do 'doCheckXXX' for forms with multiple parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

mindless reopened HUDSON-5610:
------------------------------


All form field validators and form submissions are now failing in trunk.

> be able to do 'doCheckXXX' for forms with multiple parameters
> -------------------------------------------------------------
>
>                 Key: HUDSON-5610
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-5610
>             Project: Hudson
>          Issue Type: Improvement
>            Reporter: lifeless
>            Assignee: kohsuke
>
> E.g. in the EC2 plugin the 'endpoint url' field can only be reliably validated using the accesskey and secretkey, so we would want
> doCheckec2EndpointUrl(@QueryParameter String EndpointUrl, @QueryParameter String accessId, @QueryParameter String secretKey) {
> ...
> }

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (HUDSON-5610) be able to do 'doCheckXXX' for forms with multiple parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

kohsuke resolved HUDSON-5610.
-----------------------------

    Resolution: Fixed

I believe it was caused by the failed stapler release and is now fixed.

> be able to do 'doCheckXXX' for forms with multiple parameters
> -------------------------------------------------------------
>
>                 Key: HUDSON-5610
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-5610
>             Project: Hudson
>          Issue Type: Improvement
>            Reporter: lifeless
>            Assignee: kohsuke
>
> E.g. in the EC2 plugin the 'endpoint url' field can only be reliably validated using the accesskey and secretkey, so we would want
> doCheckec2EndpointUrl(@QueryParameter String EndpointUrl, @QueryParameter String accessId, @QueryParameter String secretKey) {
> ...
> }

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]