[JIRA] Created: (HUDSON-6262) Fix restarting of Slave nodes with HTTP auth.

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (HUDSON-6262) Fix restarting of Slave nodes with HTTP auth.

Hudson issues mailing list
Fix restarting of Slave nodes with HTTP auth.
----------------------------------------------

                 Key: HUDSON-6262
                 URL: http://issues.hudson-ci.org/browse/HUDSON-6262
             Project: Hudson
          Issue Type: Bug
          Components: core
    Affects Versions: current
            Reporter: dmitry_nezhevenko
            Priority: Minor
             Fix For: current
         Attachments: remoting_cleanup.diff

Hi,

We're using Hudson with HTTP-based authentication. There are a few master->slave related issues:
- Code that waits for slave node has no timeouts...
- Due to HTTP auth, slave node will never restart since server will return 401.
- Connection is never closed (resources leak).

I'm attaching patch that fixed all of these issues here.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (HUDSON-6262) Fix restarting of Slave nodes with HTTP auth.

Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

mindless updated HUDSON-6262:
-----------------------------

    Issue Type: Patch  (was: Bug)
      Assignee: kohsuke

Looks pretty good to me.. maybe a little longer on the timeout.
I'll assign to Kohsuke for final review and to commit.  Thanks!


> Fix restarting of Slave nodes with HTTP auth.
> ----------------------------------------------
>
>                 Key: HUDSON-6262
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6262
>             Project: Hudson
>          Issue Type: Patch
>          Components: core
>    Affects Versions: current
>            Reporter: dmitry_nezhevenko
>            Assignee: kohsuke
>            Priority: Minor
>             Fix For: current
>
>         Attachments: remoting_cleanup.diff
>
>
> Hi,
> We're using Hudson with HTTP-based authentication. There are a few master->slave related issues:
> - Code that waits for slave node has no timeouts...
> - Due to HTTP auth, slave node will never restart since server will return 401.
> - Connection is never closed (resources leak).
> I'm attaching patch that fixed all of these issues here.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6262) Fix restarting of Slave nodes with HTTP auth.

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139035#action_139035 ]

scm_issue_link commented on HUDSON-6262:
----------------------------------------

Code changed in hudson
User: : kohsuke
Path:
 trunk/hudson/main/remoting/src/main/java/hudson/remoting/Engine.java
 trunk/www/changelog.html
http://hudson-ci.org/commit/31576
Log:
[FIXED HUDSON-6262] HTTP auth support was added in HUDSON-4071, so I've only integrated the portion that specifies the timeout and a call to disconnect(). Will be in 1.361.


> Fix restarting of Slave nodes with HTTP auth.
> ----------------------------------------------
>
>                 Key: HUDSON-6262
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6262
>             Project: Hudson
>          Issue Type: Patch
>          Components: core
>    Affects Versions: current
>            Reporter: dmitry_nezhevenko
>            Assignee: kohsuke
>            Priority: Minor
>             Fix For: current
>
>         Attachments: remoting_cleanup.diff
>
>
> Hi,
> We're using Hudson with HTTP-based authentication. There are a few master->slave related issues:
> - Code that waits for slave node has no timeouts...
> - Due to HTTP auth, slave node will never restart since server will return 401.
> - Connection is never closed (resources leak).
> I'm attaching patch that fixed all of these issues here.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6262) Fix restarting of Slave nodes with HTTP auth.

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139062#action_139062 ]

scm_issue_link commented on HUDSON-6262:
----------------------------------------

Code changed in hudson
User: : StevenGBrown
Path:
 trunk/hudson/main/core/src/main/java/hudson/model/FileParameterDefinition.java
 trunk/www/changelog.html
http://hudson-ci.org/commit/31582
Log:
[FIXED HUDSON-6262] File parameter builds started with the CLI command no longer throw an NPE.


> Fix restarting of Slave nodes with HTTP auth.
> ----------------------------------------------
>
>                 Key: HUDSON-6262
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6262
>             Project: Hudson
>          Issue Type: Patch
>          Components: core
>    Affects Versions: current
>            Reporter: dmitry_nezhevenko
>            Assignee: kohsuke
>            Priority: Minor
>             Fix For: current
>
>         Attachments: remoting_cleanup.diff
>
>
> Hi,
> We're using Hudson with HTTP-based authentication. There are a few master->slave related issues:
> - Code that waits for slave node has no timeouts...
> - Due to HTTP auth, slave node will never restart since server will return 401.
> - Connection is never closed (resources leak).
> I'm attaching patch that fixed all of these issues here.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (HUDSON-6262) Fix restarting of Slave nodes with HTTP auth.

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

scm_issue_link resolved HUDSON-6262.
------------------------------------

    Resolution: Fixed

> Fix restarting of Slave nodes with HTTP auth.
> ----------------------------------------------
>
>                 Key: HUDSON-6262
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6262
>             Project: Hudson
>          Issue Type: Patch
>          Components: core
>    Affects Versions: current
>            Reporter: dmitry_nezhevenko
>            Assignee: kohsuke
>            Priority: Minor
>             Fix For: current
>
>         Attachments: remoting_cleanup.diff
>
>
> Hi,
> We're using Hudson with HTTP-based authentication. There are a few master->slave related issues:
> - Code that waits for slave node has no timeouts...
> - Due to HTTP auth, slave node will never restart since server will return 401.
> - Connection is never closed (resources leak).
> I'm attaching patch that fixed all of these issues here.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6262) Fix restarting of Slave nodes with HTTP auth.

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139131#action_139131 ]

StevenGBrown commented on HUDSON-6262:
--------------------------------------

Please ignore the previous comment - it was meant for HUDSON-4296.

> Fix restarting of Slave nodes with HTTP auth.
> ----------------------------------------------
>
>                 Key: HUDSON-6262
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6262
>             Project: Hudson
>          Issue Type: Patch
>          Components: core
>    Affects Versions: current
>            Reporter: dmitry_nezhevenko
>            Assignee: kohsuke
>            Priority: Minor
>             Fix For: current
>
>         Attachments: remoting_cleanup.diff
>
>
> Hi,
> We're using Hudson with HTTP-based authentication. There are a few master->slave related issues:
> - Code that waits for slave node has no timeouts...
> - Due to HTTP auth, slave node will never restart since server will return 401.
> - Connection is never closed (resources leak).
> I'm attaching patch that fixed all of these issues here.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]