[JIRA] Created: (HUDSON-6394) Email recipients should support use of build parameters

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (HUDSON-6394) Email recipients should support use of build parameters

Hudson issues mailing list
Email recipients should support use of build parameters
-------------------------------------------------------

                 Key: HUDSON-6394
                 URL: http://issues.hudson-ci.org/browse/HUDSON-6394
             Project: Hudson
          Issue Type: Bug
          Components: core
            Reporter: abayer
            Priority: Minor


The recipients list for email notification should support parameter expansion.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (HUDSON-6394) Email recipients should support use of build parameters

Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

scm_issue_link resolved HUDSON-6394.
------------------------------------

    Resolution: Fixed

> Email recipients should support use of build parameters
> -------------------------------------------------------
>
>                 Key: HUDSON-6394
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6394
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>            Reporter: abayer
>            Priority: Minor
>
> The recipients list for email notification should support parameter expansion.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6394) Email recipients should support use of build parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138226#action_138226 ]

scm_issue_link commented on HUDSON-6394:
----------------------------------------

Code changed in hudson
User: : abayer
Path:
 trunk/hudson/main/core/src/main/java/hudson/tasks/Mailer.java
http://hudson-ci.org/commit/30485
Log:
[FIXED HUDSON-6394] Email recipient lists now support build parameters


> Email recipients should support use of build parameters
> -------------------------------------------------------
>
>                 Key: HUDSON-6394
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6394
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>            Reporter: abayer
>            Priority: Minor
>
> The recipients list for email notification should support parameter expansion.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Reopened: (HUDSON-6394) Email recipients should support use of build parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

mwebber reopened HUDSON-6394:
-----------------------------

      Assignee: abayer

This does not appear to work (tested in 1.361). Either I've misunderstood the feature, or it's broken.
 
On the main Hudson configuration page, I defined an environment variable HUDSON_EMAILS_FOR_GDA_ADMINISTRATOR and an associated value.
In the configuration for a specific job, I specified an email recipient list of ${HUDSON_EMAILS_FOR_GDA_ADMINISTRATOR}. This is the standard Hudson email, not the extended email plugin.
 
When the job fails and tries to send an email, I get
com.sun.mail.smtp.SMTPAddressFailedException: 550 5.1.1 <${HUDSON_EMAILS_FOR_GDA_ADMINISTRATOR}>... User unknown
 
I displayed the value of the environment variable in one of the build steps, and it is set correctly.

> Email recipients should support use of build parameters
> -------------------------------------------------------
>
>                 Key: HUDSON-6394
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6394
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>            Reporter: abayer
>            Assignee: abayer
>            Priority: Minor
>
> The recipients list for email notification should support parameter expansion.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6394) Email recipients should support use of build parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=140329#action_140329 ]

mindless commented on HUDSON-6394:
----------------------------------

From the commit above, it looks like it was implemented to only evaluate against parameters specifically for that build.. so your global env var is not used.
abayer, could this be changed to get the EnvVars from build.getEnvironment and call env.expand() instead?

> Email recipients should support use of build parameters
> -------------------------------------------------------
>
>                 Key: HUDSON-6394
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6394
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>            Reporter: abayer
>            Assignee: abayer
>            Priority: Minor
>
> The recipients list for email notification should support parameter expansion.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Assigned: (HUDSON-6394) Email recipients should support use of build parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

mindless reassigned HUDSON-6394:
--------------------------------

    Assignee: mindless  (was: abayer)

> Email recipients should support use of build parameters
> -------------------------------------------------------
>
>                 Key: HUDSON-6394
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6394
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>            Reporter: abayer
>            Assignee: mindless
>            Priority: Minor
>
> The recipients list for email notification should support parameter expansion.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6394) Email recipients should support use of build parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=140334#action_140334 ]

scm_issue_link commented on HUDSON-6394:
----------------------------------------

Code changed in hudson
User: : mindless
Path:
 trunk/hudson/main/core/src/main/java/hudson/tasks/Mailer.java
 trunk/hudson/main/core/src/main/resources/hudson/tasks/Mailer/config.properties
http://hudson-ci.org/commit/33098
Log:
[FIXED HUDSON-6394] use EnvVars to expand parameters in recipient list
(not just ParametersAction), don't overwrite the field in this object (!)
when parameters are expanded, and note that parameters are supported in
the help text.
Also correct the help text that mentions when email is sent.


> Email recipients should support use of build parameters
> -------------------------------------------------------
>
>                 Key: HUDSON-6394
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6394
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>            Reporter: abayer
>            Assignee: mindless
>            Priority: Minor
>
> The recipients list for email notification should support parameter expansion.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (HUDSON-6394) Email recipients should support use of build parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

scm_issue_link resolved HUDSON-6394.
------------------------------------

    Resolution: Fixed

> Email recipients should support use of build parameters
> -------------------------------------------------------
>
>                 Key: HUDSON-6394
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6394
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>            Reporter: abayer
>            Assignee: mindless
>            Priority: Minor
>
> The recipients list for email notification should support parameter expansion.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Reopened: (HUDSON-6394) Email recipients should support use of build parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

mwebber reopened HUDSON-6394:
-----------------------------


This still fails for me, exactly as per my comment of 7/Jun/2010 - The failure is with Hudson 1.368 and email-ext 2.6.
For a recipient list that contains a $ENVVAR, the substitution is not performed - I tried with both core email, and extended email plugin.

> Email recipients should support use of build parameters
> -------------------------------------------------------
>
>                 Key: HUDSON-6394
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6394
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>            Reporter: abayer
>            Assignee: mindless
>            Priority: Minor
>
> The recipients list for email notification should support parameter expansion.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (HUDSON-6394) Email recipients should support use of build parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

mwebber updated HUDSON-6394:
----------------------------

    Priority: Major  (was: Minor)

I'm bumping the priority simply because of the various unsuccessful attempts to fix this. If someone has time to take a look at it, and test any fix, that would be great.

> Email recipients should support use of build parameters
> -------------------------------------------------------
>
>                 Key: HUDSON-6394
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6394
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>            Reporter: abayer
>            Assignee: mindless
>
> The recipients list for email notification should support parameter expansion.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6394) Email recipients should support use of build parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=140496#action_140496 ]

mindless commented on HUDSON-6394:
----------------------------------

Hm, looks like global env vars are part of build.getEnvironment() during the build steps but not there in the post-build steps.  Digging further..

> Email recipients should support use of build parameters
> -------------------------------------------------------
>
>                 Key: HUDSON-6394
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6394
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>            Reporter: abayer
>            Assignee: mindless
>
> The recipients list for email notification should support parameter expansion.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (HUDSON-6394) Email recipients should support use of build parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

mindless resolved HUDSON-6394.
------------------------------

    Resolution: Fixed

yes, this is the way buildEnvironments is written.

I'm reclosing this issue.  Can you open a new improvement request asking for global environment variables to be made available to post-build actions?  Thanks.

> Email recipients should support use of build parameters
> -------------------------------------------------------
>
>                 Key: HUDSON-6394
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6394
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>            Reporter: abayer
>            Assignee: mindless
>
> The recipients list for email notification should support parameter expansion.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6394) Email recipients should support use of build parameters

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=140510#action_140510 ]

mwebber commented on HUDSON-6394:
---------------------------------

A new improvement request has been opened (HUDSON-7075), as requested.

> Email recipients should support use of build parameters
> -------------------------------------------------------
>
>                 Key: HUDSON-6394
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6394
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>            Reporter: abayer
>            Assignee: mindless
>
> The recipients list for email notification should support parameter expansion.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]