[JIRA] Created: (HUDSON-6484) ircbot sends command output to wrong irc user

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (HUDSON-6484) ircbot sends command output to wrong irc user

Hudson issues mailing list
ircbot sends command output to wrong irc user
---------------------------------------------

                 Key: HUDSON-6484
                 URL: http://issues.hudson-ci.org/browse/HUDSON-6484
             Project: Hudson
          Issue Type: Bug
          Components: ircbot
    Affects Versions: current
         Environment: rhel 5.3 64-bit
            Reporter: philsttr
            Assignee: kutzi


Sometimes the irc bot sends command output to the wrong irc user.

For example, if I send the hudson bot the command "!help"  (with ! being the command prefix), sometimes I get the output.

But then, if another irc user sends the hudson bot the command "!help", then that other user might get the output, or I might get the output (incorrectly).  I haven't been able to identify a pattern to when hudson gets it correct, versus incorrect.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (HUDSON-6484) ircbot sends command output to wrong irc user

Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

philsttr updated HUDSON-6484:
-----------------------------

    Environment:
rhel 5.3 64-bit
hudson 1.351
im plugin 1.7
irc plugin 2.3


  was:rhel 5.3 64-bit


> ircbot sends command output to wrong irc user
> ---------------------------------------------
>
>                 Key: HUDSON-6484
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6484
>             Project: Hudson
>          Issue Type: Bug
>          Components: ircbot
>    Affects Versions: current
>         Environment: rhel 5.3 64-bit
> hudson 1.351
> im plugin 1.7
> irc plugin 2.3
>            Reporter: philsttr
>            Assignee: kutzi
>
> Sometimes the irc bot sends command output to the wrong irc user.
> For example, if I send the hudson bot the command "!help"  (with ! being the command prefix), sometimes I get the output.
> But then, if another irc user sends the hudson bot the command "!help", then that other user might get the output, or I might get the output (incorrectly).  I haven't been able to identify a pattern to when hudson gets it correct, versus incorrect.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6484) ircbot sends command output to wrong irc user

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138513#action_138513 ]

kutzi commented on HUDSON-6484:
-------------------------------

Do you and the other user send the command at the same time?
Otherwise, I couldn't imagine how this could happen.

> ircbot sends command output to wrong irc user
> ---------------------------------------------
>
>                 Key: HUDSON-6484
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6484
>             Project: Hudson
>          Issue Type: Bug
>          Components: ircbot
>    Affects Versions: current
>         Environment: rhel 5.3 64-bit
> hudson 1.351
> im plugin 1.7
> irc plugin 2.3
>            Reporter: philsttr
>            Assignee: kutzi
>
> Sometimes the irc bot sends command output to the wrong irc user.
> For example, if I send the hudson bot the command "!help"  (with ! being the command prefix), sometimes I get the output.
> But then, if another irc user sends the hudson bot the command "!help", then that other user might get the output, or I might get the output (incorrectly).  I haven't been able to identify a pattern to when hudson gets it correct, versus incorrect.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6484) ircbot sends command output to wrong irc user

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138517#action_138517 ]

scm_issue_link commented on HUDSON-6484:
----------------------------------------

Code changed in hudson
User: : kutzi
Path:
 trunk/hudson/plugins/ircbot/src/main/java/hudson/plugins/ircbot/v2/PircConnection.java
http://hudson-ci.org/commit/30884
Log:
destroy input- and output-thread on disconnect. This could possibly fix HUDSON-6484


> ircbot sends command output to wrong irc user
> ---------------------------------------------
>
>                 Key: HUDSON-6484
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6484
>             Project: Hudson
>          Issue Type: Bug
>          Components: ircbot
>    Affects Versions: current
>         Environment: rhel 5.3 64-bit
> hudson 1.351
> im plugin 1.7
> irc plugin 2.3
>            Reporter: philsttr
>            Assignee: kutzi
>
> Sometimes the irc bot sends command output to the wrong irc user.
> For example, if I send the hudson bot the command "!help"  (with ! being the command prefix), sometimes I get the output.
> But then, if another irc user sends the hudson bot the command "!help", then that other user might get the output, or I might get the output (incorrectly).  I haven't been able to identify a pattern to when hudson gets it correct, versus incorrect.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6484) ircbot sends command output to wrong irc user

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138522#action_138522 ]

philsttr commented on HUDSON-6484:
----------------------------------

No, usually it's not at the same time.  Sometimes 30 mins will pass.

For example, I will have issued a command, received my output, and closed my message window.   Then 30 mins later, somebody else would message hudson, and then my message window will pop back up containing his output.

> ircbot sends command output to wrong irc user
> ---------------------------------------------
>
>                 Key: HUDSON-6484
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6484
>             Project: Hudson
>          Issue Type: Bug
>          Components: ircbot
>    Affects Versions: current
>         Environment: rhel 5.3 64-bit
> hudson 1.351
> im plugin 1.7
> irc plugin 2.3
>            Reporter: philsttr
>            Assignee: kutzi
>
> Sometimes the irc bot sends command output to the wrong irc user.
> For example, if I send the hudson bot the command "!help"  (with ! being the command prefix), sometimes I get the output.
> But then, if another irc user sends the hudson bot the command "!help", then that other user might get the output, or I might get the output (incorrectly).  I haven't been able to identify a pattern to when hudson gets it correct, versus incorrect.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6484) ircbot sends command output to wrong irc user

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138532#action_138532 ]

kutzi commented on HUDSON-6484:
-------------------------------

Where do you issue the command to the bot? In a chatroom or as a private message?

When you get the output from the other user, does the other user also get the ouptut - i.e. is is duplicated - or do only you get the
output?

> ircbot sends command output to wrong irc user
> ---------------------------------------------
>
>                 Key: HUDSON-6484
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6484
>             Project: Hudson
>          Issue Type: Bug
>          Components: ircbot
>    Affects Versions: current
>         Environment: rhel 5.3 64-bit
> hudson 1.351
> im plugin 1.7
> irc plugin 2.3
>            Reporter: philsttr
>            Assignee: kutzi
>
> Sometimes the irc bot sends command output to the wrong irc user.
> For example, if I send the hudson bot the command "!help"  (with ! being the command prefix), sometimes I get the output.
> But then, if another irc user sends the hudson bot the command "!help", then that other user might get the output, or I might get the output (incorrectly).  I haven't been able to identify a pattern to when hudson gets it correct, versus incorrect.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6484) ircbot sends command output to wrong irc user

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138539#action_138539 ]

philsttr commented on HUDSON-6484:
----------------------------------

Both people initiated the commands in a private message to the bot.

The output is not duplicated.  It only goes to one person.

> ircbot sends command output to wrong irc user
> ---------------------------------------------
>
>                 Key: HUDSON-6484
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6484
>             Project: Hudson
>          Issue Type: Bug
>          Components: ircbot
>    Affects Versions: current
>         Environment: rhel 5.3 64-bit
> hudson 1.351
> im plugin 1.7
> irc plugin 2.3
>            Reporter: philsttr
>            Assignee: kutzi
>
> Sometimes the irc bot sends command output to the wrong irc user.
> For example, if I send the hudson bot the command "!help"  (with ! being the command prefix), sometimes I get the output.
> But then, if another irc user sends the hudson bot the command "!help", then that other user might get the output, or I might get the output (incorrectly).  I haven't been able to identify a pattern to when hudson gets it correct, versus incorrect.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6484) ircbot sends command output to wrong irc user

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138561#action_138561 ]

kutzi commented on HUDSON-6484:
-------------------------------

Can you try to issue some invalid commands - e.g. !status invalidjobname - and see what the bot sends as reply in case the output goes to the wrong user.
It should ouptut:
"<sender>: unknown job 'invalidjobname'"

> ircbot sends command output to wrong irc user
> ---------------------------------------------
>
>                 Key: HUDSON-6484
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6484
>             Project: Hudson
>          Issue Type: Bug
>          Components: ircbot
>    Affects Versions: current
>         Environment: rhel 5.3 64-bit
> hudson 1.351
> im plugin 1.7
> irc plugin 2.3
>            Reporter: philsttr
>            Assignee: kutzi
>
> Sometimes the irc bot sends command output to the wrong irc user.
> For example, if I send the hudson bot the command "!help"  (with ! being the command prefix), sometimes I get the output.
> But then, if another irc user sends the hudson bot the command "!help", then that other user might get the output, or I might get the output (incorrectly).  I haven't been able to identify a pattern to when hudson gets it correct, versus incorrect.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6484) ircbot sends command output to wrong irc user

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138565#action_138565 ]

scm_issue_link commented on HUDSON-6484:
----------------------------------------

Code changed in hudson
User: : kutzi
Path:
 trunk/hudson/plugins/ircbot/src/main/java/hudson/plugins/ircbot/v2/IRCConnection.java
 trunk/hudson/plugins/ircbot/src/main/java/hudson/plugins/ircbot/v2/IRCPrivateChat.java
 trunk/hudson/plugins/ircbot/src/main/java/hudson/plugins/ircbot/v2/PircConnection.java
http://hudson-ci.org/commit/30950
Log:
[FIXED HUDSON-6484] ircbot command output send to wrong user


> ircbot sends command output to wrong irc user
> ---------------------------------------------
>
>                 Key: HUDSON-6484
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6484
>             Project: Hudson
>          Issue Type: Bug
>          Components: ircbot
>    Affects Versions: current
>         Environment: rhel 5.3 64-bit
> hudson 1.351
> im plugin 1.7
> irc plugin 2.3
>            Reporter: philsttr
>            Assignee: kutzi
>
> Sometimes the irc bot sends command output to the wrong irc user.
> For example, if I send the hudson bot the command "!help"  (with ! being the command prefix), sometimes I get the output.
> But then, if another irc user sends the hudson bot the command "!help", then that other user might get the output, or I might get the output (incorrectly).  I haven't been able to identify a pattern to when hudson gets it correct, versus incorrect.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (HUDSON-6484) ircbot sends command output to wrong irc user

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

scm_issue_link resolved HUDSON-6484.
------------------------------------

    Resolution: Fixed

> ircbot sends command output to wrong irc user
> ---------------------------------------------
>
>                 Key: HUDSON-6484
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6484
>             Project: Hudson
>          Issue Type: Bug
>          Components: ircbot
>    Affects Versions: current
>         Environment: rhel 5.3 64-bit
> hudson 1.351
> im plugin 1.7
> irc plugin 2.3
>            Reporter: philsttr
>            Assignee: kutzi
>
> Sometimes the irc bot sends command output to the wrong irc user.
> For example, if I send the hudson bot the command "!help"  (with ! being the command prefix), sometimes I get the output.
> But then, if another irc user sends the hudson bot the command "!help", then that other user might get the output, or I might get the output (incorrectly).  I haven't been able to identify a pattern to when hudson gets it correct, versus incorrect.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (HUDSON-6484) ircbot sends command output to wrong irc user

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

kutzi updated HUDSON-6484:
--------------------------

    Attachment: ircbot.hpi

Yeah, I think I've found the bug. Seems that this was broken from the beginning, so thanks for pointing this out.

It would be great if you could test that the attached snapshot build fixes your problem.

> ircbot sends command output to wrong irc user
> ---------------------------------------------
>
>                 Key: HUDSON-6484
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6484
>             Project: Hudson
>          Issue Type: Bug
>          Components: ircbot
>    Affects Versions: current
>         Environment: rhel 5.3 64-bit
> hudson 1.351
> im plugin 1.7
> irc plugin 2.3
>            Reporter: philsttr
>            Assignee: kutzi
>         Attachments: ircbot.hpi
>
>
> Sometimes the irc bot sends command output to the wrong irc user.
> For example, if I send the hudson bot the command "!help"  (with ! being the command prefix), sometimes I get the output.
> But then, if another irc user sends the hudson bot the command "!help", then that other user might get the output, or I might get the output (incorrectly).  I haven't been able to identify a pattern to when hudson gets it correct, versus incorrect.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6484) ircbot sends command output to wrong irc user

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138653#action_138653 ]

philsttr commented on HUDSON-6484:
----------------------------------

Finally got a chance to try this.  It looks like build you provided is working now.  Thanks!

> ircbot sends command output to wrong irc user
> ---------------------------------------------
>
>                 Key: HUDSON-6484
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6484
>             Project: Hudson
>          Issue Type: Bug
>          Components: ircbot
>    Affects Versions: current
>         Environment: rhel 5.3 64-bit
> hudson 1.351
> im plugin 1.7
> irc plugin 2.3
>            Reporter: philsttr
>            Assignee: kutzi
>         Attachments: ircbot.hpi
>
>
> Sometimes the irc bot sends command output to the wrong irc user.
> For example, if I send the hudson bot the command "!help"  (with ! being the command prefix), sometimes I get the output.
> But then, if another irc user sends the hudson bot the command "!help", then that other user might get the output, or I might get the output (incorrectly).  I haven't been able to identify a pattern to when hudson gets it correct, versus incorrect.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Closed: (HUDSON-6484) ircbot sends command output to wrong irc user

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

kutzi closed HUDSON-6484.
-------------------------


> ircbot sends command output to wrong irc user
> ---------------------------------------------
>
>                 Key: HUDSON-6484
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6484
>             Project: Hudson
>          Issue Type: Bug
>          Components: ircbot
>    Affects Versions: current
>         Environment: rhel 5.3 64-bit
> hudson 1.351
> im plugin 1.7
> irc plugin 2.3
>            Reporter: philsttr
>            Assignee: kutzi
>         Attachments: ircbot.hpi
>
>
> Sometimes the irc bot sends command output to the wrong irc user.
> For example, if I send the hudson bot the command "!help"  (with ! being the command prefix), sometimes I get the output.
> But then, if another irc user sends the hudson bot the command "!help", then that other user might get the output, or I might get the output (incorrectly).  I haven't been able to identify a pattern to when hudson gets it correct, versus incorrect.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]