[JIRA] Created: (HUDSON-6504) Make hudson.remoting.PreloadJarTask public

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (HUDSON-6504) Make hudson.remoting.PreloadJarTask public

Hudson issues mailing list
Make hudson.remoting.PreloadJarTask public
------------------------------------------

                 Key: HUDSON-6504
                 URL: http://issues.hudson-ci.org/browse/HUDSON-6504
             Project: Hudson
          Issue Type: Bug
          Components: core
    Affects Versions: current
            Reporter: mdillon
            Priority: Trivial


The hudson.remoting.PreloadJarTask class is currently package private, so the only practical way to preload JARs is the Channel.preload(ClassLoader loader, Class... classesInJar) method. I'd like to be able to preload JARs based on a service provider mechanism, using a well-known resource under META-INF to identify the JARs to ship to the slaves.

Is there any harm in simply making PreloadJarTask public? To move forward on my project, I'm planning to make my own local copy of PreloadJarTask so that I can instantiate it directly with my own *.jar URL array, but it would be great if I could just use the built-in one at some point.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6504) Make hudson.remoting.PreloadJarTask public

Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138570#action_138570 ]

mdillon commented on HUDSON-6504:
---------------------------------

Looks like my workaround won't work either, since my code won't because RemoteClassLoader is also package-private. New approach will be to instantiate the built-in PreloadJarTask using reflection...

> Make hudson.remoting.PreloadJarTask public
> ------------------------------------------
>
>                 Key: HUDSON-6504
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6504
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: mdillon
>            Priority: Trivial
>
> The hudson.remoting.PreloadJarTask class is currently package private, so the only practical way to preload JARs is the Channel.preload(ClassLoader loader, Class... classesInJar) method. I'd like to be able to preload JARs based on a service provider mechanism, using a well-known resource under META-INF to identify the JARs to ship to the slaves.
> Is there any harm in simply making PreloadJarTask public? To move forward on my project, I'm planning to make my own local copy of PreloadJarTask so that I can instantiate it directly with my own *.jar URL array, but it would be great if I could just use the built-in one at some point.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6504) Make hudson.remoting.PreloadJarTask public

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138786#action_138786 ]

mdillon commented on HUDSON-6504:
---------------------------------

Does anyone know of any reason that this change shouldn't be made? Seems like it should be pretty uncontroversial to me, but I'd like to get a nod before I try to either commit the change or get it committed.

> Make hudson.remoting.PreloadJarTask public
> ------------------------------------------
>
>                 Key: HUDSON-6504
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6504
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: mdillon
>            Priority: Trivial
>
> The hudson.remoting.PreloadJarTask class is currently package private, so the only practical way to preload JARs is the Channel.preload(ClassLoader loader, Class... classesInJar) method. I'd like to be able to preload JARs based on a service provider mechanism, using a well-known resource under META-INF to identify the JARs to ship to the slaves.
> Is there any harm in simply making PreloadJarTask public? To move forward on my project, I'm planning to make my own local copy of PreloadJarTask so that I can instantiate it directly with my own *.jar URL array, but it would be great if I could just use the built-in one at some point.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Assigned: (HUDSON-6504) Make hudson.remoting.PreloadJarTask public

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

abayer reassigned HUDSON-6504:
------------------------------

    Assignee: abayer

> Make hudson.remoting.PreloadJarTask public
> ------------------------------------------
>
>                 Key: HUDSON-6504
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6504
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: mdillon
>            Assignee: abayer
>            Priority: Trivial
>
> The hudson.remoting.PreloadJarTask class is currently package private, so the only practical way to preload JARs is the Channel.preload(ClassLoader loader, Class... classesInJar) method. I'd like to be able to preload JARs based on a service provider mechanism, using a well-known resource under META-INF to identify the JARs to ship to the slaves.
> Is there any harm in simply making PreloadJarTask public? To move forward on my project, I'm planning to make my own local copy of PreloadJarTask so that I can instantiate it directly with my own *.jar URL array, but it would be great if I could just use the built-in one at some point.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6504) Make hudson.remoting.PreloadJarTask public

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139321#action_139321 ]

abayer commented on HUDSON-6504:
--------------------------------

Can't see a problem with this - should be in place for 1.362 (possibly 1.363 depending on when I get this committed).

> Make hudson.remoting.PreloadJarTask public
> ------------------------------------------
>
>                 Key: HUDSON-6504
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6504
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: mdillon
>            Assignee: abayer
>            Priority: Trivial
>
> The hudson.remoting.PreloadJarTask class is currently package private, so the only practical way to preload JARs is the Channel.preload(ClassLoader loader, Class... classesInJar) method. I'd like to be able to preload JARs based on a service provider mechanism, using a well-known resource under META-INF to identify the JARs to ship to the slaves.
> Is there any harm in simply making PreloadJarTask public? To move forward on my project, I'm planning to make my own local copy of PreloadJarTask so that I can instantiate it directly with my own *.jar URL array, but it would be great if I could just use the built-in one at some point.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (HUDSON-6504) Make hudson.remoting.PreloadJarTask public

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

scm_issue_link resolved HUDSON-6504.
------------------------------------

    Resolution: Fixed

> Make hudson.remoting.PreloadJarTask public
> ------------------------------------------
>
>                 Key: HUDSON-6504
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6504
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: mdillon
>            Assignee: abayer
>            Priority: Trivial
>
> The hudson.remoting.PreloadJarTask class is currently package private, so the only practical way to preload JARs is the Channel.preload(ClassLoader loader, Class... classesInJar) method. I'd like to be able to preload JARs based on a service provider mechanism, using a well-known resource under META-INF to identify the JARs to ship to the slaves.
> Is there any harm in simply making PreloadJarTask public? To move forward on my project, I'm planning to make my own local copy of PreloadJarTask so that I can instantiate it directly with my own *.jar URL array, but it would be great if I could just use the built-in one at some point.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6504) Make hudson.remoting.PreloadJarTask public

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139322#action_139322 ]

scm_issue_link commented on HUDSON-6504:
----------------------------------------

Code changed in hudson
User: : abayer
Path:
 trunk/hudson/main/remoting/src/main/java/hudson/remoting/PreloadJarTask.java
 trunk/www/changelog.html
http://hudson-ci.org/commit/31872
Log:
[FIXED HUDSON-6504] Made hudson.remoting.PreloadJarTask public


> Make hudson.remoting.PreloadJarTask public
> ------------------------------------------
>
>                 Key: HUDSON-6504
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6504
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: mdillon
>            Assignee: abayer
>            Priority: Trivial
>
> The hudson.remoting.PreloadJarTask class is currently package private, so the only practical way to preload JARs is the Channel.preload(ClassLoader loader, Class... classesInJar) method. I'd like to be able to preload JARs based on a service provider mechanism, using a well-known resource under META-INF to identify the JARs to ship to the slaves.
> Is there any harm in simply making PreloadJarTask public? To move forward on my project, I'm planning to make my own local copy of PreloadJarTask so that I can instantiate it directly with my own *.jar URL array, but it would be great if I could just use the built-in one at some point.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6504) Make hudson.remoting.PreloadJarTask public

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139323#action_139323 ]

scm_issue_link commented on HUDSON-6504:
----------------------------------------

Code changed in hudson
User: : kohsuke
Path:
 trunk/hudson/main/remoting/src/main/java/hudson/remoting/Channel.java
 trunk/hudson/main/remoting/src/main/java/hudson/remoting/PreloadJarTask.java
 trunk/www/changelog.html
http://hudson-ci.org/commit/31874
Log:
[HUDSON-6504] a better approach is to define another overloaded version of the preload method that takes URLs of the jars.


> Make hudson.remoting.PreloadJarTask public
> ------------------------------------------
>
>                 Key: HUDSON-6504
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6504
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: mdillon
>            Assignee: abayer
>            Priority: Trivial
>
> The hudson.remoting.PreloadJarTask class is currently package private, so the only practical way to preload JARs is the Channel.preload(ClassLoader loader, Class... classesInJar) method. I'd like to be able to preload JARs based on a service provider mechanism, using a well-known resource under META-INF to identify the JARs to ship to the slaves.
> Is there any harm in simply making PreloadJarTask public? To move forward on my project, I'm planning to make my own local copy of PreloadJarTask so that I can instantiate it directly with my own *.jar URL array, but it would be great if I could just use the built-in one at some point.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]