[JIRA] Created: (HUDSON-6587) Allow CLI Container Managed Authentication

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (HUDSON-6587) Allow CLI Container Managed Authentication

Hudson issues mailing list
Allow CLI Container Managed Authentication
------------------------------------------

                 Key: HUDSON-6587
                 URL: http://issues.hudson-ci.org/browse/HUDSON-6587
             Project: Hudson
          Issue Type: Improvement
          Components: cli
    Affects Versions: current
         Environment: Platform: All, OS: All
            Reporter: jpederzolli


Currently there is no way to supply Hudson credentials to hudson-cli, making it
unusable to those who do not allow anonymous access to Hudson.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (HUDSON-6587) Allow CLI Container Managed Authentication

Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jpederzolli updated HUDSON-6587:
--------------------------------

     Issue Type: Bug  (was: Improvement)
    Description:
After the changes in HUDSON-3796, container managed authentication no longer works for CLI.

Make the necessary changes to maintain the extensibility provided in HUDSON-3796, but also allow container based auth.

  was:
Currently there is no way to supply Hudson credentials to hudson-cli, making it
unusable to those who do not allow anonymous access to Hudson.


> Allow CLI Container Managed Authentication
> ------------------------------------------
>
>                 Key: HUDSON-6587
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6587
>             Project: Hudson
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: current
>         Environment: Platform: All, OS: All
>            Reporter: jpederzolli
>
> After the changes in HUDSON-3796, container managed authentication no longer works for CLI.
> Make the necessary changes to maintain the extensibility provided in HUDSON-3796, but also allow container based auth.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (HUDSON-6587) Allow CLI Container Managed Authentication

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jpederzolli updated HUDSON-6587:
--------------------------------

         Assignee: jpederzolli
    Fix Version/s: current

> Allow CLI Container Managed Authentication
> ------------------------------------------
>
>                 Key: HUDSON-6587
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6587
>             Project: Hudson
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: current
>         Environment: Platform: All, OS: All
>            Reporter: jpederzolli
>            Assignee: jpederzolli
>
> After the changes in HUDSON-3796, container managed authentication no longer works for CLI.
> Make the necessary changes to maintain the extensibility provided in HUDSON-3796, but also allow container based auth.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (HUDSON-6587) Allow CLI Container Managed Authentication

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jpederzolli updated HUDSON-6587:
--------------------------------

    Fix Version/s:     (was: current)

> Allow CLI Container Managed Authentication
> ------------------------------------------
>
>                 Key: HUDSON-6587
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6587
>             Project: Hudson
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: current
>         Environment: Platform: All, OS: All
>            Reporter: jpederzolli
>            Assignee: jpederzolli
>
> After the changes in HUDSON-3796, container managed authentication no longer works for CLI.
> Make the necessary changes to maintain the extensibility provided in HUDSON-3796, but also allow container based auth.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6587) Allow CLI Container Managed Authentication

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138747#action_138747 ]

jpederzolli commented on HUDSON-6587:
-------------------------------------

The reason for this issue is the following:

The changes in HUDSON-3796 removed the passing of the Authentication object to the CliManagerImpl and made the CLI authentication more extensible. The one problem with it is that you need the Authentication to be passed into the CliManagerImpl class if one is using the LegacySecurityRealm (i.e. container auth). Without this issue being fixed, the CLI user will always be 'anonymous' if container based authentication is relied upon.

A summary of the changes:

1) Restore CliManager constructor to take an Authentication object which in turn will be passed on to the CLICommand implementation.
2) Create an overloaded createCliAuthenticator method in SecurityRealm which takes an Authentication object
3) Let it be up to the SecurityRealm implementation if createCliAuthenticator will consider the Authentication object when creating the CliAuthenticator
4) _Only_ the LegacySecurityRealm (currently at least) will override createCliAuthenticator(CLICommand command, Authentication auth) and use the Authentication object passed in for the creation of its CliAuthenticator. No other SecurityRealms will be affected by these changes.
5) Update GroovyshCommand to include updates that appear to have been missed in HUDSON-3796 along with changes relative to this ticket.





> Allow CLI Container Managed Authentication
> ------------------------------------------
>
>                 Key: HUDSON-6587
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6587
>             Project: Hudson
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: current
>         Environment: Platform: All, OS: All
>            Reporter: jpederzolli
>            Assignee: jpederzolli
>
> After the changes in HUDSON-3796, container managed authentication no longer works for CLI.
> Make the necessary changes to maintain the extensibility provided in HUDSON-3796, but also allow container based auth.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (HUDSON-6587) Allow CLI Container Managed Authentication

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jpederzolli updated HUDSON-6587:
--------------------------------

    Attachment: cli_auth_updates.diff

proposed changes

> Allow CLI Container Managed Authentication
> ------------------------------------------
>
>                 Key: HUDSON-6587
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6587
>             Project: Hudson
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: current
>         Environment: Platform: All, OS: All
>            Reporter: jpederzolli
>            Assignee: jpederzolli
>         Attachments: cli_auth_updates.diff
>
>
> After the changes in HUDSON-3796, container managed authentication no longer works for CLI.
> Make the necessary changes to maintain the extensibility provided in HUDSON-3796, but also allow container based auth.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6587) Allow CLI Container Managed Authentication

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139327#action_139327 ]

scm_issue_link commented on HUDSON-6587:
----------------------------------------

Code changed in hudson
User: : jpederzolli
Path:
 trunk/hudson/main/core/src/main/java/hudson/cli/CLICommand.java
 trunk/hudson/main/core/src/main/java/hudson/cli/CliManagerImpl.java
 trunk/hudson/main/core/src/main/java/hudson/cli/GroovyshCommand.java
 trunk/hudson/main/core/src/main/java/hudson/cli/declarative/CLIRegisterer.java
 trunk/hudson/main/core/src/main/java/hudson/model/Hudson.java
 trunk/hudson/main/core/src/main/java/hudson/security/LegacySecurityRealm.java
 trunk/hudson/main/core/src/main/java/hudson/security/SecurityRealm.java
 trunk/hudson/main/test/src/test/java/hudson/model/listeners/ItemListenerTest.java
http://hudson-ci.org/commit/31878
Log:
Issue: HUDSON-6587


> Allow CLI Container Managed Authentication
> ------------------------------------------
>
>                 Key: HUDSON-6587
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6587
>             Project: Hudson
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: current
>         Environment: Platform: All, OS: All
>            Reporter: jpederzolli
>            Assignee: jpederzolli
>         Attachments: cli_auth_updates.diff
>
>
> After the changes in HUDSON-3796, container managed authentication no longer works for CLI.
> Make the necessary changes to maintain the extensibility provided in HUDSON-3796, but also allow container based auth.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6587) Allow CLI Container Managed Authentication

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139328#action_139328 ]

scm_issue_link commented on HUDSON-6587:
----------------------------------------

Code changed in hudson
User: : jpederzolli
Path:
 trunk/www/changelog.html
http://hudson-ci.org/commit/31879
Log:
Issue: HUDSON-6587


> Allow CLI Container Managed Authentication
> ------------------------------------------
>
>                 Key: HUDSON-6587
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6587
>             Project: Hudson
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: current
>         Environment: Platform: All, OS: All
>            Reporter: jpederzolli
>            Assignee: jpederzolli
>         Attachments: cli_auth_updates.diff
>
>
> After the changes in HUDSON-3796, container managed authentication no longer works for CLI.
> Make the necessary changes to maintain the extensibility provided in HUDSON-3796, but also allow container based auth.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (HUDSON-6587) Allow CLI Container Managed Authentication

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jpederzolli resolved HUDSON-6587.
---------------------------------

    Fix Version/s: current
       Resolution: Fixed

> Allow CLI Container Managed Authentication
> ------------------------------------------
>
>                 Key: HUDSON-6587
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6587
>             Project: Hudson
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: current
>         Environment: Platform: All, OS: All
>            Reporter: jpederzolli
>            Assignee: jpederzolli
>             Fix For: current
>
>         Attachments: cli_auth_updates.diff
>
>
> After the changes in HUDSON-3796, container managed authentication no longer works for CLI.
> Make the necessary changes to maintain the extensibility provided in HUDSON-3796, but also allow container based auth.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6587) Allow CLI Container Managed Authentication

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139330#action_139330 ]

scm_issue_link commented on HUDSON-6587:
----------------------------------------

Code changed in hudson
User: : kohsuke
Path:
 trunk/hudson/main/core/src/main/java/hudson/cli/CLICommand.java
 trunk/hudson/main/core/src/main/java/hudson/cli/CliManagerImpl.java
 trunk/hudson/main/core/src/main/java/hudson/cli/GroovyshCommand.java
 trunk/hudson/main/core/src/main/java/hudson/cli/declarative/CLIRegisterer.java
 trunk/hudson/main/core/src/main/java/hudson/model/Hudson.java
 trunk/hudson/main/core/src/main/java/hudson/security/CliAuthenticator.java
 trunk/hudson/main/core/src/main/java/hudson/security/LegacySecurityRealm.java
 trunk/hudson/main/core/src/main/java/hudson/security/SecurityRealm.java
 trunk/hudson/main/remoting/src/main/java/hudson/remoting/Channel.java
 trunk/hudson/main/remoting/src/main/java/hudson/remoting/ChannelProperty.java
 trunk/hudson/main/test/src/test/java/hudson/model/listeners/ItemListenerTest.java
http://hudson-ci.org/commit/31900
Log:
[HUDSON-6587] rolling back rev.31878. I think a better fix, given the current existing code and method signatures, is to expose the transport level authentication in a bit more implicit way.


> Allow CLI Container Managed Authentication
> ------------------------------------------
>
>                 Key: HUDSON-6587
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6587
>             Project: Hudson
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: current
>         Environment: Platform: All, OS: All
>            Reporter: jpederzolli
>            Assignee: jpederzolli
>             Fix For: current
>
>         Attachments: cli_auth_updates.diff
>
>
> After the changes in HUDSON-3796, container managed authentication no longer works for CLI.
> Make the necessary changes to maintain the extensibility provided in HUDSON-3796, but also allow container based auth.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6587) Allow CLI Container Managed Authentication

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139331#action_139331 ]

kohsuke commented on HUDSON-6587:
---------------------------------

Just to be clear, my commit in rev.31900 includes the change I outlined.

> Allow CLI Container Managed Authentication
> ------------------------------------------
>
>                 Key: HUDSON-6587
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6587
>             Project: Hudson
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: current
>         Environment: Platform: All, OS: All
>            Reporter: jpederzolli
>            Assignee: jpederzolli
>             Fix For: current
>
>         Attachments: cli_auth_updates.diff
>
>
> After the changes in HUDSON-3796, container managed authentication no longer works for CLI.
> Make the necessary changes to maintain the extensibility provided in HUDSON-3796, but also allow container based auth.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Issue Comment Edited: (HUDSON-6587) Allow CLI Container Managed Authentication

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139331#action_139331 ]

kohsuke edited comment on HUDSON-6587 at 6/9/10 7:44 PM:
---------------------------------------------------------

Just to be clear, my commit in rev.31900 includes the change I outlined. Come to think of it, I should have committed them as two separate commits.

      was (Author: kohsuke):
    Just to be clear, my commit in rev.31900 includes the change I outlined.
 

> Allow CLI Container Managed Authentication
> ------------------------------------------
>
>                 Key: HUDSON-6587
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6587
>             Project: Hudson
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: current
>         Environment: Platform: All, OS: All
>            Reporter: jpederzolli
>            Assignee: jpederzolli
>             Fix For: current
>
>         Attachments: cli_auth_updates.diff
>
>
> After the changes in HUDSON-3796, container managed authentication no longer works for CLI.
> Make the necessary changes to maintain the extensibility provided in HUDSON-3796, but also allow container based auth.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]