[JIRA] Created: (HUDSON-6804) safeRestart should preserve build queuehc

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (HUDSON-6804) safeRestart should preserve build queuehc

Hudson issues mailing list
safeRestart should preserve build queuehc
-----------------------------------------

                 Key: HUDSON-6804
                 URL: http://issues.hudson-ci.org/browse/HUDSON-6804
             Project: Hudson
          Issue Type: Improvement
          Components: core
            Reporter: voorth


After a restart, I get complaints from developers that their committed changes have not triggered. On a closer look, it turns out that the builds were already present in the build queue during restart. Saving the queue before restart would be a nice extension...

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (HUDSON-6804) safeRestart should preserve build queue

Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

voorth updated HUDSON-6804:
---------------------------

    Summary: safeRestart should preserve build queue  (was: safeRestart should preserve build queuehc)

> safeRestart should preserve build queue
> ---------------------------------------
>
>                 Key: HUDSON-6804
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6804
>             Project: Hudson
>          Issue Type: Improvement
>          Components: core
>            Reporter: voorth
>
> After a restart, I get complaints from developers that their committed changes have not triggered. On a closer look, it turns out that the builds were already present in the build queue during restart. Saving the queue before restart would be a nice extension...

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6804) safeRestart should preserve build queue

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139612#action_139612 ]

mindless commented on HUDSON-6804:
----------------------------------

Hudson.java:2228 should save the queue contents.. I wonder if cleanUp() is somehow not called for safeRestart?  cleanUp is called from WebAppMain.contextDestroyed().

> safeRestart should preserve build queue
> ---------------------------------------
>
>                 Key: HUDSON-6804
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6804
>             Project: Hudson
>          Issue Type: Improvement
>          Components: core
>            Reporter: voorth
>
> After a restart, I get complaints from developers that their committed changes have not triggered. On a closer look, it turns out that the builds were already present in the build queue during restart. Saving the queue before restart would be a nice extension...

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6804) safeRestart should preserve build queue

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=140353#action_140353 ]

voorth commented on HUDSON-6804:
--------------------------------

Seems like it. With the safeRestart thread problems fixed in 1.367, I can confirm that after a safeRestart the build queue is empty.

> safeRestart should preserve build queue
> ---------------------------------------
>
>                 Key: HUDSON-6804
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6804
>             Project: Hudson
>          Issue Type: Improvement
>          Components: core
>            Reporter: voorth
>
> After a restart, I get complaints from developers that their committed changes have not triggered. On a closer look, it turns out that the builds were already present in the build queue during restart. Saving the queue before restart would be a nice extension...

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6804) safeRestart should preserve build queue

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=140355#action_140355 ]

mindless commented on HUDSON-6804:
----------------------------------

Can you post steps to reproduce the problem in a new 1.367 install with no added plugins?  Thanks.

> safeRestart should preserve build queue
> ---------------------------------------
>
>                 Key: HUDSON-6804
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6804
>             Project: Hudson
>          Issue Type: Improvement
>          Components: core
>            Reporter: voorth
>
> After a restart, I get complaints from developers that their committed changes have not triggered. On a closer look, it turns out that the builds were already present in the build queue during restart. Saving the queue before restart would be a nice extension...

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6804) safeRestart should preserve build queue

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=140387#action_140387 ]

voorth commented on HUDSON-6804:
--------------------------------

# Create a 120 sec countdown job
# Set the number of executors to 1
# create two minimal jobs
# start the countdown job
# start the two small jobs
# http://<hudsonserver>/safeRestart
# after restart, the two pending jobs will not have been executed (you can tell by the build number)

> safeRestart should preserve build queue
> ---------------------------------------
>
>                 Key: HUDSON-6804
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6804
>             Project: Hudson
>          Issue Type: Improvement
>          Components: core
>            Reporter: voorth
>
> After a restart, I get complaints from developers that their committed changes have not triggered. On a closer look, it turns out that the builds were already present in the build queue during restart. Saving the queue before restart would be a nice extension...

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6804) safeRestart should preserve build queue

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=140400#action_140400 ]

mindless commented on HUDSON-6804:
----------------------------------

thanks.. those steps did reproduce the issue for me.. I'll do some digging.

> safeRestart should preserve build queue
> ---------------------------------------
>
>                 Key: HUDSON-6804
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6804
>             Project: Hudson
>          Issue Type: Improvement
>          Components: core
>            Reporter: voorth
>
> After a restart, I get complaints from developers that their committed changes have not triggered. On a closer look, it turns out that the builds were already present in the build queue during restart. Saving the queue before restart would be a nice extension...

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Assigned: (HUDSON-6804) safeRestart should preserve build queue

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

mindless reassigned HUDSON-6804:
--------------------------------

    Assignee: mindless

> safeRestart should preserve build queue
> ---------------------------------------
>
>                 Key: HUDSON-6804
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6804
>             Project: Hudson
>          Issue Type: Improvement
>          Components: core
>            Reporter: voorth
>            Assignee: mindless
>
> After a restart, I get complaints from developers that their committed changes have not triggered. On a closer look, it turns out that the builds were already present in the build queue during restart. Saving the queue before restart would be a nice extension...

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6804) safeRestart should preserve build queue

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=140423#action_140423 ]

scm_issue_link commented on HUDSON-6804:
----------------------------------------

Code changed in hudson
User: : mindless
Path:
 trunk/hudson/main/core/src/main/java/hudson/lifecycle/SolarisSMFLifecycle.java
 trunk/hudson/main/core/src/main/java/hudson/lifecycle/UnixLifecycle.java
 trunk/hudson/main/core/src/main/java/hudson/model/Hudson.java
 trunk/www/changelog.html
http://hudson-ci.org/commit/33184
Log:
[FIXED HUDSON-6804] call Hudson.cleanUp from lifecycle classes and in Hudson.doSafeExit
so that safeRestart and safeExit propertly cleanup before terminating the process;
in particular, so the contents of the build queue is saved so it can be restored
after restart.  Also increased delay before restart from 5 to 10 seconds,
as I saw one build get interrupted at restart in my testing.


> safeRestart should preserve build queue
> ---------------------------------------
>
>                 Key: HUDSON-6804
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6804
>             Project: Hudson
>          Issue Type: Improvement
>          Components: core
>            Reporter: voorth
>            Assignee: mindless
>
> After a restart, I get complaints from developers that their committed changes have not triggered. On a closer look, it turns out that the builds were already present in the build queue during restart. Saving the queue before restart would be a nice extension...

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (HUDSON-6804) safeRestart should preserve build queue

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

scm_issue_link resolved HUDSON-6804.
------------------------------------

    Resolution: Fixed

> safeRestart should preserve build queue
> ---------------------------------------
>
>                 Key: HUDSON-6804
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6804
>             Project: Hudson
>          Issue Type: Improvement
>          Components: core
>            Reporter: voorth
>            Assignee: mindless
>
> After a restart, I get complaints from developers that their committed changes have not triggered. On a closer look, it turns out that the builds were already present in the build queue during restart. Saving the queue before restart would be a nice extension...

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]