[JIRA] Created: (HUDSON-6814) Advanced approve commands does not get used on save.

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (HUDSON-6814) Advanced approve commands does not get used on save.

Hudson issues mailing list
Advanced approve commands does not get used on save.
----------------------------------------------------

                 Key: HUDSON-6814
                 URL: http://issues.hudson-ci.org/browse/HUDSON-6814
             Project: Hudson
          Issue Type: Bug
          Components: gerrit-trigger
            Reporter: rsandell
            Assignee: rsandell


When you save the settings in http://server/gerrit-trigger/ the changed advanced messages does not get used. Eg. It doesn't matter what you write in GerritVerifiedCmdBuildStarted, it continues to use the default messages.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Work started: (HUDSON-6814) Advanced approve commands does not get used on save.

Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on HUDSON-6814 started by rsandell.

> Advanced approve commands does not get used on save.
> ----------------------------------------------------
>
>                 Key: HUDSON-6814
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6814
>             Project: Hudson
>          Issue Type: Bug
>          Components: gerrit-trigger
>            Reporter: rsandell
>            Assignee: rsandell
>
> When you save the settings in http://server/gerrit-trigger/ the changed advanced messages does not get used. Eg. It doesn't matter what you write in GerritVerifiedCmdBuildStarted, it continues to use the default messages.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Closed: (HUDSON-6814) Advanced approve commands does not get used on save.

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-6814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

rsandell closed HUDSON-6814.
----------------------------

    Resolution: Fixed

Merged to master branch @ http://github.com/hudson/gerrit-trigger-plugin commit d4154db75e496f8e9221

> Advanced approve commands does not get used on save.
> ----------------------------------------------------
>
>                 Key: HUDSON-6814
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6814
>             Project: Hudson
>          Issue Type: Bug
>          Components: gerrit-trigger
>            Reporter: rsandell
>            Assignee: rsandell
>
> When you save the settings in http://server/gerrit-trigger/ the changed advanced messages does not get used. Eg. It doesn't matter what you write in GerritVerifiedCmdBuildStarted, it continues to use the default messages.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6814) Advanced approve commands does not get used on save.

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=140287#action_140287 ]

abayer commented on HUDSON-6814:
--------------------------------

FYI, something still seems to be broken here - I think because the fields are named "GerritVerifiedCmdBuildStarted" in index.jelly, but in Config.java, it's looking for "gerritVerifiedCmdBuildStarted".

> Advanced approve commands does not get used on save.
> ----------------------------------------------------
>
>                 Key: HUDSON-6814
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6814
>             Project: Hudson
>          Issue Type: Bug
>          Components: gerrit-trigger
>            Reporter: rsandell
>            Assignee: rsandell
>
> When you save the settings in http://server/gerrit-trigger/ the changed advanced messages does not get used. Eg. It doesn't matter what you write in GerritVerifiedCmdBuildStarted, it continues to use the default messages.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6814) Advanced approve commands does not get used on save.

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=140318#action_140318 ]

abayer commented on HUDSON-6814:
--------------------------------

Fixed the jelly: http://github.com/hudson/gerrit-trigger-plugin/commit/ec08d5a4a4a4d83343c5c00fc2acf684cb227ecd

> Advanced approve commands does not get used on save.
> ----------------------------------------------------
>
>                 Key: HUDSON-6814
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6814
>             Project: Hudson
>          Issue Type: Bug
>          Components: gerrit-trigger
>            Reporter: rsandell
>            Assignee: rsandell
>
> When you save the settings in http://server/gerrit-trigger/ the changed advanced messages does not get used. Eg. It doesn't matter what you write in GerritVerifiedCmdBuildStarted, it continues to use the default messages.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-6814) Advanced approve commands does not get used on save.

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-6814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=140343#action_140343 ]

rsandell commented on HUDSON-6814:
----------------------------------

Strange, Gustaf had already made that change once, but it was reverted in a later change,
I located the problematic commit that was a bad merge commit on June 30 http://github.com/hudson/gerrit-trigger-plugin/commit/f388d083c169487e50999b4a412c2c1f6efc301a where the capitalization was changed back.

Thanks for noticing!

> Advanced approve commands does not get used on save.
> ----------------------------------------------------
>
>                 Key: HUDSON-6814
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-6814
>             Project: Hudson
>          Issue Type: Bug
>          Components: gerrit-trigger
>            Reporter: rsandell
>            Assignee: rsandell
>
> When you save the settings in http://server/gerrit-trigger/ the changed advanced messages does not get used. Eg. It doesn't matter what you write in GerritVerifiedCmdBuildStarted, it continues to use the default messages.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]