[JIRA] Created: (HUDSON-7054) RetentionStrategy$Demand not respecting Mode.EXCLUSIVE

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (HUDSON-7054) RetentionStrategy$Demand not respecting Mode.EXCLUSIVE

Hudson issues mailing list
RetentionStrategy$Demand not respecting Mode.EXCLUSIVE
------------------------------------------------------

                 Key: HUDSON-7054
                 URL: http://issues.hudson-ci.org/browse/HUDSON-7054
             Project: Hudson
          Issue Type: Bug
          Components: master-slave
         Environment: 1.368-SNAPSHOT
            Reporter: mindless
            Priority: Minor


Queue._getBuildableItems looks at queued items and says they are buildable on a Computer if the task is not tied to a label or label matches the Computer.  If the task is not tied to a label it does NOT check if the Computer is Mode.EXCLUSIVE (ie, "for tied jobs only").
Thus, an on-demand slave may launch its connection when an untied job is in the queue, even though that slave cannot run the task.
_getBuildableItems should either check the Mode, or maybe better use Node.canTake(task) to determine if the task can run on this Computer.


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Assigned: (HUDSON-7054) RetentionStrategy$Demand not respecting Mode.EXCLUSIVE

Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-7054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

mindless reassigned HUDSON-7054:
--------------------------------

    Assignee: mindless

> RetentionStrategy$Demand not respecting Mode.EXCLUSIVE
> ------------------------------------------------------
>
>                 Key: HUDSON-7054
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-7054
>             Project: Hudson
>          Issue Type: Bug
>          Components: master-slave
>         Environment: 1.368-SNAPSHOT
>            Reporter: mindless
>            Assignee: mindless
>            Priority: Minor
>
> Queue._getBuildableItems looks at queued items and says they are buildable on a Computer if the task is not tied to a label or label matches the Computer.  If the task is not tied to a label it does NOT check if the Computer is Mode.EXCLUSIVE (ie, "for tied jobs only").
> Thus, an on-demand slave may launch its connection when an untied job is in the queue, even though that slave cannot run the task.
> _getBuildableItems should either check the Mode, or maybe better use Node.canTake(task) to determine if the task can run on this Computer.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-7054) RetentionStrategy$Demand not respecting Mode.EXCLUSIVE

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-7054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=140424#action_140424 ]

scm_issue_link commented on HUDSON-7054:
----------------------------------------

Code changed in hudson
User: : mindless
Path:
 trunk/hudson/main/core/src/main/java/hudson/model/Queue.java
 trunk/www/changelog.html
http://hudson-ci.org/commit/33185
Log:
[FIXED HUDSON-7054] use Node.canTake(Task) in Queue._getBuildableItems so that
Mode.EXCLUSIVE ("only for tied jobs") setting is respected.


> RetentionStrategy$Demand not respecting Mode.EXCLUSIVE
> ------------------------------------------------------
>
>                 Key: HUDSON-7054
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-7054
>             Project: Hudson
>          Issue Type: Bug
>          Components: master-slave
>         Environment: 1.368-SNAPSHOT
>            Reporter: mindless
>            Assignee: mindless
>            Priority: Minor
>
> Queue._getBuildableItems looks at queued items and says they are buildable on a Computer if the task is not tied to a label or label matches the Computer.  If the task is not tied to a label it does NOT check if the Computer is Mode.EXCLUSIVE (ie, "for tied jobs only").
> Thus, an on-demand slave may launch its connection when an untied job is in the queue, even though that slave cannot run the task.
> _getBuildableItems should either check the Mode, or maybe better use Node.canTake(task) to determine if the task can run on this Computer.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (HUDSON-7054) RetentionStrategy$Demand not respecting Mode.EXCLUSIVE

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-7054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

scm_issue_link resolved HUDSON-7054.
------------------------------------

    Resolution: Fixed

> RetentionStrategy$Demand not respecting Mode.EXCLUSIVE
> ------------------------------------------------------
>
>                 Key: HUDSON-7054
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-7054
>             Project: Hudson
>          Issue Type: Bug
>          Components: master-slave
>         Environment: 1.368-SNAPSHOT
>            Reporter: mindless
>            Assignee: mindless
>            Priority: Minor
>
> Queue._getBuildableItems looks at queued items and says they are buildable on a Computer if the task is not tied to a label or label matches the Computer.  If the task is not tied to a label it does NOT check if the Computer is Mode.EXCLUSIVE (ie, "for tied jobs only").
> Thus, an on-demand slave may launch its connection when an untied job is in the queue, even though that slave cannot run the task.
> _getBuildableItems should either check the Mode, or maybe better use Node.canTake(task) to determine if the task can run on this Computer.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]