[JIRA] Created: (HUDSON-7961) Monitoring external jobs doesn't work with CSRF protection enabled.

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (HUDSON-7961) Monitoring external jobs doesn't work with CSRF protection enabled.

Hudson issues mailing list
Monitoring external jobs doesn't work with CSRF protection enabled.
-------------------------------------------------------------------

                 Key: HUDSON-7961
                 URL: http://issues.hudson-ci.org/browse/HUDSON-7961
             Project: Hudson
          Issue Type: Bug
          Components: core
    Affects Versions: current
            Reporter: davidreiss


Monitoring an external job (described at http://wiki.hudson-ci.org/display/HUDSON/Monitoring+external+jobs) doesn't work if the Hudson instance has CSRF protection enabled, because the cli doesn't retrieve a crumb before attempting to submit the result.  An example solution is described in one of the blue boxes at <http://wiki.hudson-ci.org/display/HUDSON/Subversion+Plugin>.  I'll attach a patch that uses this trick to fix the problem.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (HUDSON-7961) Monitoring external jobs doesn't work with CSRF protection enabled.

Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-7961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

davidreiss updated HUDSON-7961:
-------------------------------

    Attachment: hudson-external-crumb.patch

> Monitoring external jobs doesn't work with CSRF protection enabled.
> -------------------------------------------------------------------
>
>                 Key: HUDSON-7961
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-7961
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: davidreiss
>         Attachments: hudson-external-crumb.patch
>
>
> Monitoring an external job (described at http://wiki.hudson-ci.org/display/HUDSON/Monitoring+external+jobs) doesn't work if the Hudson instance has CSRF protection enabled, because the cli doesn't retrieve a crumb before attempting to submit the result.  An example solution is described in one of the blue boxes at <http://wiki.hudson-ci.org/display/HUDSON/Subversion+Plugin>.  I'll attach a patch that uses this trick to fix the problem.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Assigned: (HUDSON-7961) Monitoring external jobs doesn't work with CSRF protection enabled.

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-7961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

mindless reassigned HUDSON-7961:
--------------------------------

    Assignee: mindless

> Monitoring external jobs doesn't work with CSRF protection enabled.
> -------------------------------------------------------------------
>
>                 Key: HUDSON-7961
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-7961
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: davidreiss
>            Assignee: mindless
>         Attachments: hudson-external-crumb.patch
>
>
> Monitoring an external job (described at http://wiki.hudson-ci.org/display/HUDSON/Monitoring+external+jobs) doesn't work if the Hudson instance has CSRF protection enabled, because the cli doesn't retrieve a crumb before attempting to submit the result.  An example solution is described in one of the blue boxes at <http://wiki.hudson-ci.org/display/HUDSON/Subversion+Plugin>.  I'll attach a patch that uses this trick to fix the problem.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-7961) Monitoring external jobs doesn't work with CSRF protection enabled.

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-7961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=143329#action_143329 ]

scm_issue_link commented on HUDSON-7961:
----------------------------------------

Code changed in hudson
User: : mindless
Path:
 trunk/hudson/main/core/src/main/java/hudson/Main.java
 trunk/www/changelog.html
http://hudson-ci.org/commit/36678
Log:
[FIXED HUDSON-7961] support CSRF protection when submitting results
of external job; patch from davidreiss with 1 minor addition.


> Monitoring external jobs doesn't work with CSRF protection enabled.
> -------------------------------------------------------------------
>
>                 Key: HUDSON-7961
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-7961
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: davidreiss
>            Assignee: mindless
>         Attachments: hudson-external-crumb.patch
>
>
> Monitoring an external job (described at http://wiki.hudson-ci.org/display/HUDSON/Monitoring+external+jobs) doesn't work if the Hudson instance has CSRF protection enabled, because the cli doesn't retrieve a crumb before attempting to submit the result.  An example solution is described in one of the blue boxes at <http://wiki.hudson-ci.org/display/HUDSON/Subversion+Plugin>.  I'll attach a patch that uses this trick to fix the problem.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (HUDSON-7961) Monitoring external jobs doesn't work with CSRF protection enabled.

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

     [ http://issues.hudson-ci.org/browse/HUDSON-7961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

scm_issue_link resolved HUDSON-7961.
------------------------------------

    Resolution: Fixed

> Monitoring external jobs doesn't work with CSRF protection enabled.
> -------------------------------------------------------------------
>
>                 Key: HUDSON-7961
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-7961
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: davidreiss
>            Assignee: mindless
>         Attachments: hudson-external-crumb.patch
>
>
> Monitoring an external job (described at http://wiki.hudson-ci.org/display/HUDSON/Monitoring+external+jobs) doesn't work if the Hudson instance has CSRF protection enabled, because the cli doesn't retrieve a crumb before attempting to submit the result.  An example solution is described in one of the blue boxes at <http://wiki.hudson-ci.org/display/HUDSON/Subversion+Plugin>.  I'll attach a patch that uses this trick to fix the problem.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-7961) Monitoring external jobs doesn't work with CSRF protection enabled.

Hudson issues mailing list
In reply to this post by Hudson issues mailing list

    [ http://issues.hudson-ci.org/browse/HUDSON-7961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=143386#action_143386 ]

dogfood commented on HUDSON-7961:
---------------------------------

Integrated in !http://ci.hudson-labs.org/images/16x16/yellow.gif! [hudson_main_trunk #383|http://ci.hudson-labs.org/job/hudson_main_trunk/383/]
     [FIXED HUDSON-7961] support CSRF protection when submitting results
of external job; patch from davidreiss with 1 minor addition.

mindless :
Files :
* /trunk/www/changelog.html
* /trunk/hudson/main/core/src/main/java/hudson/Main.java


> Monitoring external jobs doesn't work with CSRF protection enabled.
> -------------------------------------------------------------------
>
>                 Key: HUDSON-7961
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-7961
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: davidreiss
>            Assignee: mindless
>         Attachments: hudson-external-crumb.patch
>
>
> Monitoring an external job (described at http://wiki.hudson-ci.org/display/HUDSON/Monitoring+external+jobs) doesn't work if the Hudson instance has CSRF protection enabled, because the cli doesn't retrieve a crumb before attempting to submit the result.  An example solution is described in one of the blue boxes at <http://wiki.hudson-ci.org/display/HUDSON/Subversion+Plugin>.  I'll attach a patch that uses this trick to fix the problem.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]