[JIRA] Created: (HUDSON-8438) Node names can be edited to include slashes and then cannot be removed

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (HUDSON-8438) Node names can be edited to include slashes and then cannot be removed

Kohsuke Kawaguchi
Administrator
Node names can be edited to include slashes and then cannot be removed
----------------------------------------------------------------------

                 Key: HUDSON-8438
                 URL: http://issues.hudson-ci.org/browse/HUDSON-8438
             Project: Hudson
          Issue Type: Bug
          Components: core
    Affects Versions: current
            Reporter: jrh3k5


Using Hudson v1.392, I did the following:

* Created a node with a valid name (e.g., "Key Manager Build")
* Edited the node name to something that should have been marked as invalid (e.g., "IdP / OAuth Build")

I am now unable to edit or delete this node.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[JIRA] Assigned: (HUDSON-8438) Node names can be edited to include slashes and then cannot be removed

Kohsuke Kawaguchi
Administrator

     [ http://issues.hudson-ci.org/browse/HUDSON-8438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

sogabe reassigned HUDSON-8438:
------------------------------

    Assignee: sogabe

> Node names can be edited to include slashes and then cannot be removed
> ----------------------------------------------------------------------
>
>                 Key: HUDSON-8438
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-8438
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: jrh3k5
>            Assignee: sogabe
>
> Using Hudson v1.392, I did the following:
> * Created a node with a valid name (e.g., "Key Manager Build")
> * Edited the node name to something that should have been marked as invalid (e.g., "IdP / OAuth Build")
> I am now unable to edit or delete this node.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[JIRA] Work started: (HUDSON-8438) Node names can be edited to include slashes and then cannot be removed

Kohsuke Kawaguchi
Administrator
In reply to this post by Kohsuke Kawaguchi

     [ http://issues.hudson-ci.org/browse/HUDSON-8438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on HUDSON-8438 started by sogabe.

> Node names can be edited to include slashes and then cannot be removed
> ----------------------------------------------------------------------
>
>                 Key: HUDSON-8438
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-8438
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: jrh3k5
>            Assignee: sogabe
>
> Using Hudson v1.392, I did the following:
> * Created a node with a valid name (e.g., "Key Manager Build")
> * Edited the node name to something that should have been marked as invalid (e.g., "IdP / OAuth Build")
> I am now unable to edit or delete this node.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-8438) Node names can be edited to include slashes and then cannot be removed

Kohsuke Kawaguchi
Administrator
In reply to this post by Kohsuke Kawaguchi

    [ http://issues.hudson-ci.org/browse/HUDSON-8438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=144976#action_144976 ]

scm_issue_link commented on HUDSON-8438:
----------------------------------------

Code changed in hudson
User: Seiji Sogabe
Path:
 changelog.html
 core/src/main/java/hudson/slaves/NodeDescriptor.java
 core/src/main/resources/hudson/slaves/Messages.properties
 core/src/main/resources/hudson/slaves/Messages_ja.properties
http://hudson-labs.org/commit/core/46f2f02f9dbea085e67ff70673f38644b14b4f01
Log:
[FIXED HUDSON-8438] Node names can be edited to include slashes and then cannot be removed.





> Node names can be edited to include slashes and then cannot be removed
> ----------------------------------------------------------------------
>
>                 Key: HUDSON-8438
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-8438
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: jrh3k5
>            Assignee: sogabe
>
> Using Hudson v1.392, I did the following:
> * Created a node with a valid name (e.g., "Key Manager Build")
> * Edited the node name to something that should have been marked as invalid (e.g., "IdP / OAuth Build")
> I am now unable to edit or delete this node.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (HUDSON-8438) Node names can be edited to include slashes and then cannot be removed

Kohsuke Kawaguchi
Administrator
In reply to this post by Kohsuke Kawaguchi

     [ http://issues.hudson-ci.org/browse/HUDSON-8438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

scm_issue_link resolved HUDSON-8438.
------------------------------------

    Resolution: Fixed

> Node names can be edited to include slashes and then cannot be removed
> ----------------------------------------------------------------------
>
>                 Key: HUDSON-8438
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-8438
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: jrh3k5
>            Assignee: sogabe
>
> Using Hudson v1.392, I did the following:
> * Created a node with a valid name (e.g., "Key Manager Build")
> * Edited the node name to something that should have been marked as invalid (e.g., "IdP / OAuth Build")
> I am now unable to edit or delete this node.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-8438) Node names can be edited to include slashes and then cannot be removed

Kohsuke Kawaguchi
Administrator
In reply to this post by Kohsuke Kawaguchi

    [ http://issues.hudson-ci.org/browse/HUDSON-8438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=144977#action_144977 ]

jrh3k5 commented on HUDSON-8438:
--------------------------------

Just out of curiosity, is there anything, short of editing the underlying XML, that would allow me to fix the node name?

> Node names can be edited to include slashes and then cannot be removed
> ----------------------------------------------------------------------
>
>                 Key: HUDSON-8438
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-8438
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: jrh3k5
>            Assignee: sogabe
>
> Using Hudson v1.392, I did the following:
> * Created a node with a valid name (e.g., "Key Manager Build")
> * Edited the node name to something that should have been marked as invalid (e.g., "IdP / OAuth Build")
> I am now unable to edit or delete this node.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-8438) Node names can be edited to include slashes and then cannot be removed

Kohsuke Kawaguchi
Administrator
In reply to this post by Kohsuke Kawaguchi

    [ http://issues.hudson-ci.org/browse/HUDSON-8438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=144978#action_144978 ]

sogabe commented on HUDSON-8438:
--------------------------------

Edit your config.xml as follows and restart Hudson instance.

{quote}
<hudson>
  :
  <slaves>
    <slave>
      <name>Win7</name>  // <-- Change this to correct name.
      <description>Windows 7</description>
      <remoteFS>/tmp</remoteFS>
      <numExecutors>1</numExecutors>
      <mode>NORMAL</mode>
      <retentionStrategy class="hudson.slaves.RetentionStrategy$Always"/>
    :
{quote}

> Node names can be edited to include slashes and then cannot be removed
> ----------------------------------------------------------------------
>
>                 Key: HUDSON-8438
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-8438
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: jrh3k5
>            Assignee: sogabe
>
> Using Hudson v1.392, I did the following:
> * Created a node with a valid name (e.g., "Key Manager Build")
> * Edited the node name to something that should have been marked as invalid (e.g., "IdP / OAuth Build")
> I am now unable to edit or delete this node.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-8438) Node names can be edited to include slashes and then cannot be removed

Kohsuke Kawaguchi
Administrator
In reply to this post by Kohsuke Kawaguchi

    [ http://issues.hudson-ci.org/browse/HUDSON-8438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=144979#action_144979 ]

jrh3k5 commented on HUDSON-8438:
--------------------------------

Awesome, thanks!

> Node names can be edited to include slashes and then cannot be removed
> ----------------------------------------------------------------------
>
>                 Key: HUDSON-8438
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-8438
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: jrh3k5
>            Assignee: sogabe
>
> Using Hudson v1.392, I did the following:
> * Created a node with a valid name (e.g., "Key Manager Build")
> * Edited the node name to something that should have been marked as invalid (e.g., "IdP / OAuth Build")
> I am now unable to edit or delete this node.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-8438) Node names can be edited to include slashes and then cannot be removed

Hudson issues mailing list-2
In reply to this post by Kohsuke Kawaguchi

    [ http://issues.hudson-ci.org/browse/HUDSON-8438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145133#action_145133 ]

dogfood commented on HUDSON-8438:
---------------------------------

Integrated in !http://ci.hudson-labs.org/images/16x16/yellow.gif! [hudson_main_trunk #450|http://ci.hudson-labs.org/job/hudson_main_trunk/450/]
     [FIXED HUDSON-8438] Node names can be edited to include slashes and then cannot be removed.

Seiji Sogabe :
Files :
* core/src/main/resources/hudson/slaves/Messages.properties
* core/src/main/java/hudson/slaves/NodeDescriptor.java
* core/src/main/resources/hudson/slaves/Messages_ja.properties
* changelog.html


> Node names can be edited to include slashes and then cannot be removed
> ----------------------------------------------------------------------
>
>                 Key: HUDSON-8438
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-8438
>             Project: Hudson
>          Issue Type: Bug
>          Components: core
>    Affects Versions: current
>            Reporter: jrh3k5
>            Assignee: sogabe
>
> Using Hudson v1.392, I did the following:
> * Created a node with a valid name (e.g., "Key Manager Build")
> * Edited the node name to something that should have been marked as invalid (e.g., "IdP / OAuth Build")
> I am now unable to edit or delete this node.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira