[JIRA] Created: (HUDSON-8517) Set revision number in JobRevision Plugin

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (HUDSON-8517) Set revision number in JobRevision Plugin

Kohsuke Kawaguchi
Administrator
Set revision number in JobRevision Plugin
------------------------------------------

                 Key: HUDSON-8517
                 URL: http://issues.hudson-ci.org/browse/HUDSON-8517
             Project: Hudson
          Issue Type: New Feature
          Components: scm-sync-configuration
            Reporter: peter_schuetze
            Assignee: fcamblor


It would be cool to have the scm-sync-configuration plugin set the revision number from the JobRevision Plugin every time the config files are saved.

I can see several different implementations:

* Increase the last part of a revision number by 1 (e.g. 1.5 -> 1.6 or 1.7.3 -> 1.7.4)
* Set the repository revision number as the revision number of the job (e.g. 34265)
* a combination of the above -- last part of the job revision number is the repository revision number (e.g. 1.5.23652 -> 1.5.13735)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-8517) Set revision number in JobRevision Plugin

Kohsuke Kawaguchi
Administrator

    [ http://issues.hudson-ci.org/browse/HUDSON-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=144959#action_144959 ]

fcamblor commented on HUDSON-8517:
----------------------------------

I'm not sure about the dependency upon JobRevision plugin ..

Nevertheless, I understand your need to have a job variable to identify current job SCM revision number.

_but_ :
- This functionality looks really job oriented (unless scm-sync-configuration should be generic upon every Saveables)
- What if, for some unknown reason, current job config.xml file is desynchronized with the scm one ? We take the risk to populate a variable with a bad value

For me, it is not the most important enhancement for the future of the plugin.

Will keep the enhancement though, but will lower its priority

> Set revision number in JobRevision Plugin
> ------------------------------------------
>
>                 Key: HUDSON-8517
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-8517
>             Project: Hudson
>          Issue Type: New Feature
>          Components: scm-sync-configuration
>            Reporter: peter_schuetze
>            Assignee: fcamblor
>
> It would be cool to have the scm-sync-configuration plugin set the revision number from the JobRevision Plugin every time the config files are saved.
> I can see several different implementations:
> * Increase the last part of a revision number by 1 (e.g. 1.5 -> 1.6 or 1.7.3 -> 1.7.4)
> * Set the repository revision number as the revision number of the job (e.g. 34265)
> * a combination of the above -- last part of the job revision number is the repository revision number (e.g. 1.5.23652 -> 1.5.13735)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (HUDSON-8517) Set revision number in JobRevision Plugin

Kohsuke Kawaguchi
Administrator
In reply to this post by Kohsuke Kawaguchi

     [ http://issues.hudson-ci.org/browse/HUDSON-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

fcamblor updated HUDSON-8517:
-----------------------------

    Priority: Minor  (was: Major)

> Set revision number in JobRevision Plugin
> ------------------------------------------
>
>                 Key: HUDSON-8517
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-8517
>             Project: Hudson
>          Issue Type: New Feature
>          Components: scm-sync-configuration
>            Reporter: peter_schuetze
>            Assignee: fcamblor
>            Priority: Minor
>
> It would be cool to have the scm-sync-configuration plugin set the revision number from the JobRevision Plugin every time the config files are saved.
> I can see several different implementations:
> * Increase the last part of a revision number by 1 (e.g. 1.5 -> 1.6 or 1.7.3 -> 1.7.4)
> * Set the repository revision number as the revision number of the job (e.g. 34265)
> * a combination of the above -- last part of the job revision number is the repository revision number (e.g. 1.5.23652 -> 1.5.13735)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-8517) Set revision number in JobRevision Plugin

Kohsuke Kawaguchi
Administrator
In reply to this post by Kohsuke Kawaguchi

    [ http://issues.hudson-ci.org/browse/HUDSON-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145023#action_145023 ]

peter_schuetze commented on HUDSON-8517:
----------------------------------------

Sorry, I should have lowered the priority right from the beginning.

Dependency to Job Revision:
* They implemented a feature to have a job revision. Therefor I mentioned it. But it can be implemented (at least the revision number) from scm-sync-config plugin.

generic upon every Saveables?
* scm-sync-configuration plugin, should save ALL config files of the Hudson server. If this can't be solved on a generic bases (like all xml files up to a certain level) than the possibility needs to be there to add additional files through a configuration screen.

desynchronized with the scm?
This risk is there regardless whether a version number is displayed or not. Therefore the plugin needs to verify (synchronize) the config against the SCM every time the server starts as well as every time the config is reloaded. It needs to be discussed what the action is that should be taken when a difference is detected.

> Set revision number in JobRevision Plugin
> ------------------------------------------
>
>                 Key: HUDSON-8517
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-8517
>             Project: Hudson
>          Issue Type: New Feature
>          Components: scm-sync-configuration
>            Reporter: peter_schuetze
>            Assignee: fcamblor
>            Priority: Minor
>
> It would be cool to have the scm-sync-configuration plugin set the revision number from the JobRevision Plugin every time the config files are saved.
> I can see several different implementations:
> * Increase the last part of a revision number by 1 (e.g. 1.5 -> 1.6 or 1.7.3 -> 1.7.4)
> * Set the repository revision number as the revision number of the job (e.g. 34265)
> * a combination of the above -- last part of the job revision number is the repository revision number (e.g. 1.5.23652 -> 1.5.13735)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira