[JIRA] Created: (HUDSON-8535) Build should not be marked as failed when tests do not pass

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (HUDSON-8535) Build should not be marked as failed when tests do not pass

Kohsuke Kawaguchi
Administrator
Build should not be marked as failed when tests do not pass
-----------------------------------------------------------

                 Key: HUDSON-8535
                 URL: http://issues.hudson-ci.org/browse/HUDSON-8535
             Project: Hudson
          Issue Type: Improvement
          Components: grails
    Affects Versions: current
            Reporter: hanswesterbeek
            Assignee: jeffg2one


When a build contains tests that have failed, hudson marks the entire build as failed, which is a bit over the top if we look at the definitions on http://wiki.hudson-ci.org/display/HUDSON/Terminology

So I think this is not the right behaviour, the result of the build should be 'unstable'. I can imagine this has something to do with the exit code of the grails command that is run by hudson. Is that what should be fixed? If so I will post an issue in the grails jira.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-8535) Build should not be marked as failed when tests do not pass

Kohsuke Kawaguchi
Administrator

    [ http://issues.hudson-ci.org/browse/HUDSON-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145050#action_145050 ]

jeffg2one commented on HUDSON-8535:
-----------------------------------

I think the builder's perform() method is returning false if grails returns non-zero.  It should probably should only return false if something really went wrong.  Failed tests don't warrant returning false here if I understand the Hudson docs properly.

> Build should not be marked as failed when tests do not pass
> -----------------------------------------------------------
>
>                 Key: HUDSON-8535
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-8535
>             Project: Hudson
>          Issue Type: Improvement
>          Components: grails
>    Affects Versions: current
>            Reporter: hanswesterbeek
>            Assignee: jeffg2one
>
> When a build contains tests that have failed, hudson marks the entire build as failed, which is a bit over the top if we look at the definitions on http://wiki.hudson-ci.org/display/HUDSON/Terminology
> So I think this is not the right behaviour, the result of the build should be 'unstable'. I can imagine this has something to do with the exit code of the grails command that is run by hudson. Is that what should be fixed? If so I will post an issue in the grails jira.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (HUDSON-8535) Build should not be marked as failed when tests do not pass

Kohsuke Kawaguchi
Administrator
In reply to this post by Kohsuke Kawaguchi

    [ http://issues.hudson-ci.org/browse/HUDSON-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145051#action_145051 ]

hanswesterbeek commented on HUDSON-8535:
----------------------------------------

So you're saying I should report this to the Grails Jira?

> Build should not be marked as failed when tests do not pass
> -----------------------------------------------------------
>
>                 Key: HUDSON-8535
>                 URL: http://issues.hudson-ci.org/browse/HUDSON-8535
>             Project: Hudson
>          Issue Type: Improvement
>          Components: grails
>    Affects Versions: current
>            Reporter: hanswesterbeek
>            Assignee: jeffg2one
>
> When a build contains tests that have failed, hudson marks the entire build as failed, which is a bit over the top if we look at the definitions on http://wiki.hudson-ci.org/display/HUDSON/Terminology
> So I think this is not the right behaviour, the result of the build should be 'unstable'. I can imagine this has something to do with the exit code of the grails command that is run by hudson. Is that what should be fixed? If so I will post an issue in the grails jira.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hudson-ci.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira