Quantcast

[JIRA] Created: (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] Created: (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org
Allowing same type of parameter for triggered build more than once seems redundant
----------------------------------------------------------------------------------

                 Key: JENKINS-8916
                 URL: http://issues.jenkins-ci.org/browse/JENKINS-8916
             Project: Jenkins
          Issue Type: Bug
          Components: parameterized-trigger
    Affects Versions: current
            Reporter: Fred G
            Assignee: huybrechts
            Priority: Minor


While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once.
For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times.
The only type where it might make sense is "Parameters from properties file".

I think for every type of parameters a simple checkbox is sufficient.

I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] Commented: (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org

    [ http://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146379#comment-146379 ]

Fred G commented on JENKINS-8916:
---------------------------------

I'm trying to replace the following jelly script in BuildTriggerConfig/config.jelly:
{code}
<f:hetero-list name="configs" hasHeader="true"
               descriptors="${descriptor.getBuilderConfigDescriptors()}"
               items="${instance.configs}"
               addCaption="${%Add Parameters}"
/>
{code}
with something like
{code}
<f:descriptorList descriptors="${descriptor.getBuilderConfigDescriptors()}" instances="${instance.configs}"/>
{code}

It looks ok, but unfortunately does not save which type of parameter was selected (checked).

Could you give me hint what I need to do to get it working? Is there any other jelly tag that deals with a list and displays checkboxes? (I noticed that <f:hetero-radio/> exists, but unfortunately it allows only radio buttons.)

Best Regards,

Fred

> Allowing same type of parameter for triggered build more than once seems redundant
> ----------------------------------------------------------------------------------
>
>                 Key: JENKINS-8916
>                 URL: http://issues.jenkins-ci.org/browse/JENKINS-8916
>             Project: Jenkins
>          Issue Type: Bug
>          Components: parameterized-trigger
>    Affects Versions: current
>            Reporter: Fred G
>            Assignee: Fred G
>            Priority: Minor
>
> While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once.
> For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times.
> The only type where it might make sense is "Parameters from properties file".
> I think for every type of parameters a simple checkbox is sufficient.
> I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] Assigned: (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

     [ http://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fred G reassigned JENKINS-8916:
-------------------------------

    Assignee: huybrechts  (was: Fred G)

> Allowing same type of parameter for triggered build more than once seems redundant
> ----------------------------------------------------------------------------------
>
>                 Key: JENKINS-8916
>                 URL: http://issues.jenkins-ci.org/browse/JENKINS-8916
>             Project: Jenkins
>          Issue Type: Bug
>          Components: parameterized-trigger
>    Affects Versions: current
>            Reporter: Fred G
>            Assignee: huybrechts
>            Priority: Minor
>
> While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once.
> For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times.
> The only type where it might make sense is "Parameters from properties file".
> I think for every type of parameters a simple checkbox is sufficient.
> I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

     [ https://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on JENKINS-8916 started by Fred G.

> Allowing same type of parameter for triggered build more than once seems redundant
> ----------------------------------------------------------------------------------
>
>                 Key: JENKINS-8916
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-8916
>             Project: Jenkins
>          Issue Type: Bug
>          Components: parameterized-trigger
>    Affects Versions: current
>            Reporter: Fred G
>            Assignee: Fred G
>            Priority: Minor
>
> While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once.
> For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times.
> The only type where it might make sense is "Parameters from properties file".
> I think for every type of parameters a simple checkbox is sufficient.
> I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

     [ https://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fred G reassigned JENKINS-8916:
-------------------------------

    Assignee: Fred G  (was: huybrechts)
   

> Allowing same type of parameter for triggered build more than once seems redundant
> ----------------------------------------------------------------------------------
>
>                 Key: JENKINS-8916
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-8916
>             Project: Jenkins
>          Issue Type: Bug
>          Components: parameterized-trigger
>    Affects Versions: current
>            Reporter: Fred G
>            Assignee: Fred G
>            Priority: Minor
>
> While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once.
> For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times.
> The only type where it might make sense is "Parameters from properties file".
> I think for every type of parameters a simple checkbox is sufficient.
> I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

    [ https://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=162475#comment-162475 ]

Fred G commented on JENKINS-8916:
---------------------------------

Pull request: https://github.com/jenkinsci/parameterized-trigger-plugin/pull/20
               

> Allowing same type of parameter for triggered build more than once seems redundant
> ----------------------------------------------------------------------------------
>
>                 Key: JENKINS-8916
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-8916
>             Project: Jenkins
>          Issue Type: Bug
>          Components: parameterized-trigger
>    Affects Versions: current
>            Reporter: Fred G
>            Assignee: Fred G
>            Priority: Minor
>
> While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once.
> For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times.
> The only type where it might make sense is "Parameters from properties file".
> I think for every type of parameters a simple checkbox is sufficient.
> I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

    [ https://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=162630#comment-162630 ]

SCM/JIRA link daemon commented on JENKINS-8916:
-----------------------------------------------

Code changed in jenkins
User: Fred G
Path:
 src/main/resources/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig/config.jelly
 src/main/resources/hudson/plugins/parameterizedtrigger/BuildTriggerConfig/config.jelly
http://jenkins-ci.org/commit/parameterized-trigger-plugin/3f6097a82679a76d8b0b03498d9c9a392b77f6fc
Log:
  [FIXED JENKINS-8916] Allowing same type of parameter for triggered build
more than once seems redundant

It requires Jenkins core version 1.463 to work, but it's fully
backwards compatible.



               

> Allowing same type of parameter for triggered build more than once seems redundant
> ----------------------------------------------------------------------------------
>
>                 Key: JENKINS-8916
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-8916
>             Project: Jenkins
>          Issue Type: Bug
>          Components: parameterized-trigger
>    Affects Versions: current
>            Reporter: Fred G
>            Assignee: Fred G
>            Priority: Minor
>
> While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once.
> For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times.
> The only type where it might make sense is "Parameters from properties file".
> I think for every type of parameters a simple checkbox is sufficient.
> I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

     [ https://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

SCM/JIRA link daemon resolved JENKINS-8916.
-------------------------------------------

    Resolution: Fixed
   

> Allowing same type of parameter for triggered build more than once seems redundant
> ----------------------------------------------------------------------------------
>
>                 Key: JENKINS-8916
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-8916
>             Project: Jenkins
>          Issue Type: Bug
>          Components: parameterized-trigger
>    Affects Versions: current
>            Reporter: Fred G
>            Assignee: Fred G
>            Priority: Minor
>
> While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once.
> For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times.
> The only type where it might make sense is "Parameters from properties file".
> I think for every type of parameters a simple checkbox is sufficient.
> I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

    [ https://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=162631#comment-162631 ]

SCM/JIRA link daemon commented on JENKINS-8916:
-----------------------------------------------

Code changed in jenkins
User: Fred G
Path:
 src/main/resources/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig/config.jelly
 src/main/resources/hudson/plugins/parameterizedtrigger/BuildTriggerConfig/config.jelly
http://jenkins-ci.org/commit/parameterized-trigger-plugin/6e80ae37591b708b321b27a80a8d32012949f6a0
Log:
  Merge pull request #20 from fredg02/master

[FIXED JENKINS-8916] Allowing same type of parameter for triggered build more than once seems redundant


Compare: https://github.com/jenkinsci/parameterized-trigger-plugin/compare/76d4c9b...6e80ae3


               

> Allowing same type of parameter for triggered build more than once seems redundant
> ----------------------------------------------------------------------------------
>
>                 Key: JENKINS-8916
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-8916
>             Project: Jenkins
>          Issue Type: Bug
>          Components: parameterized-trigger
>    Affects Versions: current
>            Reporter: Fred G
>            Assignee: Fred G
>            Priority: Minor
>
> While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once.
> For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times.
> The only type where it might make sense is "Parameters from properties file".
> I think for every type of parameters a simple checkbox is sufficient.
> I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Daniel Beck commented on Bug JENKINS-8916

All parameter sources are only supported once now, i.e. it's not possible to specify multiple property files anymore?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Fred G commented on Bug JENKINS-8916

Yes, that's the only drawback with this solution. Do you have a use-case where you need to specify multiple property files?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Change By: Fred G (08/Jul/12 1:45 PM)
Assignee: Fred G Daniel Beck
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

Hi. I have several Jobs that use multiple 'parameters from properties file' parameters. I would really like to see this functionality put back in.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] [parameterized-trigger] (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
jlpinardon commented on Bug JENKINS-8916

Dear all,

I support several teams for which it is really annoying to not be able to add several property files.
So please could you either :

  • let the possibility to add several times property file type
  • or have a single property file type but allow to give a comma separated list of files.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.
 
 
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] [parameterized-trigger] (JENKINS-8916) Allowing same type of parameter for triggered build more than once seems redundant

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Fred G commented on Bug JENKINS-8916

@jlpinardon
This has already been fixed (see JENKINS-15834) and it's available in version 2.17 of the Parameterized Trigger Build Plugin.
You can specify a comma separated list of property files now.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.
 
 
Loading...