Jenkins CI › Jenkins issues

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

Classic

List

Threaded

36 messages Options

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

Roger Myung created JENKINS-12423:
-------------------------------------

Summary: Password masked by Mask Passwords are visible when using envinject plugin
Key: JENKINS-12423
URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
Project: Jenkins
Issue Type: Bug
Components: envinject, mask-passwords
Environment: envinject 1.9
mask-passwords 2.7.2
Jenkins ver. 1.424.1
Windows
Reporter: Roger Myung
Assignee: gbois

If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=157898#comment-157898 ]

SCM/JIRA link daemon commented on JENKINS-12423:
------------------------------------------------

Code changed in jenkins
User: fchabanois
Path:
src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java
http://jenkins-ci.org/commit/envinject-plugin/617aa5ee13baea71c2dfe9c52a644e82dfba5d42
Log:
Fixed JENKINS-12423

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=157901#comment-157901 ]

SCM/JIRA link daemon commented on JENKINS-12423:
------------------------------------------------

Code changed in jenkins
User: Florence.Chabanois
Path:
src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java
http://jenkins-ci.org/commit/envinject-plugin/a33b4167582f6b244d45ad5ea57da77f5e2cbc12
Log:
Fix JENKINS-12423

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158199#comment-158199 ]

SCM/JIRA link daemon commented on JENKINS-12423:
------------------------------------------------

Code changed in jenkins
User: Florence.Chabanois
Path:
src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java
http://jenkins-ci.org/commit/envinject-plugin/72951ad6bd722fe908ba58c0f05e64ae70fa22d2
Log:
Fix JENKINS-12423

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Winters updated JENKINS-12423:
-----------------------------------

Environment:
envinject 1.9
mask-passwords 2.7.2
Jenkins ver. 1.424.1
Windows
Perforce plugin 1.3.7

was:
envinject 1.9
mask-passwords 2.7.2
Jenkins ver. 1.424.1
Windows

Component/s: perforce

With Jenkins 1.450, Perforce plugin 1.3.7, EnvInject 1.17, and Mask Passwords 2.7.2, the Perforce passwords are being displayed in plain text on the "Injected Environment Variables" page. I have tried setting the passwords to be masked in the global Jenkins config as well as in the individual jobs, but nothing I have tried is masking the passwords.

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158858#comment-158858 ]

gbois commented on JENKINS-12423:
---------------------------------

I tested and I have reproduced the problem with the EnvInject and the mask-passwords plugins.

Native password parameters (provided by Jenkins core) are masked.
However, passwords provided by the mask-passwords plugin are visible.

The problem is due to the mask-passwords plugin uses custom password parameters (labeled Non stored password) and the envinject is not aware of the this specific new type.
Technically, mask-passwords plugin use the class 'com.michelin.cio.hudson.plugins.passwordparam.PasswordParameterValue' and the envinject plugin is not aware of this class.
We know if it is a password parameter only by the class itself and not by an inherited property set to a specific value (such as boolean).

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158859#comment-158859 ]

Mike Winters commented on JENKINS-12423:
----------------------------------------

In the case of the Perforce passwords, the issue was happening before I installed the Mask Passwords plugin (I only installed that in an attempt to hide the passwords). It seems that perhaps the Perforce plugin (and plugins for other source control systems?) are exposing the passwords in a way that the EnvInject plugin doesn't know to look for. I'm not sure where the best place to fix this is, or what the optimal fix should be, as I am not familiar with the Jenkins codebase or the code for any of the relevant plugins. However, the quicker a solution can be implemented, the happier I will be :). Thanks!

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158896#comment-158896 ]

SCM/JIRA link daemon commented on JENKINS-12423:
------------------------------------------------

Code changed in jenkins
User: Gregory Boissinot
Path:
src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java
http://jenkins-ci.org/commit/envinject-plugin/a7a11d9ca6ad9ca109b0a601aae7b3b5e2309d56
Log:
Fix JENKINS-12423

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

gbois resolved JENKINS-12423.
-----------------------------

Resolution: Fixed

I provided a hack on my envinject plugin to fix this issue.
This tip should work in most cases.
I tested with mask-passwork combined with the envinject plugin, it seems to be OK.

Regarding the perforce plugin, I don't know and I don't have this tool. And due to the complexity of its installation, I don't have
tested with the perforce plugin.

If the issue persists with only the perforce plugin (it's ok with the envinject and the mask-passwords plugin, reopened it with only the perforce component).

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158899#comment-158899 ]

gbois edited comment on JENKINS-12423 at 2/11/12 1:48 PM:
----------------------------------------------------------

I provided a hack on my envinject plugin to fix this issue.
This tip should work in most cases.
I tested with mask-passwords plugin combined with the envinject plugin, it seems to be OK.

Regarding the perforce plugin, I don't know and I don't have this tool. And due to the complexity of its installation, I don't have
tested with the perforce plugin.

If the issue persists with only the perforce plugin (it's ok with the envinject and the mask-passwords plugin), reopened it with only the perforce component).

was (Author: gbois):
I provided a hack on my envinject plugin to fix this issue.
This tip should work in most cases.
I tested with mask-passwords plugin combined with the envinject plugin, it seems to be OK.

Regarding the perforce plugin, I don't know and I don't have this tool. And due to the complexity of its installation, I don't have
tested with the perforce plugin.

If the issue persists with only the perforce plugin (it's ok with the envinject and the mask-passwords plugin, reopened it with only the perforce component).

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158899#comment-158899 ]

gbois edited comment on JENKINS-12423 at 2/11/12 1:47 PM:
----------------------------------------------------------

I provided a hack on my envinject plugin to fix this issue.
This tip should work in most cases.
I tested with mask-passwords plugin combined with the envinject plugin, it seems to be OK.

Regarding the perforce plugin, I don't know and I don't have this tool. And due to the complexity of its installation, I don't have
tested with the perforce plugin.

If the issue persists with only the perforce plugin (it's ok with the envinject and the mask-passwords plugin, reopened it with only the perforce component).

was (Author: gbois):
I provided a hack on my envinject plugin to fix this issue.
This tip should work in most cases.
I tested with mask-passwork combined with the envinject plugin, it seems to be OK.

Regarding the perforce plugin, I don't know and I don't have this tool. And due to the complexity of its installation, I don't have
tested with the perforce plugin.

If the issue persists with only the perforce plugin (it's ok with the envinject and the mask-passwords plugin, reopened it with only the perforce component).

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Winters reopened JENKINS-12423:
------------------------------------

From JENKINS-12747:
On further investigation, it appears that the password that the EnvInject 1.20 plugin is exposing is NOT coming from the Perforce plugin, but from the global password defined with the Mask Password plugin (Jenkins->Manage Jenkins->Configure System->Mask Passwords - Global name/password pairs). The Perforce plugin/EnvInject plugin are still showing P4CLIENT, P4PORT, and P4USER, but I'm not too worried about exposing those.

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159063#comment-159063 ]

gbois commented on JENKINS-12423:
---------------------------------

You're right.
I forgot to test global passwords with the mask-passords plugin.
However job password parameters (in the core and in the core passwords plugin) works as expected in the envinject plugin.

I looked at the code. It's a big issue.
Does it suit you if you manage global passwords by the EnvInject plugin. In my opinion, managing passwords directly in the envinject plugin is the best way to deal with this issue.

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159254#comment-159254 ]

SCM/JIRA link daemon commented on JENKINS-12423:
------------------------------------------------

Code changed in jenkins
User: Gregory Boissinot
Path:
src/main/java/org/jenkinsci/plugins/envinject/EnvInjectGlobalPasswordEntry.java
src/main/java/org/jenkinsci/plugins/envinject/EnvInjectGlobalPasswordWrapper.java
src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
src/main/java/org/jenkinsci/plugins/envinject/EnvInjectNodeProperty.java
src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectGlobalPasswordRetriever.java
src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectNodeProperty/global.jelly
src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectNodeProperty/help-name.html
src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectNodeProperty/help-password.html
src/main/resources/org/jenkinsci/plugins/envinject/Messages.properties
src/main/webapp/help-buildWrapperGlobalPasswords.html
http://jenkins-ci.org/commit/envinject-plugin/9bbe67a0f9cb48c511d679724fb857e6e6e8cd53
Log:
Add the ability to inject global passwords in the EnvInject plugin
Fix JENKINS-12423

Compare: https://github.com/jenkinsci/envinject-plugin/compare/842c9d5...9bbe67a

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Walter Kacynski reopened JENKINS-12423:
---------------------------------------

I'm trying to work thru this issue as well but I can't seem to find the necessary options to hide this information from the Injected Environment Variables screen. I also found JENKINS-12161 and linked that in, but it doesn't seem to make a difference.

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

gbois resolved JENKINS-12423.
-----------------------------

Resolution: Fixed

In >Manage Jenkins> Configure System
Add global password

Then, in the job configuration page
in the Build environment section, check 'Inject global passwords as environment variables'

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: gbois
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12423) Password masked by Mask Passwords are visible when using envinject plugin

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Natalia Naumova reopened JENKINS-12423:
---------------------------------------

jenkins 1.463
Envinject 1.50
mask-password 2.7.2
still reproducible

> Password masked by Mask Passwords are visible when using envinject plugin
> -------------------------------------------------------------------------
>
> Key: JENKINS-12423
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12423
> Project: Jenkins
> Issue Type: Bug
> Components: envinject, mask-passwords, perforce
> Environment: envinject 1.9
> mask-passwords 2.7.2
> Jenkins ver. 1.424.1
> Windows
> Perforce plugin 1.3.7
> Reporter: Roger Myung
> Assignee: Gregory Boissinot
>
> If I use the mask-passwords plugin to create a masked password, and also use the envinject plugin to setup an environment, the masked password is visible from the "Injected Environment Variables" link for each build.