[JIRA] (JENKINS-14144) Build config history getting spammed

Roman Prots' created JENKINS-14144

Build config history getting spammed

Issue Type:	Bug
Affects Versions:	current
Assignee:	Gregory Boissinot
Components:	envinject
Created:	19/Jun/12 12:41 PM
Description:	See http://www.mail-archive.com/jenkinsci-users@.../msg02063.html
Project:	Jenkins
Priority:	Major
Reporter:	Roman Prots'

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Gregory Boissinot started work on JENKINS-14144

Build config history getting spammed

Change By:	Gregory Boissinot (20/Jun/12 7:53 PM)
Status:	Open In Progress

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Gregory Boissinot commented on JENKINS-14144

Build config history getting spammed

Which version do you use? In a recent version, the line doesn't appear anymore.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Roman Prots' commented on JENKINS-14144

Build config history getting spammed

Using version 1.55 and Jenkins 1.466 and issue can still be seen. Probably need to upgrade Jenkins also?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Gregory Boissinot commented on JENKINS-14144

Build config history getting spammed

I'm sorry it seems I misunderstood the initial request. What is really the issue (is the additional line still in XML after the build run)? EnvInject plugin add technically this line and the line is removed after the run (it is a hack to achieve some plugin objectives). However it has to be transparent for end users.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Roman Prots' commented on JENKINS-14144

Build config history getting spammed

Any thoughts on how this can be done differently?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Darragh Bailey updated JENKINS-14144

Build config history getting spammed

Change By:	Darragh Bailey (22/Jun/12 3:45 PM)
Component/s:	jobconfighistory

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Darragh Bailey commented on JENKINS-14144

Build config history getting spammed

Anyway for it to be ignored by the build config history plugin?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Gregory Boissinot updated JENKINS-14144

Build config history getting spammed

Restrict to envinject plugin
Change By:	Gregory Boissinot (23/Jun/12 5:49 PM)
Component/s:	jobconfighistory

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Gregory Boissinot commented on JENKINS-14144

Build config history getting spammed

@Roman Could you upgrade to latest EnvInject version and check if the issue persists? Thanks.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Roman Prots' commented on JENKINS-14144

Build config history getting spammed

Still reproduces with version 1.55 and Jenkins 1.471.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Gregory Boissinot commented on JENKINS-14144

Build config history getting spammed

I don't reproduce the problem. Could you try to isolate the problem and attach a zip of the job configuration folder (with some build folders)? Thanks

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Roman Prots' commented on JENKINS-14144

Build config history getting spammed

Still reproduces with version 1.56 and Jenkins 1.471.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Roman Prots' commented on JENKINS-14144

Build config history getting spammed

Reproduces when you enable "Prepare an environment for the run" in the job configuration.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Gregory Boissinot commented on JENKINS-14144

Build config history getting spammed

Please attach your build.xml file containing the added line.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Gregory Boissinot commented on JENKINS-14144

Build config history getting spammed

Any help is welcome to help me to close this issue. Thanks

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Darragh Bailey updated JENKINS-14144

Build config history getting spammed

created a simple job that uses sleep. Seems you need to give the config history plugin long enough to both spot the change to the build.xml and be able to create a back of the change before the build job completes. Added xml from http://localhost:8080/pluginManager/api/xml?depth=1 as well as xml files for envinject, jobConfigHistory and system configuration. Versions Jenkins: 1.472 EnvInject: 1.56 JobConfigHistory: 1.13
Change By:	Darragh Bailey (02/Jul/12 1:04 PM)
Attachment:	test-job.tar.gz
Attachment:	plugins.xml
Attachment:	config.xml
Attachment:	envInject.xml
Attachment:	jobConfigHistory.xml

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Jørgen Tjernø commented on JENKINS-14144

Build config history getting spammed

I'm seeing this issue too, and I'd love to see it fixed - it makes the Job Config History plugin a lot less usable.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Gregory Boissinot closed JENKINS-14144 as Cannot Reproduce

Build config history getting spammed

I don't know the jobConfigHistory plugin. I can't reproduce the problem, maybe despite all of theses exchanges, I don't understand the real problem.
Change By:	Gregory Boissinot (09/Aug/12 3:05 PM)
Status:	In Progress Closed
Resolution:	Cannot Reproduce

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Darragh Bailey commented on JENKINS-14144

Build config history getting spammed

I can still reproduce with Jenkins 1.477 and EnvInject 1.66, I literally only have the jobConfigHistory and envInject plugins installed on top of a clean jenkins and a simple job that only uses 'sleeps 15' as the only build step. OS = Linux. Summary of what I understand to be happening: envinject modifieds the config.xml adding a buildwrapper entry when starting the build if there is an environment variable to be injected. job config history plugin is monitoring for changes to the config.xml file, spots the change and saves the new file envinject removes it's modification once the build is finished and rewrites the config.xml file job config history plugin spots the second modification, and saves another new file. jobConfigHistory extends the SaveableListener with a class that catches any time a change is saved (I suspect using jenkins API's) to any build config files. If I add a log recorder in jenkins to monitor hudson.plugins.jobConfigHistory at the "all" level I see the following output from executing the sample job I attached just once: Aug 9, 2012 5:52:27 PM hudson.plugins.jobConfigHistory.JobConfigHistorySaveableListener FINEST: onChange for test-job-buildhistoryconfig #9 done. Aug 9, 2012 5:52:27 PM hudson.plugins.jobConfigHistory.JobConfigHistorySaveableListener FINEST: In onChange for test-job-buildhistoryconfig #9 Aug 9, 2012 5:52:27 PM hudson.plugins.jobConfigHistory.JobConfigHistorySaveableListener FINEST: onChange for hudson.model.FreeStyleProject@6eef9525[test-job-buildhistoryconfig] done. Aug 9, 2012 5:52:27 PM hudson.plugins.jobConfigHistory.JobConfigHistorySaveableListener FINEST: In onChange for hudson.model.FreeStyleProject@6eef9525[test-job-buildhistoryconfig] Aug 9, 2012 5:52:12 PM hudson.plugins.jobConfigHistory.JobConfigHistorySaveableListener FINEST: onChange for hudson.model.FreeStyleProject@6eef9525[test-job-buildhistoryconfig] done. Aug 9, 2012 5:52:12 PM hudson.plugins.jobConfigHistory.JobConfigHistorySaveableListener FINEST: In onChange for hudson.model.FreeStyleProject@6eef9525[test-job-buildhistoryconfig] The times recorded correspond with the start (5:52:12) and finish times of the job (5:52:27). I did notice before that if the job finishes too quickly, < 5 seconds, sometimes the jobConfigHistory plugin may not see the differences long enough to backup the modified config.xml. So it may be necessary to extend the time taken for the build step to be longer, and you need to configure envInject in the job to have some property getting injected in order for the buildwrapper to get added/removed to/from the config.xml file at runtime. Basically any time the envinject plugin modifies the build job config.xml and saves the changes, jobConfigHistory plugin is going to fire and create a new backup of the xml file. This renders jobConfigHistory virtually useless for any build job using envInject.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira