Quantcast

[JIRA] (JENKINS-15045) Support Github commit status API

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org
Issue Type: New Feature New Feature
Assignee: Unassigned
Components: github
Created: 05/Sep/12 8:12 AM
Description:

Github have announced support for a commit status API. Each SHA can have one or more build statuses attached to it. https://github.com/blog/1227-commit-status-api
http://developer.github.com/v3/repos/statuses/

Project: Jenkins
Priority: Major Major
Reporter: David Henderson
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org

I'm adding the base functionalities in github-api now.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Eric Jensen commented on New Feature JENKINS-15045

would love to see this feature. it's supported in github-api 1.32

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

I'd also love to see this feature!

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Juan Muller commented on New Feature JENKINS-15045

Have been looking forward for its implementation!

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

The github-api library has this implemented. The next step is someone to take advantages of it in the github plugin.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

Code changed in jenkins
User: Nicolas De Loof
Path:
pom.xml
src/main/java/com/cloudbees/jenkins/GitHubCommitNotifier.java
http://jenkins-ci.org/commit/github-plugin/1919a272a244043c5ca5cd0f7e6ed300b3e55c8f
Log:
JENKINS-15045 use github commit status API

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

Created an experimental notifier to use this API :
https://github.com/jenkinsci/github-plugin/tree/commit-status-api

Status only get's displayed on github UI when commit is part of a pull request, so there is no benefits for github plugin
ghprb-plugin may use it to set status in replacement for comments

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

@Nicolas - that looks good - I'm not sure it would belong in ghprb-plugin though.

My use case:

  • Push a commit
  • The github plugin triggers a build
  • The github plugin reports status of build for the SHA that it built
  • I then create a pull request. In theory, the pull request will show the status of the build (once it is complete)
  • Merge the PR if the status is success or make changes if it fails

While this would fit with the pull request builder, I don't think it should be required that you use that to create the pull requests if you want the build statuses pushed to github.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Reto Kaiser commented on New Feature JENKINS-15045

I agree with @David on the functionality.
When you create a pull request, Github will show the status for every push in it (http://i.imgur.com/PZot3.png).

@Nicolas: I looked at the code - looks like a generic Notifier, so this should work for all builds right?
I this planned to go into the plugin?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Juan Muller commented on New Feature JENKINS-15045

@Nicolas, your branch looks good. I am with @david in that it would definitely help our work-flow. Will you create a pull request for this work?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

Any work I can do to move this forward?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Jesse Glick commented on New Feature JENKINS-15045
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

Code changed in jenkins
User: Nicolas De loof
Path:
src/main/java/com/cloudbees/jenkins/GitHubCommitNotifier.java
http://jenkins-ci.org/commit/github-plugin/ef22d0173c0139a8d7f5531480befc3f94a5efc9
Log:
Merge pull request #23 from jenkinsci/commit-status-api

[FIXED JENKINS-15045] Commit status API

Compare: https://github.com/jenkinsci/github-plugin/compare/c566697220f7...ef22d0173c01


You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.
 
 
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15045) Support Github commit status API

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Change By: SCM/JIRA link daemon (30/Jan/13 6:42 PM)
Status: Open Resolved
Resolution: Fixed
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.
 
 
Loading...