[JIRA] (JENKINS-16695) clone workspace scm only saves workspace.tar.gz, not workspace.zip

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] (JENKINS-16695) clone workspace scm only saves workspace.tar.gz, not workspace.zip

JIRA noreply@jenkins-ci.org
Issue Type: Bug Bug
Assignee: Unassigned
Components: clone-workspace-scm
Created: 07/Feb/13 10:57 PM
Description:

When selecting which format to save the file as, it seems it doesn't matter what you choose (Gzipped tar or Zipped), it always saves it as "workspace.tar.gz".

This causes issues when the next job tries to build but can't find the "workspace.zip" file.

Steps:
In the publisher, pick Zipped
Run the build
Go to $JENKINS_HOME/jobs/$BUILD/lastSuccessful/
Notice it is saved as .tar.gz, not .zip

Environment: Ubuntu
Project: Jenkins
Priority: Major Major
Reporter: Pedro Rodriguez
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.
 
 
Reply | Threaded
Open this post in threaded view
|

[JIRA] (JENKINS-16695) clone workspace scm only saves workspace.tar.gz, not workspace.zip

JIRA noreply@jenkins-ci.org

I found out the issue. Here's a patch for it:

From 1515671039082546ba42a2739f3d079c556ac5c7 Mon Sep 17 00:00:00 2001
From: Pedro Rodriguez <[hidden email]>
Date: Mon, 4 Mar 2013 14:16:37 -0500
Subject: [PATCH] Fixed bug that caused all files to be saved as *.tar.gz even
is ZIPPED was selected


.../plugins/cloneworkspace/CloneWorkspaceUtil.java | 5 +++--
1 files changed, 3 insertions, 2 deletions

diff --git a/src/main/java/hudson/plugins/cloneworkspace/CloneWorkspaceUtil.java b/src/main/java/hudson/plugins/cloneworkspace/CloneWorkspaceUtil.java
index 1acff77..4ac5712 100644
— a/src/main/java/hudson/plugins/cloneworkspace/CloneWorkspaceUtil.java
+++ b/src/main/java/hudson/plugins/cloneworkspace/CloneWorkspaceUtil.java
@@ -95,9 +95,10 @@ public class CloneWorkspaceUtil {

public static String getFileNameForMethod(String method)
{

  • if (method == "ZIP")
    Unknown macro: {+ if (method.equals("ZIP")) { return "workspace.zip"; - } else { + }+ else { return "workspace.tar.gz"; } }

    • 1.7.4.4
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.
 
 
Reply | Threaded
Open this post in threaded view
|

[JIRA] (JENKINS-16695) clone workspace scm only saves workspace.tar.gz, not workspace.zip

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
 
Pedro Rodriguez edited a comment on Bug JENKINS-16695

I found the issue. I've attached a patch for it.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.
 
 
Reply | Threaded
Open this post in threaded view
|

[JIRA] (JENKINS-16695) clone workspace scm only saves workspace.tar.gz, not workspace.zip

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Change By: Pedro Rodriguez (04/Mar/13 7:38 PM)
Attachment: file_name_fix.patch
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.
 
 
Reply | Threaded
Open this post in threaded view
|

[JIRA] (JENKINS-16695) clone workspace scm only saves workspace.tar.gz, not workspace.zip

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Change By: Pedro Rodriguez (04/Mar/13 7:47 PM)
Assignee: abayer
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.
 
 
Reply | Threaded
Open this post in threaded view
|

[JIRA] (JENKINS-16695) clone workspace scm only saves workspace.tar.gz, not workspace.zip

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Change By: Pedro Rodriguez (04/Mar/13 8:53 PM)
Component/s: clone-workspace
Component/s: clone-workspace-scm
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.
 
 
Reply | Threaded
Open this post in threaded view
|

[JIRA] [clone-workspace] (JENKINS-16695) clone workspace scm only saves workspace.tar.gz, not workspace.zip

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

I tried your patch, but the file name is still "tar.gz". I try to use the clone as SCM on a different node, than it has been created.

In the test cases the method string sometimes contains "zip" so we should compare with ignore case?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.
 
 
Reply | Threaded
Open this post in threaded view
|

[JIRA] [clone-workspace] (JENKINS-16695) clone workspace scm only saves workspace.tar.gz, not workspace.zip

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

There is a pull request for this, so ignore the patch.

https://github.com/jenkinsci/jenkins-clone-workspace-scm-plugin/pull/7

Though it is the same change, so the patch should work. I did not test multiple nodes, but I don't see how that would matter.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.
 
 
Reply | Threaded
Open this post in threaded view
|

[JIRA] [clone-workspace] (JENKINS-16695) clone workspace scm only saves workspace.tar.gz, not workspace.zip

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
evernat resolved Bug JENKINS-16695 as Fixed

This is merged and released.

Change By: evernat (05/Apr/14 3:16 PM)
Status: Open Resolved
Resolution: Fixed
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.