Quantcast

[JIRA] (JENKINS-8043) "Reload Configuration from Disk" loses labels for swarm-clients

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] (JENKINS-8043) "Reload Configuration from Disk" loses labels for swarm-clients

JIRA noreply@jenkins-ci.org

    [ https://issues.jenkins-ci.org/browse/JENKINS-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160307#comment-160307 ]

Marc Günther edited comment on JENKINS-8043 at 3/15/12 7:17 PM:
----------------------------------------------------------------

Just posted a fix here: https://github.com/jenkinsci/jenkins/pull/408

The problem is, that swarm clients from the Jenkins.slaves array are not stored into the config.xml (being an EphemeralNode). But when Reloading from Disk, the array is overwritten with only the entries from the file. The swarm clients are then lost from the slaves array, but still exist in the list of computers (Jenkins.computers). This leads to the inconsistent behaviour described above.

The fix simply remembers all existing swarm clients, and re-adds them to the slaves array after the reload finished.
               
      was (Author: marc_guenther):
    Just posted a fix here: https://github.com/jenkinsci/jenkins/pull/408

The problem is, that swarm clients from the Jenkins.slaves array are not stored into the config.xml (being an EphemeralNode). But when Reloading from Disk, the array is overwritten with only the entries from the file. The swarm clients are then lost from the slaves array, but still exist in the list of computers (Jenkins.computers). This leads to the inconsistent behaviour described above.

The fix simpile remembers all existing swarm clients, and re-adds them to the slaves array after the reload finished.
                 

> "Reload Configuration from Disk" loses labels for swarm-clients
> ---------------------------------------------------------------
>
>                 Key: JENKINS-8043
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-8043
>             Project: Jenkins
>          Issue Type: Bug
>          Components: swarm
>            Reporter: voorth
>            Assignee: abayer
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Loading...