[JIRA] Updated: (JENKINS-5784) Usage of kill in logrotate script is non-portable

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (JENKINS-5784) Usage of kill in logrotate script is non-portable

JIRA noreply@jenkins-ci.org

     [ http://issues.jenkins-ci.org/browse/JENKINS-5784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olav Reinert updated JENKINS-5784:
----------------------------------

    Attachment: jenkins-logrotate.patch

New patch to fix logrotate script for openSUSE. It works also when Jenkins is not running. Also, it checks that the ALRM signal really is sent to Jenkins and not some other process.

> Usage of kill in logrotate script is non-portable
> -------------------------------------------------
>
>                 Key: JENKINS-5784
>                 URL: http://issues.jenkins-ci.org/browse/JENKINS-5784
>             Project: Jenkins
>          Issue Type: Bug
>          Components: other
>            Reporter: rombert
>         Attachments: hudson.logrotate.patch2010-10-20pdurbin, jenkins-logrotate.patch
>
>
> The logrotate script uses
> {code}kill -SIGALRM `cat /var/run/hudson.pid`{code}
> which works fine for the bash builtin, but fails for /bin/kill, which only accepts
> {code}usage: kill [ -s signal | -p ] [ -a ] pid ...
>        kill -l [ signal ]{code}
> on CentOS 5.
> Using kill -s SIGALRM would make both variants happy and increase portability.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira