JUnit plugin defining adding XML Parse Configurer?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

JUnit plugin defining adding XML Parse Configurer?

Jaromir Hamala
Hello,

I wonder what's the reason for the JUnit plugin to define a new global XML Parser Configurator? I believe the XMLEntityResolver is only useful for the junit plugin itself - when it's parsing TestNG output. Other parts of Jenkins do not benefit from this extension and I don't understand why the resolver is registered globally. 

I realized this is causing performance issues: The JUnit plugin initiates a RPC to fetch parser configurators before parsing *each* test result XML file. Now image what happens when you have 1000's XML files to parse and a non-trivial network latency between a master Jenkins installation and slave agents. I had sent a PR to cache the parser configurators and it was suggested to completely remove the global registration - here is a PR with a candidate fix. 

Can anyone have a look at the new PR

Cheers,
Jaromir

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/8983ae85-7021-4e60-87b4-12d4bedee299%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Loading...