Java11 compatibility and guice 4.0 vs. 4.2.3

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Java11 compatibility and guice 4.0 vs. 4.2.3

Fritz Elfert
Hi *,

I recently got a PR for the jclouds-plugin which claims to establish java11 compatibility.
Knowing that jclouds-2.2.x is NOT java11-ready yet, I postponed this until jclouds-2.3.0 is out.
Well, yesterday they released 2.3.0 and I started working on that PR. Unfortunately, it turns out
that jclouds-2.3.0 depends on guice-4.2.3. Apparently they did this because of java11 compatibility issues.
A short search for java11 compatibility of guice-4.0 shows, that it is definitively *NOT* java11-ready.

The maven-enforcer blocks this currently:

[WARNING] Rule 4: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for com.google.inject:guice:4.0 paths to dependency are:
+-org.jenkins-ci.plugins:jclouds-shaded:2.21-SNAPSHOT
   +-org.apache.jclouds:jclouds-core:2.3.0
     +-com.google.inject:guice:4.0 (managed) <-- com.google.inject:guice:4.2.3
and
+-org.jenkins-ci.plugins:jclouds-shaded:2.21-SNAPSHOT
   +-org.apache.jclouds:jclouds-core:2.3.0
     +-com.google.inject:guice:4.0 (managed) <-- com.google.inject:guice:4.2.3
and
+-org.jenkins-ci.plugins:jclouds-shaded:2.21-SNAPSHOT
   +-org.jenkins-ci.main:jenkins-core:2.263.1
     +-com.google.inject:guice:4.0 (managed) <-- com.google.inject:guice:4.2.3
and
+-org.jenkins-ci.plugins:jclouds-shaded:2.21-SNAPSHOT
   +-org.apache.jclouds:jclouds-core:2.3.0
     +-com.google.inject.extensions:guice-assistedinject:4.2.3
       +-com.google.inject:guice:4.0 (managed) <-- com.google.inject:guice:4.2.3

This raises the question:
If jenkins claims to be java11-compatible, should it not bump up it's dependency on guice to 4.2.3 as well?

Thanks
  -Fritz


--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/f3ecc679-6de5-dc0c-4033-b56005042128%40fritz-elfert.de.

OpenPGP_0x6E8338980332A6B0.asc (14K) Download Attachment
OpenPGP_signature (209 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Java11 compatibility and guice 4.0 vs. 4.2.3

Mark Waite-2
Thanks for sharing what you've learned.  The portions of guice and guava that are used by Jenkins have been working since we introduced Java 11 support last year.  Upgrading guice will also need to be paired with an upgrade of guava.

See https://github.com/jenkinsci/jenkins/pull/5340 and https://github.com/jenkinsci/jenkins/pull/5059 and https://github.com/jenkinsci/jenkins/pull/4051 and https://github.com/jenkinsci/jenkins/pull/5200 and https://github.com/jenkinsci/jenkins/pull/5217 for the most recent efforts in that regard.

Thanks,
Mark Waite
On Sunday, March 7, 2021 at 6:23:50 AM UTC-7 [hidden email] wrote:
Hi *,

I recently got a PR for the jclouds-plugin which claims to establish java11 compatibility.
Knowing that jclouds-2.2.x is NOT java11-ready yet, I postponed this until jclouds-2.3.0 is out.
Well, yesterday they released 2.3.0 and I started working on that PR. Unfortunately, it turns out
that jclouds-2.3.0 depends on guice-4.2.3. Apparently they did this because of java11 compatibility issues.
A short search for java11 compatibility of guice-4.0 shows, that it is definitively *NOT* java11-ready.

The maven-enforcer blocks this currently:

[WARNING] Rule 4: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for com.google.inject:guice:4.0 paths to dependency are:
+-org.jenkins-ci.plugins:jclouds-shaded:2.21-SNAPSHOT
+-org.apache.jclouds:jclouds-core:2.3.0
+-com.google.inject:guice:4.0 (managed) <-- com.google.inject:guice:4.2.3
and
+-org.jenkins-ci.plugins:jclouds-shaded:2.21-SNAPSHOT
+-org.apache.jclouds:jclouds-core:2.3.0
+-com.google.inject:guice:4.0 (managed) <-- com.google.inject:guice:4.2.3
and
+-org.jenkins-ci.plugins:jclouds-shaded:2.21-SNAPSHOT
+-org.jenkins-ci.main:jenkins-core:2.263.1
+-com.google.inject:guice:4.0 (managed) <-- com.google.inject:guice:4.2.3
and
+-org.jenkins-ci.plugins:jclouds-shaded:2.21-SNAPSHOT
+-org.apache.jclouds:jclouds-core:2.3.0
+-com.google.inject.extensions:guice-assistedinject:4.2.3
+-com.google.inject:guice:4.0 (managed) <-- com.google.inject:guice:4.2.3

This raises the question:
If jenkins claims to be java11-compatible, should it not bump up it's dependency on guice to 4.2.3 as well?

Thanks
-Fritz


--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/5e8be1f2-45b9-4144-893c-e3fde439f344n%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Java11 compatibility and guice 4.0 vs. 4.2.3

Mark Waite-2
Refer also to draft Jenkins Enhancement Proposal at https://github.com/jenkinsci/jep/pull/336

On Sunday, March 7, 2021 at 9:58:55 AM UTC-7 Mark Waite wrote:
Thanks for sharing what you've learned.  The portions of guice and guava that are used by Jenkins have been working since we introduced Java 11 support last year.  Upgrading guice will also need to be paired with an upgrade of guava.

Thanks,
Mark Waite
On Sunday, March 7, 2021 at 6:23:50 AM UTC-7 [hidden email] wrote:
Hi *,

I recently got a PR for the jclouds-plugin which claims to establish java11 compatibility.
Knowing that jclouds-2.2.x is NOT java11-ready yet, I postponed this until jclouds-2.3.0 is out.
Well, yesterday they released 2.3.0 and I started working on that PR. Unfortunately, it turns out
that jclouds-2.3.0 depends on guice-4.2.3. Apparently they did this because of java11 compatibility issues.
A short search for java11 compatibility of guice-4.0 shows, that it is definitively *NOT* java11-ready.

The maven-enforcer blocks this currently:

[WARNING] Rule 4: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for com.google.inject:guice:4.0 paths to dependency are:
+-org.jenkins-ci.plugins:jclouds-shaded:2.21-SNAPSHOT
+-org.apache.jclouds:jclouds-core:2.3.0
+-com.google.inject:guice:4.0 (managed) <-- com.google.inject:guice:4.2.3
and
+-org.jenkins-ci.plugins:jclouds-shaded:2.21-SNAPSHOT
+-org.apache.jclouds:jclouds-core:2.3.0
+-com.google.inject:guice:4.0 (managed) <-- com.google.inject:guice:4.2.3
and
+-org.jenkins-ci.plugins:jclouds-shaded:2.21-SNAPSHOT
+-org.jenkins-ci.main:jenkins-core:2.263.1
+-com.google.inject:guice:4.0 (managed) <-- com.google.inject:guice:4.2.3
and
+-org.jenkins-ci.plugins:jclouds-shaded:2.21-SNAPSHOT
+-org.apache.jclouds:jclouds-core:2.3.0
+-com.google.inject.extensions:guice-assistedinject:4.2.3
+-com.google.inject:guice:4.0 (managed) <-- com.google.inject:guice:4.2.3

This raises the question:
If jenkins claims to be java11-compatible, should it not bump up it's dependency on guice to 4.2.3 as well?

Thanks
-Fritz


--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/55fc1b1f-1885-48a6-a180-11bdc46c6cb5n%40googlegroups.com.