Kohsuke you are awesome!

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Kohsuke you are awesome!

Ned Collyer
The maven modifications you did in 1.133 are great.  I really appreciate this getting fixed so promptly.

Ok enough of the praise :)

os: centos
slave: centos
hudson: 1.133


Small bug,
I had a project with a grey icon. "The project has never been built before, or the project is disabled"

The first build failed, and even on refresh, this icon is still grey (and flashing because I have started another build of the same project).

The individual failed module is red, and the parent should reflect this state.

So, it looks like a modules status is not propagated correctly to the root project.
Reply | Threaded
Open this post in threaded view
|

Re: Kohsuke you are awesome!

Kohsuke Kawaguchi
Administrator
Ned Collyer wrote:
> The maven modifications you did in 1.133 are great.  I really appreciate this
> getting fixed so promptly.

The truth is, this has been an issue for a long time and badly needed to
be fixed.


>
> Ok enough of the praise :)
>
> os: centos
> slave: centos
> hudson: 1.133
>
>
> Small bug,
> I had a project with a grey icon. "The project has never been built before,
> or the project is disabled"
>
> The first build failed, and even on refresh, this icon is still grey (and
> flashing because I have started another build of the same project).
>
> The individual failed module is red, and the parent should reflect this
> state.
>
> So, it looks like a modules status is not propagated correctly to the root
> project.
Hmm... the color of the project is determined mostly by the color of the
latest build of the project, and the color of a build as a whole is
determined by the sum of all colors of all the module builds.

I'm not sure if I'm following what you are saying. Perhaps a screenshot
would be helpful.

Note that a build in a queue that's not executed yet is always displayed
as grey. Maybe the legend needs to cover that case?

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Kohsuke you are awesome!

Ned Collyer

kohsuke wrote
Ned Collyer wrote:
> The maven modifications you did in 1.133 are great.  I really appreciate this
> getting fixed so promptly.

The truth is, this has been an issue for a long time and badly needed to
be fixed.


>
> Ok enough of the praise :)
>
> os: centos
> slave: centos
> hudson: 1.133
>
>
> Small bug,
> I had a project with a grey icon. "The project has never been built before,
> or the project is disabled"
>
> The first build failed, and even on refresh, this icon is still grey (and
> flashing because I have started another build of the same project).
>
> The individual failed module is red, and the parent should reflect this
> state.
>
> So, it looks like a modules status is not propagated correctly to the root
> project.

Hmm... the color of the project is determined mostly by the color of the
latest build of the project, and the color of a build as a whole is
determined by the sum of all colors of all the module builds.

I'm not sure if I'm following what you are saying. Perhaps a screenshot
would be helpful.

Note that a build in a queue that's not executed yet is always displayed
as grey. Maybe the legend needs to cover that case?
 
I've sent you screenshots to your email.

Basically the Job status is wrong IMHO.

Because the modules are now run serial, any module failure should be a build failure for the job.

Summing up the colours seems bizare, because if 1 module passes, 1 module fails and 20 modules are pending, then the Job should be in Failed state.

Not be in "pending" state as it currently is.