Maven Projects with dependencies is too eager since 1.481

[Larry Shatzer, Jr.]

I've noticed something weird with Maven projects that are set to build downstream jobs if there is a SNAPSHOT dependency. It now lists jobs as dependencies (and builds them) even if it is not a SNAPSHOT dependency but a regular dependency.

It looks like the code for JENKINS-12735 to allow version ranges is causing this. If you use version of <version>1.0.0</version>, that should not trigger it, but the other uses like [1.0.0,2.0.0), etc. should. This is causing lots of extra unnecessary builds when you have a lot of projects that are dependent on each other, but set to a release of the other and not a SNAPSHOT.

-- Larry

[Arnaud Héritier]

Hi,

  +1000 with Larry

  I also noticed this issue triggering many many useless builds between projects.

  I was also suspecting this change as the root cause of the issue.

  Is there already an issue opened about this regression ?

  I'm in favor to revert JENKINS-12735 if someone don't find a fix quickly

  Cheers,

Arnaud

On Wed, Sep 19, 2012 at 5:04 PM, Larry Shatzer, Jr. <[hidden email]> wrote:

I've noticed something weird with Maven projects that are set to build downstream jobs if there is a SNAPSHOT dependency. It now lists jobs as dependencies (and builds them) even if it is not a SNAPSHOT dependency but a regular dependency.

It looks like the code for JENKINS-12735 to allow version ranges is causing this. If you use version of <version>1.0.0</version>, that should not trigger it, but the other uses like [1.0.0,2.0.0), etc. should. This is causing lots of extra unnecessary builds when you have a lot of projects that are dependent on each other, but set to a release of the other and not a SNAPSHOT.

-- Larry

--

-----

Arnaud Héritier

06-89-76-64-24

http://aheritier.net

Mail/GTalk: [hidden email]

Twitter/Skype : aheritier

[Olivier Lamy-2]

+1

2012/9/24 Arnaud Héritier <[hidden email]>:

> Hi,
>
>   +1000 with Larry
>   I also noticed this issue triggering many many useless builds between
> projects.
>   I was also suspecting this change as the root cause of the issue.
>   Is there already an issue opened about this regression ?
>   I'm in favor to revert JENKINS-12735 if someone don't find a fix quickly
>
>   Cheers,
>
> Arnaud
>
> On Wed, Sep 19, 2012 at 5:04 PM, Larry Shatzer, Jr. <[hidden email]>
> wrote:
>>
>> I've noticed something weird with Maven projects that are set to build
>> downstream jobs if there is a SNAPSHOT dependency. It now lists jobs as
>> dependencies (and builds them) even if it is not a SNAPSHOT dependency but a
>> regular dependency.
>>
>> It looks like the code for JENKINS-12735 to allow version ranges is
>> causing this. If you use version of <version>1.0.0</version>, that should
>> not trigger it, but the other uses like [1.0.0,2.0.0), etc. should. This is
>> causing lots of extra unnecessary builds when you have a lot of projects
>> that are dependent on each other, but set to a release of the other and not
>> a SNAPSHOT.
>>
>> -- Larry
>
>
>
>
> --
> -----
> Arnaud Héritier
> 06-89-76-64-24
> http://aheritier.net
> Mail/GTalk: [hidden email]
> Twitter/Skype : aheritier
>

--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

[domi]

+1 too

On 24.09.2012, at 22:42, Arnaud Héritier <[hidden email]> wrote:

Hi,

  +1000 with Larry

  I also noticed this issue triggering many many useless builds between projects.

  I was also suspecting this change as the root cause of the issue.

  Is there already an issue opened about this regression ?

  I'm in favor to revert JENKINS-12735 if someone don't find a fix quickly

  Cheers,

Arnaud

On Wed, Sep 19, 2012 at 5:04 PM, Larry Shatzer, Jr. <[hidden email]> wrote:

I've noticed something weird with Maven projects that are set to build downstream jobs if there is a SNAPSHOT dependency. It now lists jobs as dependencies (and builds them) even if it is not a SNAPSHOT dependency but a regular dependency.

It looks like the code for JENKINS-12735 to allow version ranges is causing this. If you use version of <version>1.0.0</version>, that should not trigger it, but the other uses like [1.0.0,2.0.0), etc. should. This is causing lots of extra unnecessary builds when you have a lot of projects that are dependent on each other, but set to a release of the other and not a SNAPSHOT.

-- Larry

--

-----

Arnaud Héritier

06-89-76-64-24

http://aheritier.net

Mail/GTalk: [hidden email]

Twitter/Skype : aheritier

[liam.j.bennett]

While this is clearly a bug that needs fixing it would be useful to have the functionality to resolve downstream/upstream jobs with a fixed version (configurable of-course). 

We no longer use SNAPSHOTS but use release versions with BUILD_ID-BUILD_NUMBER and dynamically update dependencies using the maven-versions-plugin at build time. At the moment we are having to manually configure downstream/upstream relationships so having Jenkins auto-resolve them for fixed versions would be very useful to us.

On Wednesday, September 19, 2012 4:04:37 PM UTC+1, Larry Shatzer, Jr. wrote:

I've noticed something weird with Maven projects that are set to build downstream jobs if there is a SNAPSHOT dependency. It now lists jobs as dependencies (and builds them) even if it is not a SNAPSHOT dependency but a regular dependency.

It looks like the code for JENKINS-12735 to allow version ranges is causing this. If you use version of <version>1.0.0</version>, that should not trigger it, but the other uses like [1.0.0,2.0.0), etc. should. This is causing lots of extra unnecessary builds when you have a lot of projects that are dependent on each other, but set to a release of the other and not a SNAPSHOT.

-- Larry

[Larry Shatzer, Jr.]

What if we made the maven plugin have an extension point for other plugins to add behavior to dependencies and what to do? I could imagine the stock ones being SNAPSHOTS and the version range as being two options. Then others, like Liam, could add behavior that had all dependencies trigger builds in a separate plugin (or in core).

On Thu, Sep 27, 2012 at 10:01 AM, liam.j.bennett <[hidden email]> wrote:

While this is clearly a bug that needs fixing it would be useful to have the functionality to resolve downstream/upstream jobs with a fixed version (configurable of-course). 

We no longer use SNAPSHOTS but use release versions with BUILD_ID-BUILD_NUMBER and dynamically update dependencies using the maven-versions-plugin at build time. At the moment we are having to manually configure downstream/upstream relationships so having Jenkins auto-resolve them for fixed versions would be very useful to us.

On Wednesday, September 19, 2012 4:04:37 PM UTC+1, Larry Shatzer, Jr. wrote:

I've noticed something weird with Maven projects that are set to build downstream jobs if there is a SNAPSHOT dependency. It now lists jobs as dependencies (and builds them) even if it is not a SNAPSHOT dependency but a regular dependency.

It looks like the code for JENKINS-12735 to allow version ranges is causing this. If you use version of <version>1.0.0</version>, that should not trigger it, but the other uses like [1.0.0,2.0.0), etc. should. This is causing lots of extra unnecessary builds when you have a lot of projects that are dependent on each other, but set to a release of the other and not a SNAPSHOT.

-- Larry

[Jay Meyer]

Thanks for linking to the Jira Issue I created a few days ago.  This traffic should raise some attention.  It's an annoying problem for us that puts our build validity at risk.  The Maven-Jenkins integration is a great feature for us.

https://issues.jenkins-ci.org/browse/JENKINS-15367

Kohsuke Kawaguchi is now assigned (by himself).  It might help for you to add comments to the Jira with any details you've noticed.

On Wednesday, September 19, 2012 10:04:37 AM UTC-5, Larry Shatzer, Jr. wrote:

I've noticed something weird with Maven projects that are set to build downstream jobs if there is a SNAPSHOT dependency. It now lists jobs as dependencies (and builds them) even if it is not a SNAPSHOT dependency but a regular dependency.

It looks like the code for JENKINS-12735 to allow version ranges is causing this. If you use version of <version>1.0.0</version>, that should not trigger it, but the other uses like [1.0.0,2.0.0), etc. should. This is causing lots of extra unnecessary builds when you have a lot of projects that are dependent on each other, but set to a release of the other and not a SNAPSHOT.

-- Larry

[Larry Shatzer, Jr.]

I got kohsuke's attention on IRC, and directed him to this thread and the ticket in question. This is also affecting the maven developers with their git migration: http://maven.40175.n5.nabble.com/Jenkins-jobs-for-the-projects-that-have-migrated-to-git-td5724895.html

-- Larry

On Mon, Oct 15, 2012 at 3:19 PM, Jay Meyer <[hidden email]> wrote:

Thanks for linking to the Jira Issue I created a few days ago.  This traffic should raise some attention.  It's an annoying problem for us that puts our build validity at risk.  The Maven-Jenkins integration is a great feature for us.

https://issues.jenkins-ci.org/browse/JENKINS-15367

Kohsuke Kawaguchi is now assigned (by himself).  It might help for you to add comments to the Jira with any details you've noticed.

On Wednesday, September 19, 2012 10:04:37 AM UTC-5, Larry Shatzer, Jr. wrote:

I've noticed something weird with Maven projects that are set to build downstream jobs if there is a SNAPSHOT dependency. It now lists jobs as dependencies (and builds them) even if it is not a SNAPSHOT dependency but a regular dependency.

It looks like the code for JENKINS-12735 to allow version ranges is causing this. If you use version of <version>1.0.0</version>, that should not trigger it, but the other uses like [1.0.0,2.0.0), etc. should. This is causing lots of extra unnecessary builds when you have a lot of projects that are dependent on each other, but set to a release of the other and not a SNAPSHOT.

-- Larry

[Jay Meyer]

Good.  Let me know if I can help - examples, testing ,etc.

On Monday, October 15, 2012 4:24:39 PM UTC-5, Larry Shatzer, Jr. wrote:

I got kohsuke's attention on IRC, and directed him to this thread and the ticket in question. This is also affecting the maven developers with their git migration: http://maven.40175.n5.nabble.com/Jenkins-jobs-for-the-projects-that-have-migrated-to-git-td5724895.html

-- Larry

On Mon, Oct 15, 2012 at 3:19 PM, Jay Meyer <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="6rCWRX8sz70J">jaym...@...> wrote:

Thanks for linking to the Jira Issue I created a few days ago.  This traffic should raise some attention.  It's an annoying problem for us that puts our build validity at risk.  The Maven-Jenkins integration is a great feature for us.

https://issues.jenkins-ci.org/browse/JENKINS-15367

Kohsuke Kawaguchi is now assigned (by himself).  It might help for you to add comments to the Jira with any details you've noticed.

On Wednesday, September 19, 2012 10:04:37 AM UTC-5, Larry Shatzer, Jr. wrote:

I've noticed something weird with Maven projects that are set to build downstream jobs if there is a SNAPSHOT dependency. It now lists jobs as dependencies (and builds them) even if it is not a SNAPSHOT dependency but a regular dependency.

It looks like the code for JENKINS-12735 to allow version ranges is causing this. If you use version of <version>1.0.0</version>, that should not trigger it, but the other uses like [1.0.0,2.0.0), etc. should. This is causing lots of extra unnecessary builds when you have a lot of projects that are dependent on each other, but set to a release of the other and not a SNAPSHOT.

-- Larry

[Jeff Maxwell]

We have the same requirement.

On Thursday, September 27, 2012 11:02:00 AM UTC-5, liam.j.bennett wrote:

While this is clearly a bug that needs fixing it would be useful to have the functionality to resolve downstream/upstream jobs with a fixed version (configurable of-course). 

We no longer use SNAPSHOTS but use release versions with BUILD_ID-BUILD_NUMBER and dynamically update dependencies using the maven-versions-plugin at build time. At the moment we are having to manually configure downstream/upstream relationships so having Jenkins auto-resolve them for fixed versions would be very useful to us.

On Wednesday, September 19, 2012 4:04:37 PM UTC+1, Larry Shatzer, Jr. wrote:

I've noticed something weird with Maven projects that are set to build downstream jobs if there is a SNAPSHOT dependency. It now lists jobs as dependencies (and builds them) even if it is not a SNAPSHOT dependency but a regular dependency.

It looks like the code for JENKINS-12735 to allow version ranges is causing this. If you use version of <version>1.0.0</version>, that should not trigger it, but the other uses like [1.0.0,2.0.0), etc. should. This is causing lots of extra unnecessary builds when you have a lot of projects that are dependent on each other, but set to a release of the other and not a SNAPSHOT.

-- Larry

[domi]

I think this should get fixed or reverted and back ported into the new LTS release.

/Domi

On 18.10.2012, at 21:43, Jeff Maxwell <[hidden email]> wrote:

We have the same requirement.

On Thursday, September 27, 2012 11:02:00 AM UTC-5, liam.j.bennett wrote:

While this is clearly a bug that needs fixing it would be useful to have the functionality to resolve downstream/upstream jobs with a fixed version (configurable of-course). 

We no longer use SNAPSHOTS but use release versions with BUILD_ID-BUILD_NUMBER and dynamically update dependencies using the maven-versions-plugin at build time. At the moment we are having to manually configure downstream/upstream relationships so having Jenkins auto-resolve them for fixed versions would be very useful to us.

On Wednesday, September 19, 2012 4:04:37 PM UTC+1, Larry Shatzer, Jr. wrote:

I've noticed something weird with Maven projects that are set to build downstream jobs if there is a SNAPSHOT dependency. It now lists jobs as dependencies (and builds them) even if it is not a SNAPSHOT dependency but a regular dependency.

It looks like the code for JENKINS-12735 to allow version ranges is causing this. If you use version of <version>1.0.0</version>, that should not trigger it, but the other uses like [1.0.0,2.0.0), etc. should. This is causing lots of extra unnecessary builds when you have a lot of projects that are dependent on each other, but set to a release of the other and not a SNAPSHOT.

-- Larry

[Julien Carsique]

Hi,

+1 for a revert even if JENKINS-15367 is supposed to be fixed.

There was no fix since 1.480. It is going to be fixed on 1.492 but please look at my comment [1]. If the second issue is confirmed and also due to JENKINS-12735, then it is almost as much blocker as the current issue. So, I still think it should have been/be reverted asap and until a fully working status is confirmed.

The current issue is not only triggering useless builds but also prevent the needed builds from happening.
The second issue I'm talking about (on relationships) is a major issue for analyzing breakages, finding upstream changes and notifying possible culprits.
Note I don't know how much they are linked but both issues are a regression compared to 1.480...

Cheers,

[1]: https://issues.jenkins-ci.org/browse/JENKINS-15367?focusedCommentId=170195&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-170195